rpms/kexec-tools
5
0
Fork 0
Code Issues Pull Requests Releases Activity

Fix potential-bashisms in monitor_dd_progress

Browse Source 
Resolves: RHEL-29044
Upstream: Fedora
Conflict: None

commit a5c17afe7e871f7a2593d04b97e8e77fb434642c
Author: Coiby Xu <coxu@redhat.com>
Date:   Fri Jan 12 20:00:53 2024 +0800

    Fix potential-bashisms in monitor_dd_progress

    As suggested by Carl [1],
    > /usr/lib/dracut/modules.d/99kdumpbase/monitor_dd_progress has some
    > inconsistencies with other scripts in that directory.  It is missing the
    > .sh extension and is not executable.  The latter is resulting in an
    > rpmlint error.

    [1] https://bugzilla.redhat.com/show_bug.cgi?id=2239566#c2

    Suggested-by: Carl George <carl@redhat.com>
    Signed-off-by: Coiby Xu <coxu@redhat.com>
    Reviewed-by: Philipp Rudo <prudo@redhat.com>
    Reviewed-by: Dave Young <dyoung@redhat.com>

Signed-off-by: Lichen Liu <lichliu@redhat.com>
This commit is contained in:
Lichen Liu 2024-04-29 10:26:47 +08:00
parent 612b6d7395
commit ace7b80a5b
No known key found for this signature in database
GPG Key ID: 2ED8215EF57B3D6C
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dracut-kdump.sh
View File

@ -377,7 +377,7 @@ dump_raw()
if ! echo "$CORE_COLLECTOR" | grep -q makedumpfile; then if ! echo "$CORE_COLLECTOR" | grep -q makedumpfile; then
_src_size=$(stat --format %s /proc/vmcore) _src_size=$(stat --format %s /proc/vmcore)
_src_size_mb=$((_src_size / 1048576)) _src_size_mb=$((_src_size / 1048576))
/kdumpscripts/monitor_dd_progress $_src_size_mb & /kdumpscripts/monitor_dd_progress.sh $_src_size_mb &
fi fi
dinfo "saving vmcore" dinfo "saving vmcore"

3
dracut-module-setup.sh
View File

@ -1020,8 +1020,7 @@ install() {
kdump_install_random_seed kdump_install_random_seed
fi fi
dracut_install -o /etc/adjtime /etc/localtime dracut_install -o /etc/adjtime /etc/localtime
inst "$moddir/monitor_dd_progress" "/kdumpscripts/monitor_dd_progress" inst "$moddir/monitor_dd_progress.sh" "/kdumpscripts/monitor_dd_progress.sh"
chmod +x "${initdir}/kdumpscripts/monitor_dd_progress"
inst "/bin/dd" "/bin/dd" inst "/bin/dd" "/bin/dd"
inst "/bin/tail" "/bin/tail" inst "/bin/tail" "/bin/tail"
inst "/bin/date" "/bin/date" inst "/bin/date" "/bin/date"

0
dracut-monitor_dd_progress → dracut-monitor_dd_progress.sh
View File