From a68231599670e0758e3242719686a898025449f0 Mon Sep 17 00:00:00 2001 From: Baoquan He Date: Thu, 10 Oct 2013 17:02:58 +0800 Subject: [PATCH] kdump-lib.sh: strip_comments is not implemented correcty In mkdumprd, strip_comments is not implemented correctly. Since arguments passed, strip_comments only take $1 and misses others. This caused problems. Such as below line, current code will only get "makedumpfile" and pass it to $config_val finally, then parameters for makedumpfile are missed. core_collector makedumpfile -c --message-level 1 -d 31 Now modify function strip_comments. Signed-off-by: Baoquan He Acked-by: WANG Chao Acked-by: Dave Young --- kdump-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kdump-lib.sh b/kdump-lib.sh index 4df5315..e73ac09 100755 --- a/kdump-lib.sh +++ b/kdump-lib.sh @@ -20,5 +20,5 @@ is_raw_dump_target() strip_comments() { - echo $1 | sed -e 's/\(.*\)#.*/\1/' + echo $@ | sed -e 's/\(.*\)#.*/\1/' }