From 99de77bba7ff7668edab3da723aad7c1c8395b5f Mon Sep 17 00:00:00 2001 From: Tao Liu Date: Fri, 21 Jan 2022 16:08:47 +0800 Subject: [PATCH] Revert "Remove trace_buf_size and trace_event from the kernel bootparameters of the kdump kernel" There is a mechanism to keep memory consumption minimum, i.e. equal to trace_buf_size=1, until tracing by ftrace is actually started: tracing: keep ring buffer to minimum size till used https://github.com/torvalds/linux/commit/73c5162aa362a543793f4a957c6c536dcbaa89ce Since ftrace is usually never used in the kdump 2nd kernel, the kdump 2nd kernel behaves in the same way with or without trace_buf_size=1. So the issue which the patch want to solve never exists. Let's revert the patch for better maintainance and avoid confusion. ref link: https://bugzilla.redhat.com/show_bug.cgi?id=2034501#c20 This reverts commit f39000f. Signed-off-by: Tao Liu Acked-by: Coiby Xu --- kdump-lib.sh | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kdump-lib.sh b/kdump-lib.sh index 0e64f22..3256581 100755 --- a/kdump-lib.sh +++ b/kdump-lib.sh @@ -782,10 +782,6 @@ prepare_cmdline() fi done - # Remove trace_buf_size, trace_event - cmdline=$(remove_cmdline_param "$cmdline" trace_buf_size trace_event) - cmdline="${cmdline} trace_buf_size=1" - echo "$cmdline" }