From 85c3d6643dd404e2a3d891a08d007da73f3c9c1d Mon Sep 17 00:00:00 2001
From: Kairui Song <kasong@redhat.com>
Date: Mon, 11 Jan 2021 10:03:12 +0800
Subject: [PATCH] kdump.conf: Update doc about core_collector for ssh target

The current inline comment is a bit misleading, ssh dump target don't
need to use scp as core_collector, and when using scp as core_collector,
the vmcore could be huge.

Signed-off-by: Kairui Song <kasong@redhat.com>
Acked-by: Pingfan Liu <piliu@redhat.com>
---
 kdump.conf   | 2 +-
 kdump.conf.5 | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/kdump.conf b/kdump.conf
index e4db52e..bd98b79 100644
--- a/kdump.conf
+++ b/kdump.conf
@@ -21,7 +21,7 @@
 #             <mnt>/<path>/%HOST-%DATE/, supports DNS.
 #
 # ssh <user@server>
-#           - Will scp /proc/vmcore to <user@server>:<path>/%HOST-%DATE/,
+#           - Will save /proc/vmcore to <user@server>:<path>/%HOST-%DATE/,
 #             supports DNS.
 #             NOTE: make sure the user has write permissions on the server.
 #
diff --git a/kdump.conf.5 b/kdump.conf.5
index ae07466..2c5a2bc 100644
--- a/kdump.conf.5
+++ b/kdump.conf.5
@@ -98,6 +98,11 @@ vmcore.flat, you will need to use "makedumpfile -R" to rearrange the
 dump data from standard input to a normal dumpfile (readable with analysis
 tools).
 ie. "makedumpfile -R vmcore < vmcore.flat"
+.PP
+Note 3: If specified core_collector simply copy the vmcore file to the
+dump target (eg: cp, scp), the vmcore could be significantly large.
+Please make sure the dump target has enough space, at leaset larger
+than the system's RAM.
 
 .RE