kdump.service: Replace ConditionKernelCommandLine with ExecCondition

Resolves: https://issues.redhat.com/browse/RHEL-61620
Upstream: kdump-utils

commit 6f32fab791746da3f075273e156bd70055db5d4c
Author: Sourabh Jain <sourabhjain@linux.ibm.com>
Date:   Fri Oct 4 20:09:35 2024 +0530

    kdump.service: Replace ConditionKernelCommandLine with ExecCondition

    Commit 0084806493 ("kdump.service: use ConditionKernelCommandLine=crashkernel")
    added a condition based on the crashkernel kernel command line parameter to
    control the start of the kdump service.

    While ConditionKernelCommandLine=crashkernel works well for kdump, it causes
    issues for fadump (specific to the PowerPC architecture), which also uses the
    same service unit. Unlike kdump, crashkernel kernel command-line is not
    mandatory for fadump.

    Since ConditionKernelCommandLine doesn't support evaluating multiple kernel
    command line parameters with dependencies between them, it has been replaced
    with ExecCondition to resolve this limitation.

    Now, if fadump is configured and the crashkernel parameter is NOT present in the
    kernel command line, kdump service will start.

    Fixes: #35
    Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>

Signed-off-by: Pingfan Liu <piliu@redhat.com>

kdump.service

@@ -2,10 +2,10 @@
 Description=Crash recovery kernel arming
 After=network.target network-online.target remote-fs.target basic.target
 DefaultDependencies=no
-ConditionKernelCommandLine=crashkernel
 
 [Service]
 Type=oneshot
+ExecCondition=/bin/sh -c 'grep -q -e "crashkernel" -e "fadump" /proc/cmdline'
 ExecStart=/usr/bin/kdumpctl start
 ExecStop=/usr/bin/kdumpctl stop
 ExecReload=/usr/bin/kdumpctl reload