rpms/kexec-tools
7
0
Fork 0
Code Issues Pull Requests Releases Activity

Revert "kdumpctl: filter 'root' kernel parameter when running in live images"

Browse Source 
This reverts commit 892bea7aa

We already eliminated the root filesystem by removing "root=X"
in case of non-root dumping, and for livecd it must be non-root
dumping according to "live-image-kdump-howto.txt".

So it's time to revert this commit.

Also update "live-image-kdump-howto.txt", make sure users do not
configure "default dump_to_rootfs".

Signed-off-by: Xunlei Pang <xlpang@redhat.com>
Acked-by: Pratyush Anand <panand@redhat.com>
Acked-by:Dave Young <dyoung@redhat.com>
This commit is contained in:
Xunlei Pang 2017-04-05 19:34:13 +08:00 committed by Dave Young
parent b40c1f96cf
commit 3b311653f2
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kdumpctl
View File

@ -184,10 +184,6 @@ prepare_cmdline()
if [ -z "$KDUMP_COMMANDLINE" ]; then if [ -z "$KDUMP_COMMANDLINE" ]; then
cmdline=`cat /proc/cmdline` cmdline=`cat /proc/cmdline`
# 'root' parameter will cause kdump failure in live images
if [[ ${cmdline} == *"root=live:"* ]]; then
KDUMP_COMMANDLINE_REMOVE="${KDUMP_COMMANDLINE_REMOVE} root"
fi
else else
cmdline=${KDUMP_COMMANDLINE} cmdline=${KDUMP_COMMANDLINE}
fi fi

2
live-image-kdump-howto.txt
View File

@ -13,6 +13,8 @@ When kdump kernel boots in a live environment, the default target /var/crash is
in RAM so you need to change the dump target to an external disk or a network in RAM so you need to change the dump target to an external disk or a network
dump target. dump target.
Besides, make sure that "default dump_to_rootfs" is not specified.
3. Start kdump service 3. Start kdump service
$ kdumpctl start $ kdumpctl start