rpms/kexec-tools
7
0
Fork 0
Code Issues Pull Requests Releases Activity

Add sanity checks for the log levels

Browse Source 
Let's add sanity checks for the log levels in order to avoid
passing illegal log levels to the logger.

Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
Acked-by: Kairui Song <kasong@redhat.com>
This commit is contained in:
Lianbo Jiang 2020-11-12 23:55:37 +08:00 committed by Kairui Song
parent 69bf81bc8b
commit 2dea15c4fd
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
kdump-logger.sh
View File

@ -34,15 +34,42 @@
# First of all you have to start with dlog_init() function which initializes # First of all you have to start with dlog_init() function which initializes
# required variables. Don't call any other logging function before that one! # required variables. Don't call any other logging function before that one!
# #
# @brief Check the log level.
# @retval 1 if something has gone wrong
# @retval 0 on success.
#
check_loglvl()
{
case "$1" in
0|1|2|3|4|5|6)
return 0
;;
*)
return 1
;;
esac
}
# @brief Initializes Logger. # @brief Initializes Logger.
# @retval 1 if something has gone wrong # @retval 1 if something has gone wrong
# @retval 0 on success. # @retval 0 on success.
# #
dlog_init() { dlog_init() {
local ret=0; local errmsg local ret=0; local errmsg
[ -z "$kdump_stdloglvl" ] && kdump_stdloglvl=4 [ -z "$kdump_stdloglvl" ] && kdump_stdloglvl=4
[ -z "$kdump_sysloglvl" ] && kdump_sysloglvl=4 [ -z "$kdump_sysloglvl" ] && kdump_sysloglvl=4
[ -z "$kdump_kmsgloglvl" ] && kdump_kmsgloglvl=0 [ -z "$kdump_kmsgloglvl" ] && kdump_kmsgloglvl=0
for loglvl in "$kdump_stdloglvl" "$kdump_kmsgloglvl" "$kdump_sysloglvl"; do
check_loglvl "$loglvl"
if [ $? -ne 0 ]; then
echo "Illegal log level: $kdump_stdloglvl $kdump_kmsgloglvl $kdump_sysloglvl"
return 1
fi
done
# Skip initialization if it's already done. # Skip initialization if it's already done.
[ -n "$kdump_maxloglvl" ] && return 0 [ -n "$kdump_maxloglvl" ] && return 0