rpms/kexec-tools
5
0
Fork 0
Code Issues Pull Requests Releases Activity

kdump-dep-generator: source kdump-lib-initramfs.sh instead

Browse Source 
Currently kdump-dep-generator will source kdump-lib.sh. Notice
kdump-dep-generator have #!/bin/sh so it should be POSIX, but
kdump-lib.sh is a non-POSIX bash script. When Bash is configured to run
in POSIX mode for #!/bin/sh scripts, it will fail with:

/usr/lib/kdump/kdump-lib.sh: line 1042: syntax error near unexpected token `<'
/usr/lib/kdump/kdump-lib.sh: line 1042: `	done < <( _crashkernel_parse "$ck")'

This subshell call is easy to convert into a pipe but we should just
source kdump-lib-initramfs.sh here, the only thing kdump-dep-generator
needs is is_ssh_dump_target which is in kdump-lib-initramfs.sh, also
prevents further POSIX violations.

Signed-off-by: Kairui Song <kasong@tencent.com>
Reviewed-by: Philipp Rudo <prudo@redhat.com>
This commit is contained in:
Kairui Song 2024-01-30 01:54:05 +08:00 committed by Coiby Xu
parent 97b3b962a9
commit 2974fa3f26
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kdump-dep-generator.sh
View File

@ -3,7 +3,7 @@
# More details about systemd generator: # More details about systemd generator:
# http://www.freedesktop.org/wiki/Software/systemd/Generators/ # http://www.freedesktop.org/wiki/Software/systemd/Generators/
. /usr/lib/kdump/kdump-lib.sh . /usr/lib/kdump/kdump-lib-initramfs.sh
. /usr/lib/kdump/kdump-logger.sh . /usr/lib/kdump/kdump-logger.sh
# If invokded with no arguments for testing purpose, output to /tmp to # If invokded with no arguments for testing purpose, output to /tmp to