kexec-tools/92-crashkernel.install

#!/usr/bin/bash

COMMAND="$1"
KERNEL_VERSION="$2"
KDUMP_INITRD_DIR_ABS="$3"
KERNEL_IMAGE="$4"

case "$COMMAND" in
add)
	kdumpctl reset-crashkernel-for-installed_kernel "$KERNEL_VERSION"
	exit 0
	;;
esac
Add a new hook: 92-crashkernel.install Resolves: bz1974638 Upstream: Fedora Conflict: Minor conflict in spec file resolved easily commit 646364193597401a55eb2485ef7840bb5eef7d88 Author: Kairui Song <kasong@redhat.com> Date: Thu Jun 10 13:06:23 2021 +0800 Add a new hook: 92-crashkernel.install To track and manage kernel's crashkernel usage by kernel version, each kernel package will include a crashkernel.default containing the default `crashkernel=` value of that kernel. So we can use a hook to update the kernel cmdline of new installed kernel accordingly. Put it after all other grub boot loader setup hooks, so it can simply call grubby to modify the kernel cmdline. Signed-off-by: Kairui Song <kasong@redhat.com> Acked-by: Baoquan He <bhe@redhat.com> Signed-off-by: Kairui Song <kasong@redhat.com> 2021-06-10 05:06:23 +00:00			`#!/usr/bin/bash`

			`COMMAND="$1"`
			`KERNEL_VERSION="$2"`
			`KDUMP_INITRD_DIR_ABS="$3"`
			`KERNEL_IMAGE="$4"`

			`case "$COMMAND" in`
			`add)`
reset kernel crashkernel for the special case where the kernel is updated right after kexec-tools Resolves: bz1895258 Upstream: Fedora Conflict: None commit 5e8c751c39a5ec9d10009cba1c2bd554a5763b90 Author: Coiby Xu <coxu@redhat.com> Date: Thu Dec 2 17:19:50 2021 +0800 reset kernel crashkernel for the special case where the kernel is updated right after kexec-tools When kexec-tools updates the default crashkernel value, it will try to reset the existing installed kernels including the currently running kernel. So the running kernel could have different kernel cmdline parameters from /proc/cmdline. When installing a kernel after updating kexec-tools, /usr/lib/kernel/install.d/20-grub.install would be called by kernel-install [1] which would use /proc/cmdline to set up new kernel's cmdline. To address this special case, reset the new kernel's crashkernel and fadump value to the value that would be used by running kernel after rebooting by the installation hook. One side effect of this commit is it would reset the installed kernel's crashkernel even currently running kernel don't use the default crashkernel value after rebooting. But I think this side effect is a benefit for the user. The implementation depends on kernel-install which run the scripts in /usr/lib/kernel/install.d passing the following arguments, add KERNEL-VERSION $BOOT/MACHINE-ID/KERNEL-VERSION/ KERNEL-IMAGE [INITRD-FILE ...] An concrete example is given as follows, add 5.11.12-300.fc34.x86_64 /boot/e986846f63134c7295458cf36300ba5b/5.11.12-300.fc34.x86_64 /lib/modules/5.11.12-300.fc34.x86_64/vmlinuz kernel-install could be started by the kernel package's RPM scriplet [2]. As mentioned in previous commit "try to reset kernel crashkernel when kexec-tools updates the default crashkernel value", kdumpctl has difficulty running in RPM scriptlet fore CoreOS. But rpm-ostree ignores all kernel hooks, there is no need to disable the kernel hook for CoreOS/Atomic/Silverblue. But a collaboration between rpm-ostree and kexec-tools is needed [3] to take care of this special case. Note the crashkernel.default support is dropped. [1] https://www.freedesktop.org/software/systemd/man/kernel-install.html [2] https://src.fedoraproject.org/rpms/kernel/blob/rawhide/f/kernel.spec#_2680 [3] https://github.com/coreos/rpm-ostree/issues/2894 Reviewed-by: Pingfan Liu <piliu@redhat.com> Reviewed-by: Philipp Rudo <prudo@redhat.com> Signed-off-by: Coiby Xu <coxu@redhat.com> Signed-off-by: Coiby Xu <coxu@redhat.com> 2022-01-05 03:53:22 +00:00			`kdumpctl reset-crashkernel-for-installed_kernel "$KERNEL_VERSION"`
92-crashkernel.install: fix exit code upstream: fedora resolves: bz2003832 conflict: none commit f6e6aa45518aab0bfbbe8fa4fc94eb3f33036aa1 Author: Kairui Song <kasong@redhat.com> Date: Wed Sep 1 17:38:50 2021 +0800 92-crashkernel.install: fix exit code The return value of set_ck_kernel or set_grub_ck is wrongly being used as the exit code. This hook should exit with 0 or it may result in unexpected behavior of kernel-install. Signed-off-by: Kairui Song <kasong@redhat.com> Acked-by: Pingfan Liu <piliu@redhat.com> Signed-off-by: Tao Liu <ltao@redhat.com> 2021-11-03 11:38:17 +00:00			`exit 0`
Add a new hook: 92-crashkernel.install Resolves: bz1974638 Upstream: Fedora Conflict: Minor conflict in spec file resolved easily commit 646364193597401a55eb2485ef7840bb5eef7d88 Author: Kairui Song <kasong@redhat.com> Date: Thu Jun 10 13:06:23 2021 +0800 Add a new hook: 92-crashkernel.install To track and manage kernel's crashkernel usage by kernel version, each kernel package will include a crashkernel.default containing the default `crashkernel=` value of that kernel. So we can use a hook to update the kernel cmdline of new installed kernel accordingly. Put it after all other grub boot loader setup hooks, so it can simply call grubby to modify the kernel cmdline. Signed-off-by: Kairui Song <kasong@redhat.com> Acked-by: Baoquan He <bhe@redhat.com> Signed-off-by: Kairui Song <kasong@redhat.com> 2021-06-10 05:06:23 +00:00			`;;`
			`esac`