34 lines
1.1 KiB
Diff
34 lines
1.1 KiB
Diff
|
From 527a5767c165abd2b4dba99da992c51ca7547562 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Kangjie Lu <kangjielu@gmail.com>
|
||
|
|
Date: Tue, 3 May 2016 16:44:07 -0400
|
||
|
|
Subject: [PATCH 1/3] ALSA: timer: Fix leak in SNDRV_TIMER_IOCTL_PARAMS
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
The stack object “tread” has a total size of 32 bytes. Its field
|
||
|
|
“event” and “val” both contain 4 bytes padding. These 8 bytes
|
||
|
|
padding bytes are sent to user without being initialized.
|
||
|
|
|
||
|
|
Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
|
||
|
|
Signed-off-by: Takashi Iwai <tiwai@suse.de>
|
||
|
|
---
|
||
|
|
sound/core/timer.c | 1 +
|
||
|
|
1 file changed, 1 insertion(+)
|
||
|
|
|
||
|
|
diff --git a/sound/core/timer.c b/sound/core/timer.c
|
||
|
|
index 6469bedda2f3..964f5ebf495e 100644
|
||
|
|
--- a/sound/core/timer.c
|
||
|
|
+++ b/sound/core/timer.c
|
||
|
|
@@ -1739,6 +1739,7 @@ static int snd_timer_user_params(struct file *file,
|
||
|
|
if (tu->timeri->flags & SNDRV_TIMER_IFLG_EARLY_EVENT) {
|
||
|
|
if (tu->tread) {
|
||
|
|
struct snd_timer_tread tread;
|
||
|
|
+ memset(&tread, 0, sizeof(tread));
|
||
|
|
tread.event = SNDRV_TIMER_EVENT_EARLY;
|
||
|
|
tread.tstamp.tv_sec = 0;
|
||
|
|
tread.tstamp.tv_nsec = 0;
|
||
|
|
--
|
||
|
|
2.5.5
|
||
|
|
|