jasper/jasper-1.900.1-Coverity-UNUSED_VALUE.patch

42 lines
1.6 KiB
Diff
Raw Normal View History

Error: UNUSED_VALUE
base/jas_icc.c:328: returned_pointer: Pointer "attrvalinfo" returned by "jas_iccattrvalinfo_lookup(type)" is never used.
jpc/jpc_enc.c:788: returned_pointer: Pointer "cp" returned by "strchr(s, 66)" is never used.
diff -up jasper-1.900.1/src/libjasper/base/jas_icc.c.unused_value jasper-1.900.1/src/libjasper/base/jas_icc.c
--- jasper-1.900.1/src/libjasper/base/jas_icc.c.unused_value 2007-01-19 22:43:05.000000000 +0100
+++ jasper-1.900.1/src/libjasper/base/jas_icc.c 2011-06-27 15:35:52.815263000 +0200
@@ -266,7 +266,6 @@ jas_iccprof_t *jas_iccprof_load(jas_stre
jas_iccattrval_t *attrval;
jas_iccattrval_t *prevattrval;
jas_icctagtabent_t *tagtabent;
- jas_iccattrvalinfo_t *attrvalinfo;
int i;
int len;
@@ -325,7 +324,7 @@ jas_iccprof_t *jas_iccprof_load(jas_stre
goto error;
}
curoff += 8;
- if (!(attrvalinfo = jas_iccattrvalinfo_lookup(type))) {
+ if (!jas_iccattrvalinfo_lookup(type)) {
#if 0
jas_eprintf("warning: skipping unknown tag type\n");
#endif
diff -up jasper-1.900.1/src/libjasper/jpc/jpc_enc.c.unused_value jasper-1.900.1/src/libjasper/jpc/jpc_enc.c
--- jasper-1.900.1/src/libjasper/jpc/jpc_enc.c.unused_value 2007-01-19 22:43:07.000000000 +0100
+++ jasper-1.900.1/src/libjasper/jpc/jpc_enc.c 2011-06-27 15:36:17.437900180 +0200
@@ -781,11 +781,10 @@ void jpc_enc_cp_destroy(jpc_enc_cp_t *cp
int ratestrtosize(char *s, uint_fast32_t rawsize, uint_fast32_t *size)
{
- char *cp;
jpc_flt_t f;
/* Note: This function must not modify output size on failure. */
- if ((cp = strchr(s, 'B'))) {
+ if (strchr(s, 'B')) {
*size = atoi(s);
} else {
f = atof(s);