66 lines
2.9 KiB
Diff
66 lines
2.9 KiB
Diff
From a24f83b833eb515e60a6e5b8144834bae7a78f70 Mon Sep 17 00:00:00 2001
|
|
From: Jan Cholasta <jcholast@redhat.com>
|
|
Date: Tue, 26 Nov 2013 08:53:34 +0000
|
|
Subject: [PATCH 9/9] Remove mod_ssl port workaround.
|
|
|
|
https://fedorahosted.org/freeipa/ticket/4021
|
|
---
|
|
install/tools/ipa-upgradeconfig | 2 +-
|
|
ipaserver/install/httpinstance.py | 17 ++++++++---------
|
|
3 files changed, 15 insertions(+), 12 deletions(-)
|
|
|
|
diff --git a/install/tools/ipa-upgradeconfig b/install/tools/ipa-upgradeconfig
|
|
index cf9fe0e040e56bb75ca8d53e28586911caeffb2b..a31f7d092981c33694268f420892a781e9b02b3f 100644
|
|
--- a/install/tools/ipa-upgradeconfig
|
|
+++ b/install/tools/ipa-upgradeconfig
|
|
@@ -1052,7 +1052,7 @@ def main():
|
|
http = httpinstance.HTTPInstance(fstore)
|
|
http.remove_httpd_ccache()
|
|
http.configure_selinux_for_httpd()
|
|
- http.change_mod_nss_port_to_http()
|
|
+ http.change_mod_nss_port_from_http()
|
|
|
|
ds = dsinstance.DsInstance()
|
|
ds.configure_dirsrv_ccache()
|
|
diff --git a/ipaserver/install/httpinstance.py b/ipaserver/install/httpinstance.py
|
|
index 5d37926ddcaa17ce2eab839cd6aecdab0159a8ee..34e58fbb845c91c42a37d94a172e167cfb6f1790 100644
|
|
--- a/ipaserver/install/httpinstance.py
|
|
+++ b/ipaserver/install/httpinstance.py
|
|
@@ -237,25 +237,24 @@ def __configure_http(self):
|
|
http_fd.close()
|
|
os.chmod(target_fname, 0644)
|
|
|
|
- def change_mod_nss_port_to_http(self):
|
|
+ def change_mod_nss_port_from_http(self):
|
|
# mod_ssl enforces SSLEngine on for vhost on 443 even though
|
|
# the listener is mod_nss. This then crashes the httpd as mod_nss
|
|
# listened port obviously does not match mod_ssl requirements.
|
|
#
|
|
- # Change port to http to workaround the mod_ssl check, the SSL is
|
|
- # enforced in the vhost later, so it is benign.
|
|
+ # The workaround for this was to change port to http. It is no longer
|
|
+ # necessary, as mod_nss now ships with default configuration which
|
|
+ # sets SSLEngine off when mod_ssl is installed.
|
|
#
|
|
- # Remove when https://bugzilla.redhat.com/show_bug.cgi?id=1023168
|
|
- # is fixed.
|
|
- if not sysupgrade.get_upgrade_state('nss.conf', 'listen_port_updated'):
|
|
- installutils.set_directive(NSS_CONF, 'Listen', '443 http', quotes=False)
|
|
- sysupgrade.set_upgrade_state('nss.conf', 'listen_port_updated', True)
|
|
+ # Remove the workaround.
|
|
+ if sysupgrade.get_upgrade_state('nss.conf', 'listen_port_updated'):
|
|
+ installutils.set_directive(NSS_CONF, 'Listen', '443', quotes=False)
|
|
+ sysupgrade.set_upgrade_state('nss.conf', 'listen_port_updated', False)
|
|
|
|
def __set_mod_nss_port(self):
|
|
self.fstore.backup_file(NSS_CONF)
|
|
if installutils.update_file(NSS_CONF, '8443', '443') != 0:
|
|
print "Updating port in %s failed." % NSS_CONF
|
|
- self.change_mod_nss_port_to_http()
|
|
|
|
def __set_mod_nss_nickname(self, nickname):
|
|
installutils.set_directive(NSS_CONF, 'NSSNickname', nickname)
|
|
--
|
|
1.8.5.3
|
|
|