90796e1d08
- ipatests: ignore nsslapd-accesslog-logbuffering WARN in healthcheck - ipatests: Skip ds_encryption tests on RHEL9 SUT. - adtrustinstance: make sure NetBIOS name defaults are set properly - ipatests: wait for replica update in test_dns_locations - ipapython: Clean up krb5_error - ipapython: Correct return type of krb5_free_cred_contents - ipapython: Propagate KRB5Error exceptions on iterating ccache - ipa-kdb: Fix memory leak during PAC verification - sidgen: ignore staged users when generating SIDs - sidgen: fix missing prototypes - kdb: PAC generator: do not fail if canonical principal is missing - ipatests: fix tasks.wait_for_replication method - ipa-kdb: Rework ipadb_reinit_mspac() - ipa-kdb: Fix double free in ipadb_reinit_mspac()
90 lines
2.7 KiB
Diff
90 lines
2.7 KiB
Diff
From e831416320fdc73a18fba7716209edec76681721 Mon Sep 17 00:00:00 2001
|
|
From: Julien Rische <jrische@redhat.com>
|
|
Date: Jan 30 2024 15:16:22 +0000
|
|
Subject: ipa-kdb: Fix memory leak during PAC verification
|
|
|
|
|
|
Commit 0022bd70d93708d325855d5271516d6cd894d6e8 introduced a memory leak
|
|
during the copy of some PAC buffers, because of an unfreed memory
|
|
allocation context.
|
|
|
|
Fixes: https://pagure.io/freeipa/issue/9520
|
|
|
|
Signed-off-by: Julien Rische <jrische@redhat.com>
|
|
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
|
|
|
|
---
|
|
|
|
diff --git a/daemons/ipa-kdb/ipa_kdb_mspac.c b/daemons/ipa-kdb/ipa_kdb_mspac.c
|
|
index 1558e2b..2866304 100644
|
|
--- a/daemons/ipa-kdb/ipa_kdb_mspac.c
|
|
+++ b/daemons/ipa-kdb/ipa_kdb_mspac.c
|
|
@@ -2316,6 +2316,7 @@ krb5_error_code ipadb_common_verify_pac(krb5_context context,
|
|
size_t i;
|
|
struct dom_sid *requester_sid = NULL;
|
|
struct dom_sid req_sid;
|
|
+ TALLOC_CTX *tmpctx = NULL;
|
|
|
|
if (signing_krbtgt != NULL &&
|
|
ipadb_is_cross_realm_krbtgt(signing_krbtgt->princ)) {
|
|
@@ -2371,6 +2372,12 @@ krb5_error_code ipadb_common_verify_pac(krb5_context context,
|
|
goto done;
|
|
}
|
|
|
|
+ tmpctx = talloc_new(NULL);
|
|
+ if (tmpctx == NULL) {
|
|
+ kerr = ENOMEM;
|
|
+ goto done;
|
|
+ }
|
|
+
|
|
for (i = 0; i < num_buffers; i++) {
|
|
if (types[i] == KRB5_PAC_SERVER_CHECKSUM ||
|
|
types[i] == KRB5_PAC_PRIVSVR_CHECKSUM ||
|
|
@@ -2398,32 +2405,21 @@ krb5_error_code ipadb_common_verify_pac(krb5_context context,
|
|
DATA_BLOB pac_attrs_data;
|
|
krb5_boolean pac_requested;
|
|
|
|
- TALLOC_CTX *tmpctx = talloc_new(NULL);
|
|
- if (tmpctx == NULL) {
|
|
- kerr = ENOMEM;
|
|
- goto done;
|
|
- }
|
|
-
|
|
kerr = ipadb_client_requested_pac(context, old_pac, tmpctx, &pac_requested);
|
|
- if (kerr != 0) {
|
|
- talloc_free(tmpctx);
|
|
+ if (kerr)
|
|
goto done;
|
|
- }
|
|
|
|
kerr = ipadb_get_pac_attrs_blob(tmpctx, &pac_requested, &pac_attrs_data);
|
|
- if (kerr) {
|
|
- talloc_free(tmpctx);
|
|
+ if (kerr)
|
|
goto done;
|
|
- }
|
|
+
|
|
data.magic = KV5M_DATA;
|
|
data.data = (char *)pac_attrs_data.data;
|
|
data.length = pac_attrs_data.length;
|
|
|
|
kerr = krb5_pac_add_buffer(context, new_pac, PAC_TYPE_ATTRIBUTES_INFO, &data);
|
|
- if (kerr) {
|
|
- talloc_free(tmpctx);
|
|
+ if (kerr)
|
|
goto done;
|
|
- }
|
|
|
|
continue;
|
|
}
|
|
@@ -2470,6 +2466,8 @@ done:
|
|
if (kerr != 0 && (new_pac != *pac)) {
|
|
krb5_pac_free(context, new_pac);
|
|
}
|
|
+ if (tmpctx)
|
|
+ talloc_free(tmpctx);
|
|
krb5_free_data_contents(context, &pac_blob);
|
|
free(types);
|
|
return kerr;
|
|
|