From 05a298f56485222583cb7dd4f6a3a4c5c77fc8cf Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud Date: Sun, 7 Aug 2022 12:44:47 +0200 Subject: [PATCH] check_repl_update: in progress is a boolean With the fix for https://pagure.io/freeipa/issue/9171, nsds5replicaUpdateInProgress is now handled as a boolean. One remaining occurrence was still handling it as a string and calling lower() on its value. Replace with direct boolean comparison. Fixes: https://pagure.io/freeipa/issue/9218 Signed-off-by: Florence Blanc-Renaud Reviewed-By: Alexander Bokovoy --- ipaserver/install/replication.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipaserver/install/replication.py b/ipaserver/install/replication.py index 16be3760c..9d9aa1c4b 100644 --- a/ipaserver/install/replication.py +++ b/ipaserver/install/replication.py @@ -1152,7 +1152,7 @@ class ReplicationManager: except (ValueError, TypeError, KeyError): end = 0 # incremental update is done if inprogress is false and end >= start - done = inprogress and inprogress.lower() == 'false' and start <= end + done = inprogress is not None and not inprogress and start <= end logger.info("Replication Update in progress: %s: status: %s: " "start: %d: end: %d", inprogress, status, start, end) -- 2.37.2