From 061e0b63ef3a72ba3261b42ec5f2ce290070c613 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Cami?= Date: Mon, 15 Mar 2021 16:55:08 +0100 Subject: [PATCH] ipa-client-install: output a warning if sudo is not present (2) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes: https://pagure.io/freeipa/issue/8530 Signed-off-by: François Cami Reviewed-By: Armando Neto --- ipaclient/install/client.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipaclient/install/client.py b/ipaclient/install/client.py index 0e478fa26..9bdfbddaf 100644 --- a/ipaclient/install/client.py +++ b/ipaclient/install/client.py @@ -2205,7 +2205,7 @@ def install_check(options): # available. if options.conf_sudo: try: - subprocess.Popen(['sudo -V']) + subprocess.Popen(['sudo', '-V']) except FileNotFoundError: logger.info( "The sudo binary does not seem to be present on this " -- 2.30.2 From 4b917833fdd62cce2fd72809fd5c963194efba3e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Cami?= Date: Mon, 15 Mar 2021 17:00:05 +0100 Subject: [PATCH] ipatests: check for the "no sudo present" string absence MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When sudo is installed, no warning should be output about sudo not being available (obviously). Check that the relevant string is not present. Fixes: https://pagure.io/freeipa/issue/8530 Signed-off-by: François Cami Reviewed-By: Armando Neto --- ipatests/test_integration/test_installation.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ipatests/test_integration/test_installation.py b/ipatests/test_integration/test_installation.py index a50a59f1a..a5ff17a0d 100644 --- a/ipatests/test_integration/test_installation.py +++ b/ipatests/test_integration/test_installation.py @@ -1620,3 +1620,5 @@ class TestInstallWithoutSudo(IntegrationTest): tasks.install_packages(self.clients[0], ['sudo']) for pkg in ('sudo', 'libsss_sudo'): assert tasks.is_package_installed(self.clients[0], pkg) + result = tasks.install_client(self.master, self.clients[0]) + assert self.no_sudo_str not in result.stderr_text -- 2.30.2