From 473b1e465ba93ec313bc7cea62bb8d545f37e8bd Mon Sep 17 00:00:00 2001 From: Mark Reynolds Date: Tue, 12 Dec 2023 08:39:14 -0500 Subject: [PATCH] Issue 9497 - update debug logging in ipa_modrdn Fixes: https://pagure.io/freeipa/issue/9497 Signed-off-by: Mark Reynolds Reviewed-By: Alexander Bokovoy --- daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c b/daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c index 6cec5f242b7d23d3752e5bc30c67e034abc96abb..8be192a5e94211f94a7f3a8a62409250b723ddb5 100644 --- a/daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c +++ b/daemons/ipa-slapi-plugins/ipa-modrdn/ipa_modrdn.c @@ -30,7 +30,7 @@ * Program may make changes or additions to the list of Approved * Interfaces. * - * Copyright (C) 2010 Red Hat, Inc. + * Copyright (C) 2010-2023 Red Hat, Inc. * All rights reserved. * END COPYRIGHT BLOCK **/ @@ -350,7 +350,6 @@ ipamodrdn_load_plugin_config(void) { int status = EOK; int result; - int i; Slapi_PBlock *search_pb; Slapi_Entry **entries = NULL; @@ -379,7 +378,7 @@ ipamodrdn_load_plugin_config(void) goto cleanup; } - for (i = 0; (entries[i] != NULL); i++) { + for (size_t i = 0; (entries[i] != NULL); i++) { /* We don't care about the status here because we may have * some invalid config entries, but we just want to continue * looking for valid ones. */ @@ -680,7 +679,8 @@ ipamodrdn_change_attr(struct configEntry *cfgentry, slapi_modify_internal_pb(mod_pb); slapi_pblock_get(mod_pb, SLAPI_PLUGIN_INTOP_RESULT, &ret); if (ret != LDAP_SUCCESS) { - LOG_FATAL("Failed to change attribute with error %d\n", ret); + LOG_FATAL("Failed to change attribute '%s' in '%s' with error %d\n", + cfgentry->tattr, targetdn, ret); ret = EFAIL; } ret = EOK; -- 2.43.0