a75d097e82
This test started failing after the onset of Hebrew calendar year 5784, which started the evening of 15 September 2023 CE, includes a leap month, and continues into 2024 CE which has a leap day. https://github.com/unicode-org/icu/pull/2610
34 lines
1.5 KiB
Diff
34 lines
1.5 KiB
Diff
From f3b869cbb0b9ced42d7ca4e24626a868a14ddcfc Mon Sep 17 00:00:00 2001
|
|
From: Frank Tang <ftang@chromium.org>
|
|
Date: Mon, 18 Sep 2023 20:20:42 -0700
|
|
Subject: [PATCH] ICU-22512 Fix broken TestHebrewCalendarInTemporalLeapYear
|
|
|
|
Fix broken test mistakenly landed in
|
|
https://github.com/unicode-org/icu/pull/2274
|
|
|
|
Some important steps were missed in the last landing.
|
|
---
|
|
icu4c/source/test/intltest/caltest.cpp | 2 ++
|
|
1 file changed, 2 insertions(+)
|
|
|
|
diff --git a/icu4c/source/test/intltest/caltest.cpp b/icu4c/source/test/intltest/caltest.cpp
|
|
index 9d89f468eef0..18b96f231ba3 100644
|
|
--- a/source/test/intltest/caltest.cpp
|
|
+++ b/source/test/intltest/caltest.cpp
|
|
@@ -4028,6 +4028,7 @@ void CalendarTest::TestHebrewCalendarInTemporalLeapYear() {
|
|
for (gc.set(startYear, UCAL_JANUARY, 1);
|
|
gc.get(UCAL_YEAR, status) <= stopYear;
|
|
gc.add(UCAL_DATE, incrementDays, status)) {
|
|
+ cal->setTime(gc.getTime(status), status);
|
|
if (failure(status, "add/get/set/getTime/setTime incorrect")) return;
|
|
|
|
int32_t cal_year = cal->get(UCAL_EXTENDED_YEAR, status);
|
|
@@ -4036,6 +4037,7 @@ void CalendarTest::TestHebrewCalendarInTemporalLeapYear() {
|
|
leapTest->set(UCAL_MONTH, 0);
|
|
leapTest->set(UCAL_DATE, 1);
|
|
// If 10 months after TISHRI is TAMUZ, then it is a leap year.
|
|
+ leapTest->add(UCAL_MONTH, 10, status);
|
|
hasLeapMonth = leapTest->get(UCAL_MONTH, status) == icu::HebrewCalendar::TAMUZ;
|
|
yearForHasLeapMonth = cal_year;
|
|
}
|