spec file cleanup from rhbz#1307633

Remaining bits from
https://bugzilla.redhat.com/attachment.cgi?id=1131224

icu.spec

@@ -4,11 +4,12 @@ Name:      icu
 Version:   56.1
 Release:   5%{?dist}
 Summary:   International Components for Unicode
-Group:     Development/Tools
+
 License:   MIT and UCD and Public Domain
 URL:       http://www.icu-project.org/
 Source0:   http://download.icu-project.org/files/icu4c/56.1/icu4c-56_1-src.tgz
 Source1:   icu-config.sh
+
 BuildRequires: doxygen, autoconf, python
 Requires: lib%{name}%{?_isa} = %{version}-%{release}
 
@@ -25,7 +26,6 @@ Tools and utilities for developing with icu.
 
 %package -n lib%{name}
 Summary: International Components for Unicode - libraries
-Group:   System Environment/Libraries
 
 %description -n lib%{name}
 The International Components for Unicode (ICU) libraries provide
@@ -41,7 +41,6 @@ customize the supplied services.
 
 %package  -n lib%{name}-devel
 Summary:  Development files for International Components for Unicode
-Group:    Development/Libraries
 Requires: lib%{name}%{?_isa} = %{version}-%{release}
 Requires: pkgconfig
 
@@ -50,7 +49,6 @@ Includes and definitions for developing with icu.
 
 %package -n lib%{name}-doc
 Summary: Documentation for International Components for Unicode
-Group:   Documentation
 BuildArch: noarch
 
 %description -n lib%{name}-doc
@@ -59,6 +57,7 @@ BuildArch: noarch
 %{!?endian: %global endian %(%{__python} -c "import sys;print (0 if sys.byteorder=='big' else 1)")}
 # " this line just fixes syntax highlighting for vim that is confused by the above and continues literal
 
+
 %prep
 %setup -q -n %{name}
 %patch1 -p2 -R -b .icu8198.revert.icu5431.patch
@@ -114,6 +113,7 @@ sed -i -r 's|(PKGDATA_OPTS = )|\1-v |' data/Makefile
 make %{?_smp_mflags} VERBOSE=1
 make %{?_smp_mflags} doc
 
+
 %install
 rm -rf $RPM_BUILD_ROOT source/__docs
 make %{?_smp_mflags} -C source install DESTDIR=$RPM_BUILD_ROOT
@@ -125,6 +125,7 @@ chmod +x $RPM_BUILD_ROOT%{_libdir}/*.so.*
 )
 install -p -m755 -D %{SOURCE1} $RPM_BUILD_ROOT%{_bindir}/icu-config
 
+
 %check
 # test to ensure that -j(X>1) didn't "break" man pages. b.f.u #2357
 if grep -q @VERSION@ source/tools/*/*.8 source/tools/*/*.1 source/config/*.1; then
@@ -141,8 +142,10 @@ LD_LIBRARY_PATH=lib:stubdata:tools/ctestfw:$LD_LIBRARY_PATH bin/uconv -l
 
 %postun -n lib%{name} -p /sbin/ldconfig
 
+
 %files
-%defattr(-,root,root,-)
+%license license.html
+%exclude %{_datadir}/%{name}/*/license.html
 %{_bindir}/derb
 %{_bindir}/genbrk
 %{_bindir}/gencfu
@@ -165,12 +168,13 @@ LD_LIBRARY_PATH=lib:stubdata:tools/ctestfw:$LD_LIBRARY_PATH bin/uconv -l
 %{_mandir}/man8/*.8*
 
 %files -n lib%{name}
-%defattr(-,root,root,-)
-%doc license.html readme.html
+%license license.html
+%doc readme.html
 %{_libdir}/*.so.*
 
 %files -n lib%{name}-devel
-%defattr(-,root,root,-)
+%license license.html
+%doc source/samples/
 %{_bindir}/%{name}-config*
 %{_bindir}/icuinfo
 %{_mandir}/man1/%{name}-config.1*
@@ -185,23 +189,26 @@ LD_LIBRARY_PATH=lib:stubdata:tools/ctestfw:$LD_LIBRARY_PATH bin/uconv -l
 %{_datadir}/%{name}/%{version}/install-sh
 %{_datadir}/%{name}/%{version}/mkinstalldirs
 %{_datadir}/%{name}/%{version}/config
-%doc %{_datadir}/%{name}/%{version}/license.html
 
 %files -n lib%{name}-doc
-%defattr(-,root,root,-)
-%doc license.html readme.html
+%license license.html
+%doc readme.html
 %doc source/__docs/%{name}/html/*
 
+
 %changelog
 * Sun Feb 28 2016 Raphael Groner <projects.rg@smart.ms> - 56.1-5
 - even more verbosity and debug output
 - add path to extend ICU's internal cache of codes
+- use license macro
+- provide samples in devel subpackage
+- modernize generally
 
 * Sat Feb 27 2016 Rex Dieter <rdieter@fedoraproject.org> - 56.1-4
 - %%build: make VERBOSE=1
 - %%check: keep 'make check' non-fatal while investigating rhbz#1307633
 
-* Tue Feb 06 2016 Caolán McNamara <caolanm@redhat.com> - 56.1-3
+* Sat Feb 06 2016 Caolán McNamara <caolanm@redhat.com> - 56.1-3
 - Resolves: rhbz#1307633 FTBFS, disable check to get build through for now
 
 * Thu Feb 04 2016 Fedora Release Engineering <releng@fedoraproject.org> - 56.1-2