53 lines
2.0 KiB
Diff
53 lines
2.0 KiB
Diff
|
From 21261cb75d523dd3ac815524e66f53694c1a3c2a Mon Sep 17 00:00:00 2001
|
||
|
|
From: Ani Sinha <anisinha@redhat.com>
|
||
|
|
Date: Wed, 5 Jul 2023 18:44:34 +0530
|
||
|
|
Subject: [PATCH] vmbus_testing: fix wrong python syntax for integer value
|
||
|
|
comparison
|
||
|
|
|
||
|
|
RH-Author: Ani Sinha <None>
|
||
|
|
RH-MergeRequest: 6: vmbus_testing: fix wrong python syntax for interger value comparison
|
||
|
|
RH-Bugzilla: 2218931
|
||
|
|
RH-Acked-by: Miroslav Rezanina <mrezanin@redhat.com>
|
||
|
|
RH-Commit: [1/1] 2887e0ad51a16a499ebdeac29f3086c8be481e0c (anisinha/centos-hyperv-daemons)
|
||
|
|
|
||
|
|
It is incorrect in python to compare integer values using the "is" keyword. The
|
||
|
|
"is" keyword in python is used to compare references to two objects, not their
|
||
|
|
values. Newer version of python3 (version 3.8) throws a warning when such
|
||
|
|
incorrect comparison is made. For value comparison, "==" should be used.
|
||
|
|
|
||
|
|
Fix this in the code and suppress the following warning:
|
||
|
|
|
||
|
|
/usr/sbin/vmbus_testing:167: SyntaxWarning: "is" with a literal. Did you mean "=="?
|
||
|
|
|
||
|
|
RHBZ: 2218931
|
||
|
|
Signed-off-by: Ani Sinha <anisinha@redhat.com>
|
||
|
|
---
|
||
|
|
vmbus_testing | 4 ++--
|
||
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/vmbus_testing b/vmbus_testing
|
||
|
|
index e721290..4467979 100755
|
||
|
|
--- a/vmbus_testing
|
||
|
|
+++ b/vmbus_testing
|
||
|
|
@@ -164,7 +164,7 @@ def recursive_file_lookup(path, file_map):
|
||
|
|
def get_all_devices_test_status(file_map):
|
||
|
|
|
||
|
|
for device in file_map:
|
||
|
|
- if (get_test_state(locate_state(device, file_map)) is 1):
|
||
|
|
+ if (get_test_state(locate_state(device, file_map)) == 1):
|
||
|
|
print("Testing = ON for: {}"
|
||
|
|
.format(device.split("/")[5]))
|
||
|
|
else:
|
||
|
|
@@ -203,7 +203,7 @@ def write_test_files(path, value):
|
||
|
|
def set_test_state(state_path, state_value, quiet):
|
||
|
|
|
||
|
|
write_test_files(state_path, state_value)
|
||
|
|
- if (get_test_state(state_path) is 1):
|
||
|
|
+ if (get_test_state(state_path) == 1):
|
||
|
|
if (not quiet):
|
||
|
|
print("Testing = ON for device: {}"
|
||
|
|
.format(state_path.split("/")[5]))
|
||
|
|
--
|
||
|
|
2.39.3
|
||
|
|
|