From 17b0b4e0425e17a985b2e83221a1c8a1e8817f66 Mon Sep 17 00:00:00 2001
From: Michal Srb <msrb@redhat.com>
Date: Wed, 17 Apr 2024 15:40:56 +0000
Subject: [PATCH] Fix rpminspect.yaml syntax

Any entries in the upstream inspection block that contain wildcards for glob(7) specification need to be wrapped in single quotes.

We are also changing the badfuncs block to allow the specific function in mod_proxy.so rather than ignoring the entire file.

Thanks to David Cantrell who discovered this problem (in OSCI-6724) and proposed the fix.
---
 rpminspect.yaml | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/rpminspect.yaml b/rpminspect.yaml
index 17e48d1..7696d42 100644
--- a/rpminspect.yaml
+++ b/rpminspect.yaml
@@ -2,20 +2,21 @@
 badfuncs:
   # mod_proxy uses inet_ntoa (safely) for IPv4 address matching,
   # and APR interfaces for IPv6 addresses.
-  ignore:
-    - /usr/lib*/httpd/modules/mod_proxy.so
+  allowed:
+    /usr/lib*/httpd/modules/mod_proxy.so:
+      - inet_ntoa
 upstream:
   ignore:
-    - *.xml
-    - *.service
-    - *.socket
-    - *.conf
-    - *.sysconf
-    - *.tmpfiles
-    - README.*
-    - *.sysusers
-    - *.png
-    - httpd-ssl-*
+    - '*.xml'
+    - '*.service'
+    - '*.socket'
+    - '*.conf'
+    - '*.sysconf'
+    - '*.tmpfiles'
+    - 'README.*'
+    - '*.sysusers'
+    - '*.png'
+    - 'httpd-ssl-*'
     - config.layout
-    - action*.sh
-    - apachectl.*
+    - 'action*.sh'
+    - 'apachectl.*'