From 7d0656f9225cf48262498d495480e54b8fc3ebac Mon Sep 17 00:00:00 2001
From: Tim Waugh <twaugh@redhat.com>
Date: Wed, 15 Sep 2010 12:14:29 +0100
Subject: [PATCH] Fixes from package review.

---
 hplip.spec | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/hplip.spec b/hplip.spec
index f821397..5c0ca5f 100644
--- a/hplip.spec
+++ b/hplip.spec
@@ -46,6 +46,7 @@ Requires: hpijs = %{hpijs_epoch}:%{version}-%{release}
 Requires: %{name}-libs = %{version}-%{release}
 Requires: python-imaging
 Requires: hal
+Requires: cups
 
 BuildRequires: net-snmp-devel
 BuildRequires: cups-devel
@@ -68,6 +69,7 @@ drivers for HP printers and multi-function peripherals.
 Summary: Files needed by the HPLIP printer and scanner drivers
 Group: System Environment/Libraries
 License: GPLv2+
+Requires: udev
 
 %description common
 Files needed by the HPLIP printer and scanner drivers.
@@ -77,6 +79,7 @@ Summary: HPLIP libraries
 Group: System Environment/Libraries
 License: GPLv2+ and MIT
 Requires: %{name}-common = %{version}-%{release}
+Requires: python
 
 %description libs
 Libraries needed by HPLIP.
@@ -103,6 +106,7 @@ Epoch: %{hpijs_epoch}
 Requires: %{name}-libs = %{version}-%{release}
 Requires: net-snmp
 Requires: cupsddk-drivers
+Requires: cups
 
 %description -n hpijs
 hpijs is a collection of optimized drivers for HP printers.
@@ -296,7 +300,7 @@ rm -rf %{buildroot}
 %{_bindir}/hp-timedate
 %{_bindir}/hp-unload
 %{_bindir}/hp-wificonfig
-# Note: this must be /usr/lib not %{_libdir}, since that's the
+# Note: this must be /usr/lib not %%{_libdir}, since that's the
 # CUPS serverbin directory.
 /usr/lib/cups/backend/hp
 /usr/lib/cups/backend/hpfax
@@ -411,7 +415,19 @@ fi
 %post -n hpijs
 %{_bindir}/hpcups-update-ppds &>/dev/null ||:
 
+%post libs -p /sbin/ldconfig
+
+%postun libs -p /sbin/ldconfig
+
 %changelog
+* Wed Sep 15 2010 Tim Waugh <twaugh@redhat.com>
+- Fixes from package review:
+  - Main package and hpijs sub-package require cups for directories.
+  - The common sub-package requires udev for directories.
+  - The libs sub-package requires python for directories.
+  - Avoided macro in comment.
+  - The lib sub-package now runs ldconfig for post/postun.
+
 * Fri Aug 20 2010 Tim Waugh <twaugh@redhat.com> - 3.10.6-3
 - Added another SNMP quirk for an OfficeJet Pro 8500 variant.