From f45b677201abb6b8471fa5bc935afda420c28c39 Mon Sep 17 00:00:00 2001 From: Alexander Larsson Date: Thu, 19 Nov 2009 10:53:10 +0000 Subject: Don't store write() return val in unsigned variable The conversion to unsigned means we failed to recognize errors, since if (ret < 0) was never hit. This is the suspected cause for data loss in bug 598561. --- diff --git a/metadata/metabuilder.c b/metadata/metabuilder.c index bffdd16..cca2443 100644 --- a/metadata/metabuilder.c +++ b/metadata/metabuilder.c @@ -799,7 +799,7 @@ write_metadata (GString *out, static gboolean write_all_data_and_close (int fd, char *data, gsize len) { - gsize written; + gssize written; gboolean res; res = FALSE; -- cgit v0.8.2