use %make_build %make_install %_metainfodir

%build: --disable-qt (for now)

gstreamer1-plugins-good.spec

@@ -13,7 +13,7 @@
 
 Name:           gstreamer1-plugins-good
 Version:        1.14.1
-Release:        1%{?gitcommit:.git%{shortcommit}}%{?dist}
+Release:        2%{?gitcommit:.git%{shortcommit}}%{?dist}
 Summary:        GStreamer plugins with good code and licensing
 
 License:        LGPLv2+
@@ -27,6 +27,12 @@ Source0:        gst-plugins-good-%{version}.tar.xz
 Source0:        http://gstreamer.freedesktop.org/src/gst-plugins-good/gst-plugins-good-%{version}.tar.xz
 %endif
 
+# Register as an AppStream component to be visible in the software center
+# NOTE: It would be *awesome* if this file was maintained by the upstream
+# project, translated and installed into the right place during `make install`.
+# See http://www.freedesktop.org/software/appstream/docs/ for more details.
+Source1:        gstreamer-good.appdata.xml
+
 BuildRequires:  gstreamer1-devel >= %{version}
 BuildRequires:  gstreamer1-plugins-base-devel >= %{version}
 
@@ -144,73 +150,30 @@ to be installed.
 %else
   --disable-jack \
 %endif
+  --disable-qt \
   --with-default-visualizer=autoaudiosink
-make %{?_smp_mflags} V=1
+
+%make_build V=1
 
 
 %install
-make install DESTDIR=$RPM_BUILD_ROOT
+%make_install
 
-# Register as an AppStream component to be visible in the software center
-#
-# NOTE: It would be *awesome* if this file was maintained by the upstream
-# project, translated and installed into the right place during `make install`.
-#
-# See http://www.freedesktop.org/software/appstream/docs/ for more details.
-#
-mkdir -p $RPM_BUILD_ROOT%{_datadir}/appdata
-cat > $RPM_BUILD_ROOT%{_datadir}/appdata/gstreamer-good.appdata.xml <<EOF
-<?xml version="1.0" encoding="UTF-8"?>
-<!-- Copyright 2013 Richard Hughes <richard@hughsie.com> -->
-<component type="codec">
-  <id>gstreamer-good</id>
-  <metadata_license>CC0-1.0</metadata_license>
-  <name>GStreamer Multimedia Codecs</name>
-  <summary>Multimedia playback for APE, AVI, DV, FLAC, FLX, Flash, MKV, MP4, Speex, VP8, VP9 and WAV</summary>
-  <description>
-    <p>
-      This addon includes several good quality codecs that are well tested.
-      These codecs can be used to encode and decode media files where the
-      format is not patent encumbered.
-    </p>
-    <p>
-      A codec decodes audio and video for for playback or editing and is also
-      used for transmission or storage.
-      Different codecs are used in video-conferencing, streaming media and
-      video editing applications.
-    </p>
-  </description>
-  <keywords>
-    <keyword>APE</keyword>
-    <keyword>AVI</keyword>
-    <keyword>DV</keyword>
-    <keyword>FLAC</keyword>
-    <keyword>FLX</keyword>
-    <keyword>Flash</keyword>
-    <keyword>MKV</keyword>
-    <keyword>MP4</keyword>
-    <keyword>Speex</keyword>
-    <keyword>VP8</keyword>
-    <keyword>VP9</keyword>
-    <keyword>WAV</keyword>
-  </keywords>
-  <url type="homepage">http://gstreamer.freedesktop.org/</url>
-  <url type="bugtracker">https://bugzilla.gnome.org/enter_bug.cgi?product=GStreamer</url>
-  <url type="donation">http://www.gnome.org/friends/</url>
-  <url type="help">http://gstreamer.freedesktop.org/documentation/</url>
-  <update_contact><!-- upstream-contact_at_email.com --></update_contact>
-</component>
-EOF
+install -p -D %{SOURCE1} %{buildroot}%{_metainfodir}/gstreamer-good.appdata.xml
+
+find $RPM_BUILD_ROOT -name '*.la' -exec rm -fv {} ';'
 
 %find_lang gst-plugins-good-%{majorminor}
 
-find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
+
+%check
+gst-inspect-1.0 --print-plugin-auto-install-info --rpm %{buildroot}%{_libdir}/gstreamer-%{majorminor}/libgstgtk.so
 
 
 %files -f gst-plugins-good-%{majorminor}.lang
 %license COPYING
 %doc AUTHORS README REQUIREMENTS
-%{_datadir}/appdata/*.appdata.xml
+%{_metainfodir}/gstreamer-good.appdata.xml
 %doc %{_datadir}/gtk-doc/html/gst-plugins-good-plugins-%{majorminor}
 
 # presets
@@ -304,6 +267,10 @@ find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'
 
 
 %changelog
+* Tue May 22 2018 Rex Dieter <rdieter@fedoraproject.org> - 1.14.1-2
+- use %%make_build %%make_install %%_metainfodir
+- %%build: --disable-qt (for now)
+
 * Mon May 21 2018 Wim Taymans <wtaymans@redhat.com> - 1.14.1-1
 - Update to 1.14.1