34 lines
1.2 KiB
Diff
34 lines
1.2 KiB
Diff
|
From ae4fb8fa16cbef636e90afe1d321e06bae2ff6df Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
|
||
|
|
Date: Fri, 4 Oct 2024 13:22:02 +0300
|
||
|
|
Subject: [PATCH 08/28] wavparse: Check that at least 32 bytes are available
|
||
|
|
before parsing smpl chunks
|
||
|
|
|
||
|
|
Thanks to Antonio Morales for finding and reporting the issue.
|
||
|
|
|
||
|
|
Fixes GHSL-2024-259
|
||
|
|
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3887
|
||
|
|
|
||
|
|
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8042>
|
||
|
|
---
|
||
|
|
subprojects/gst-plugins-good/gst/wavparse/gstwavparse.c | 3 +++
|
||
|
|
1 file changed, 3 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/subprojects/gst-plugins-good/gst/wavparse/gstwavparse.c b/subprojects/gst-plugins-good/gst/wavparse/gstwavparse.c
|
||
|
|
index c36920501e..e42bb24b9b 100644
|
||
|
|
--- a/subprojects/gst-plugins-good/gst/wavparse/gstwavparse.c
|
||
|
|
+++ b/subprojects/gst-plugins-good/gst/wavparse/gstwavparse.c
|
||
|
|
@@ -893,6 +893,9 @@ gst_wavparse_smpl_chunk (GstWavParse * wav, const guint8 * data, guint32 size)
|
||
|
|
{
|
||
|
|
guint32 note_number;
|
||
|
|
|
||
|
|
+ if (size < 32)
|
||
|
|
+ return FALSE;
|
||
|
|
+
|
||
|
|
/*
|
||
|
|
manufacturer_id = GST_READ_UINT32_LE (data);
|
||
|
|
product_id = GST_READ_UINT32_LE (data + 4);
|
||
|
|
--
|
||
|
|
2.47.0
|
||
|
|
|