From 6c650a7655dbc4b3237b17440eb52fb0f5a193cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Mon, 30 Sep 2024 21:40:44 +0300 Subject: [PATCH 08/10] ssaparse: Search for closing brace after opening brace Otherwise removing anything between the braces leads to out of bound writes if there is a closing brace before the first opening brace. Thanks to Antonio Morales for finding and reporting the issue. Fixes GHSL-2024-228 Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3870 Part-of: --- subprojects/gst-plugins-base/gst/subparse/gstssaparse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/gst-plugins-base/gst/subparse/gstssaparse.c b/subprojects/gst-plugins-base/gst/subparse/gstssaparse.c index d6fdb9c9fc..8ed0134102 100644 --- a/subprojects/gst-plugins-base/gst/subparse/gstssaparse.c +++ b/subprojects/gst-plugins-base/gst/subparse/gstssaparse.c @@ -238,7 +238,7 @@ gst_ssa_parse_remove_override_codes (GstSsaParse * parse, gchar * txt) gboolean removed_any = FALSE; while ((t = strchr (txt, '{'))) { - end = strchr (txt, '}'); + end = strchr (t, '}'); if (end == NULL) { GST_WARNING_OBJECT (parse, "Missing { for style override code"); return removed_any; -- 2.47.0