gssproxy/Appease-Coverity.patch
Robbie Harwood 07be2820f2 Actually apply the patches I just added
Also include a Coverity fix.
2017-03-06 16:07:15 +00:00

30 lines
980 B
Diff

From 03b76c1ca376d01622df7e599c9882b693054675 Mon Sep 17 00:00:00 2001
From: Robbie Harwood <rharwood@redhat.com>
Date: Mon, 27 Feb 2017 11:52:17 -0500
Subject: [PATCH] Appease Coverity
There is only one call site of gpp_store_remote_creds(), and it already checks
that `creds != NULL`, so we don't need to duplicate the check.
Signed-off-by: Robbie Harwood <rharwood@redhat.com>
Reviewed-by: Simo Sorce <simo@redhat.com>
PR: #52
(cherry picked from commit 348d5df4864639ebe50bfeaabd8c423233da24d6)
---
proxy/src/mechglue/gpp_creds.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/proxy/src/mechglue/gpp_creds.c b/proxy/src/mechglue/gpp_creds.c
index 37517d6..8fcef36 100644
--- a/proxy/src/mechglue/gpp_creds.c
+++ b/proxy/src/mechglue/gpp_creds.c
@@ -20,8 +20,6 @@ uint32_t gpp_store_remote_creds(uint32_t *min,
*min = 0;
- if (creds == NULL) return GSS_S_CALL_INACCESSIBLE_READ;
-
memset(&cred, 0, sizeof(cred));
ret = krb5_init_context(&ctx);