138 lines
5.0 KiB
Diff
138 lines
5.0 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Javier Martinez Canillas <javierm@redhat.com>
|
|
Date: Mon, 28 Sep 2020 20:08:33 +0200
|
|
Subject: [PATCH] efi: Use grub_is_lockdown() instead of hardcoding a disabled
|
|
modules list
|
|
|
|
Now the GRUB can check if it has been locked down and this can be used to
|
|
prevent executing commands that can be utilized to circumvent the UEFI
|
|
Secure Boot mechanisms. So, instead of hardcoding a list of modules that
|
|
have to be disabled, prevent the usage of commands that can be dangerous.
|
|
|
|
This not only allows the commands to be disabled on other platforms, but
|
|
also properly separate the concerns. Since the shim_lock verifier logic
|
|
should be only about preventing to run untrusted binaries and not about
|
|
defining these kind of policies.
|
|
|
|
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
|
|
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
|
---
|
|
grub-core/commands/iorw.c | 26 ++++++++++----------------
|
|
grub-core/commands/memrw.c | 26 ++++++++++----------------
|
|
2 files changed, 20 insertions(+), 32 deletions(-)
|
|
|
|
diff --git a/grub-core/commands/iorw.c b/grub-core/commands/iorw.c
|
|
index 41a7f3f04..584baec8f 100644
|
|
--- a/grub-core/commands/iorw.c
|
|
+++ b/grub-core/commands/iorw.c
|
|
@@ -23,7 +23,7 @@
|
|
#include <grub/env.h>
|
|
#include <grub/cpu/io.h>
|
|
#include <grub/i18n.h>
|
|
-#include <grub/efi/sb.h>
|
|
+#include <grub/lockdown.h>
|
|
|
|
GRUB_MOD_LICENSE ("GPLv3+");
|
|
|
|
@@ -119,9 +119,6 @@ grub_cmd_write (grub_command_t cmd, int argc, char **argv)
|
|
|
|
GRUB_MOD_INIT(memrw)
|
|
{
|
|
- if (grub_efi_secure_boot())
|
|
- return;
|
|
-
|
|
cmd_read_byte =
|
|
grub_register_extcmd ("inb", grub_cmd_read, 0,
|
|
N_("PORT"), N_("Read 8-bit value from PORT."),
|
|
@@ -135,24 +132,21 @@ GRUB_MOD_INIT(memrw)
|
|
N_("PORT"), N_("Read 32-bit value from PORT."),
|
|
options);
|
|
cmd_write_byte =
|
|
- grub_register_command ("outb", grub_cmd_write,
|
|
- N_("PORT VALUE [MASK]"),
|
|
- N_("Write 8-bit VALUE to PORT."));
|
|
+ grub_register_command_lockdown ("outb", grub_cmd_write,
|
|
+ N_("PORT VALUE [MASK]"),
|
|
+ N_("Write 8-bit VALUE to PORT."));
|
|
cmd_write_word =
|
|
- grub_register_command ("outw", grub_cmd_write,
|
|
- N_("PORT VALUE [MASK]"),
|
|
- N_("Write 16-bit VALUE to PORT."));
|
|
+ grub_register_command_lockdown ("outw", grub_cmd_write,
|
|
+ N_("PORT VALUE [MASK]"),
|
|
+ N_("Write 16-bit VALUE to PORT."));
|
|
cmd_write_dword =
|
|
- grub_register_command ("outl", grub_cmd_write,
|
|
- N_("ADDR VALUE [MASK]"),
|
|
- N_("Write 32-bit VALUE to PORT."));
|
|
+ grub_register_command_lockdown ("outl", grub_cmd_write,
|
|
+ N_("ADDR VALUE [MASK]"),
|
|
+ N_("Write 32-bit VALUE to PORT."));
|
|
}
|
|
|
|
GRUB_MOD_FINI(memrw)
|
|
{
|
|
- if (grub_efi_secure_boot())
|
|
- return;
|
|
-
|
|
grub_unregister_extcmd (cmd_read_byte);
|
|
grub_unregister_extcmd (cmd_read_word);
|
|
grub_unregister_extcmd (cmd_read_dword);
|
|
diff --git a/grub-core/commands/memrw.c b/grub-core/commands/memrw.c
|
|
index 088cbe9e2..d401a6db0 100644
|
|
--- a/grub-core/commands/memrw.c
|
|
+++ b/grub-core/commands/memrw.c
|
|
@@ -22,7 +22,7 @@
|
|
#include <grub/extcmd.h>
|
|
#include <grub/env.h>
|
|
#include <grub/i18n.h>
|
|
-#include <grub/efi/sb.h>
|
|
+#include <grub/lockdown.h>
|
|
|
|
GRUB_MOD_LICENSE ("GPLv3+");
|
|
|
|
@@ -121,9 +121,6 @@ grub_cmd_write (grub_command_t cmd, int argc, char **argv)
|
|
|
|
GRUB_MOD_INIT(memrw)
|
|
{
|
|
- if (grub_efi_secure_boot())
|
|
- return;
|
|
-
|
|
cmd_read_byte =
|
|
grub_register_extcmd ("read_byte", grub_cmd_read, 0,
|
|
N_("ADDR"), N_("Read 8-bit value from ADDR."),
|
|
@@ -137,24 +134,21 @@ GRUB_MOD_INIT(memrw)
|
|
N_("ADDR"), N_("Read 32-bit value from ADDR."),
|
|
options);
|
|
cmd_write_byte =
|
|
- grub_register_command ("write_byte", grub_cmd_write,
|
|
- N_("ADDR VALUE [MASK]"),
|
|
- N_("Write 8-bit VALUE to ADDR."));
|
|
+ grub_register_command_lockdown ("write_byte", grub_cmd_write,
|
|
+ N_("ADDR VALUE [MASK]"),
|
|
+ N_("Write 8-bit VALUE to ADDR."));
|
|
cmd_write_word =
|
|
- grub_register_command ("write_word", grub_cmd_write,
|
|
- N_("ADDR VALUE [MASK]"),
|
|
- N_("Write 16-bit VALUE to ADDR."));
|
|
+ grub_register_command_lockdown ("write_word", grub_cmd_write,
|
|
+ N_("ADDR VALUE [MASK]"),
|
|
+ N_("Write 16-bit VALUE to ADDR."));
|
|
cmd_write_dword =
|
|
- grub_register_command ("write_dword", grub_cmd_write,
|
|
- N_("ADDR VALUE [MASK]"),
|
|
- N_("Write 32-bit VALUE to ADDR."));
|
|
+ grub_register_command_lockdown ("write_dword", grub_cmd_write,
|
|
+ N_("ADDR VALUE [MASK]"),
|
|
+ N_("Write 32-bit VALUE to ADDR."));
|
|
}
|
|
|
|
GRUB_MOD_FINI(memrw)
|
|
{
|
|
- if (grub_efi_secure_boot())
|
|
- return;
|
|
-
|
|
grub_unregister_extcmd (cmd_read_byte);
|
|
grub_unregister_extcmd (cmd_read_word);
|
|
grub_unregister_extcmd (cmd_read_dword);
|