36 lines
1.5 KiB
Diff
36 lines
1.5 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Lidong Chen <lidong.chen@oracle.com>
|
|
Date: Fri, 22 Nov 2024 06:27:56 +0000
|
|
Subject: [PATCH] gettext: Integer overflow leads to heap OOB write or read
|
|
|
|
Calculation of ctx->grub_gettext_msg_list size in grub_mofile_open() may
|
|
overflow leading to subsequent OOB write or read. This patch fixes the
|
|
issue by replacing grub_zalloc() and explicit multiplication with
|
|
grub_calloc() which does the same thing in safe manner.
|
|
|
|
Fixes: CVE-2024-45776
|
|
|
|
Reported-by: Nils Langius <nils@langius.de>
|
|
Signed-off-by: Lidong Chen <lidong.chen@oracle.com>
|
|
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
|
Reviewed-by: Alec Brown <alec.r.brown@oracle.com>
|
|
---
|
|
grub-core/gettext/gettext.c | 4 ++--
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/grub-core/gettext/gettext.c b/grub-core/gettext/gettext.c
|
|
index 1344c7c81..cb304ebeb 100644
|
|
--- a/grub-core/gettext/gettext.c
|
|
+++ b/grub-core/gettext/gettext.c
|
|
@@ -323,8 +323,8 @@ grub_mofile_open (struct grub_gettext_context *ctx,
|
|
for (ctx->grub_gettext_max_log = 0; ctx->grub_gettext_max >> ctx->grub_gettext_max_log;
|
|
ctx->grub_gettext_max_log++);
|
|
|
|
- ctx->grub_gettext_msg_list = grub_zalloc (ctx->grub_gettext_max
|
|
- * sizeof (ctx->grub_gettext_msg_list[0]));
|
|
+ ctx->grub_gettext_msg_list = grub_calloc (ctx->grub_gettext_max,
|
|
+ sizeof (ctx->grub_gettext_msg_list[0]));
|
|
if (!ctx->grub_gettext_msg_list)
|
|
{
|
|
grub_file_close (fd);
|