44 lines
1.2 KiB
Diff
44 lines
1.2 KiB
Diff
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Daniel Axtens <dja@axtens.net>
|
||
|
|
Date: Wed, 13 Jan 2021 22:19:01 +1100
|
||
|
|
Subject: [PATCH] kern/misc: Always set *end in grub_strtoull()
|
||
|
|
|
||
|
|
Currently, if there is an error in grub_strtoull(), *end is not set.
|
||
|
|
This differs from the usual behavior of strtoull(), and also means that
|
||
|
|
some callers may use an uninitialized value for *end.
|
||
|
|
|
||
|
|
Set *end unconditionally.
|
||
|
|
|
||
|
|
Signed-off-by: Daniel Axtens <dja@axtens.net>
|
||
|
|
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
||
|
|
---
|
||
|
|
grub-core/kern/misc.c | 8 ++++++++
|
||
|
|
1 file changed, 8 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/grub-core/kern/misc.c b/grub-core/kern/misc.c
|
||
|
|
index 97378c48b..475f3e0ef 100644
|
||
|
|
--- a/grub-core/kern/misc.c
|
||
|
|
+++ b/grub-core/kern/misc.c
|
||
|
|
@@ -485,6 +485,10 @@ grub_strtoull (const char *str, const char ** const end, int base)
|
||
|
|
{
|
||
|
|
grub_error (GRUB_ERR_OUT_OF_RANGE,
|
||
|
|
N_("overflow is detected"));
|
||
|
|
+
|
||
|
|
+ if (end)
|
||
|
|
+ *end = (char *) str;
|
||
|
|
+
|
||
|
|
return ~0ULL;
|
||
|
|
}
|
||
|
|
|
||
|
|
@@ -496,6 +500,10 @@ grub_strtoull (const char *str, const char ** const end, int base)
|
||
|
|
{
|
||
|
|
grub_error (GRUB_ERR_BAD_NUMBER,
|
||
|
|
N_("unrecognized number"));
|
||
|
|
+
|
||
|
|
+ if (end)
|
||
|
|
+ *end = (char *) str;
|
||
|
|
+
|
||
|
|
return 0;
|
||
|
|
}
|
||
|
|
|