From: Jeremy Bicha Date: Wed, 15 Mar 2023 16:06:30 -0400 Subject: Revert "tests/scanner: add some tests for #defines" This reverts commit 41feafa85d73b4a9dd8eac9dbe1231130bf2c7ca See https://gitlab.gnome.org/GNOME/gobject-introspection/-/issues/458 --- .../Regress.BAD_EXPR_CONSTANT.page | 14 - .../Regress.GOOD_EXPR_CONSTANT.page | 14 - .../Regress.BAD_EXPR_CONSTANT.page | 14 - .../Regress.GOOD_EXPR_CONSTANT.page | 14 - .../Regress.BAD_EXPR_CONSTANT.page | 14 - .../Regress.GOOD_EXPR_CONSTANT.page | 14 - tests/scanner/Regress-1.0-expected.gir | 492 ++++++++++----------- tests/scanner/regress.h | 2 - 8 files changed, 240 insertions(+), 338 deletions(-) delete mode 100644 tests/scanner/Regress-1.0-C-expected/Regress.BAD_EXPR_CONSTANT.page delete mode 100644 tests/scanner/Regress-1.0-C-expected/Regress.GOOD_EXPR_CONSTANT.page delete mode 100644 tests/scanner/Regress-1.0-Gjs-expected/Regress.BAD_EXPR_CONSTANT.page delete mode 100644 tests/scanner/Regress-1.0-Gjs-expected/Regress.GOOD_EXPR_CONSTANT.page delete mode 100644 tests/scanner/Regress-1.0-Python-expected/Regress.BAD_EXPR_CONSTANT.page delete mode 100644 tests/scanner/Regress-1.0-Python-expected/Regress.GOOD_EXPR_CONSTANT.page diff --git a/tests/scanner/Regress-1.0-C-expected/Regress.BAD_EXPR_CONSTANT.page b/tests/scanner/Regress-1.0-C-expected/Regress.BAD_EXPR_CONSTANT.page deleted file mode 100644 index bc8190a..0000000 --- a/tests/scanner/Regress-1.0-C-expected/Regress.BAD_EXPR_CONSTANT.page +++ /dev/null @@ -1,14 +0,0 @@ - - - - - - Regress.BAD_EXPR_CONSTANT - - - diff --git a/tests/scanner/Regress-1.0-C-expected/Regress.GOOD_EXPR_CONSTANT.page b/tests/scanner/Regress-1.0-C-expected/Regress.GOOD_EXPR_CONSTANT.page deleted file mode 100644 index a204cdc..0000000 --- a/tests/scanner/Regress-1.0-C-expected/Regress.GOOD_EXPR_CONSTANT.page +++ /dev/null @@ -1,14 +0,0 @@ - - - - - - Regress.GOOD_EXPR_CONSTANT - - - diff --git a/tests/scanner/Regress-1.0-Gjs-expected/Regress.BAD_EXPR_CONSTANT.page b/tests/scanner/Regress-1.0-Gjs-expected/Regress.BAD_EXPR_CONSTANT.page deleted file mode 100644 index bc8190a..0000000 --- a/tests/scanner/Regress-1.0-Gjs-expected/Regress.BAD_EXPR_CONSTANT.page +++ /dev/null @@ -1,14 +0,0 @@ - - - - - - Regress.BAD_EXPR_CONSTANT - - - diff --git a/tests/scanner/Regress-1.0-Gjs-expected/Regress.GOOD_EXPR_CONSTANT.page b/tests/scanner/Regress-1.0-Gjs-expected/Regress.GOOD_EXPR_CONSTANT.page deleted file mode 100644 index a204cdc..0000000 --- a/tests/scanner/Regress-1.0-Gjs-expected/Regress.GOOD_EXPR_CONSTANT.page +++ /dev/null @@ -1,14 +0,0 @@ - - - - - - Regress.GOOD_EXPR_CONSTANT - - - diff --git a/tests/scanner/Regress-1.0-Python-expected/Regress.BAD_EXPR_CONSTANT.page b/tests/scanner/Regress-1.0-Python-expected/Regress.BAD_EXPR_CONSTANT.page deleted file mode 100644 index bc8190a..0000000 --- a/tests/scanner/Regress-1.0-Python-expected/Regress.BAD_EXPR_CONSTANT.page +++ /dev/null @@ -1,14 +0,0 @@ - - - - - - Regress.BAD_EXPR_CONSTANT - - - diff --git a/tests/scanner/Regress-1.0-Python-expected/Regress.GOOD_EXPR_CONSTANT.page b/tests/scanner/Regress-1.0-Python-expected/Regress.GOOD_EXPR_CONSTANT.page deleted file mode 100644 index a204cdc..0000000 --- a/tests/scanner/Regress-1.0-Python-expected/Regress.GOOD_EXPR_CONSTANT.page +++ /dev/null @@ -1,14 +0,0 @@ - - - - - - Regress.GOOD_EXPR_CONSTANT - - - diff --git a/tests/scanner/Regress-1.0-expected.gir b/tests/scanner/Regress-1.0-expected.gir index 902513d..424e2e1 100644 --- a/tests/scanner/Regress-1.0-expected.gir +++ b/tests/scanner/Regress-1.0-expected.gir @@ -18,8 +18,8 @@ and/or use gtk-doc annotations. --> Typedef TestBoxed to test caller-allocates correctness - + line="1458">Typedef TestBoxed to test caller-allocates correctness + @@ -33,26 +33,26 @@ and/or use gtk-doc annotations. --> Compatibility typedef, like telepathy-glib's TpIntSet - + line="1428">Compatibility typedef, like telepathy-glib's TpIntSet + Typedef'd GPtrArray for some reason - + line="1436">Typedef'd GPtrArray for some reason + - + Typedef'd va_list for additional reasons - + line="1447">Typedef'd va_list for additional reasons + - + - + - + - + - + @@ -1250,12 +1250,6 @@ it says it's pointer but it's actually a string. - - - - @@ -2616,19 +2610,13 @@ exposed to language bindings. - + - - - - - + - + Like telepathy-glib's TpIntset. - + line="1420">Like telepathy-glib's TpIntset. + - + - + @@ -2681,7 +2669,7 @@ exposed to language bindings. - + @@ -2689,7 +2677,7 @@ exposed to language bindings. - + @@ -2706,13 +2694,13 @@ exposed to language bindings. - + - + introspectable="0"> This should be skipped, and moreover, all function which + line="1402">This should be skipped, and moreover, all function which use it should be. - + @@ -2751,7 +2739,7 @@ use it should be. - + @@ -2760,7 +2748,7 @@ use it should be. - + @@ -2769,7 +2757,7 @@ use it should be. - + @@ -2778,7 +2766,7 @@ use it should be. - + @@ -2787,7 +2775,7 @@ use it should be. - + @@ -2796,7 +2784,7 @@ use it should be. - + @@ -2805,7 +2793,7 @@ use it should be. - + @@ -2814,7 +2802,7 @@ use it should be. - + @@ -2823,7 +2811,7 @@ use it should be. - + @@ -2832,7 +2820,7 @@ use it should be. - + @@ -2841,7 +2829,7 @@ use it should be. - + @@ -2850,7 +2838,7 @@ use it should be. - + @@ -2859,7 +2847,7 @@ use it should be. - + @@ -2868,7 +2856,7 @@ use it should be. - + @@ -2877,7 +2865,7 @@ use it should be. - + @@ -2886,7 +2874,7 @@ use it should be. - + @@ -2895,7 +2883,7 @@ use it should be. - + @@ -2904,7 +2892,7 @@ use it should be. - + @@ -2913,7 +2901,7 @@ use it should be. - + @@ -2922,7 +2910,7 @@ use it should be. - + @@ -2931,7 +2919,7 @@ use it should be. - + @@ -2940,7 +2928,7 @@ use it should be. - + @@ -2949,7 +2937,7 @@ use it should be. - + @@ -2989,7 +2977,7 @@ use it should be. glib:type-name="RegressTestBoxed" glib:get-type="regress_test_boxed_get_type" c:symbol-prefix="test_boxed"> - + @@ -3000,14 +2988,14 @@ use it should be. - + - + @@ -3019,7 +3007,7 @@ use it should be. - + @@ -3034,7 +3022,7 @@ use it should be. - + @@ -3047,7 +3035,7 @@ use it should be. - + @@ -3058,7 +3046,7 @@ use it should be. - + @@ -3069,7 +3057,7 @@ use it should be. - + @@ -3088,7 +3076,7 @@ use it should be. glib:type-name="RegressTestBoxedB" glib:get-type="regress_test_boxed_b_get_type" c:symbol-prefix="test_boxed_b"> - + @@ -3096,7 +3084,7 @@ use it should be. - + @@ -3110,7 +3098,7 @@ use it should be. - + @@ -3126,7 +3114,7 @@ use it should be. glib:type-name="RegressTestBoxedC" glib:get-type="regress_test_boxed_c_get_type" c:symbol-prefix="test_boxed_c"> - + @@ -3134,7 +3122,7 @@ use it should be. - + @@ -3148,9 +3136,9 @@ use it should be. glib:type-name="RegressTestBoxedD" glib:get-type="regress_test_boxed_d_get_type" c:symbol-prefix="test_boxed_d"> - + - + @@ -3164,7 +3152,7 @@ use it should be. - + @@ -3175,7 +3163,7 @@ use it should be. - + @@ -3186,7 +3174,7 @@ use it should be. - + @@ -3201,16 +3189,16 @@ use it should be. c:type="RegressTestBoxedPrivate" disguised="1" opaque="1"> - + - + - + @@ -3235,7 +3223,7 @@ use it should be. - + @@ -3257,7 +3245,7 @@ use it should be. - + @@ -3265,25 +3253,25 @@ use it should be. the investment rate + line="1173">the investment rate how much money + line="1174">how much money Path to file + line="1175">Path to file - + @@ -3295,7 +3283,7 @@ use it should be. - + @@ -3303,7 +3291,7 @@ use it should be. a hash table; will be modified + line="1162">a hash table; will be modified @@ -3313,7 +3301,7 @@ use it should be. - + @@ -3321,20 +3309,20 @@ use it should be. GError instance; must be freed by the callback + line="1168">GError instance; must be freed by the callback - + - + @@ -3473,7 +3461,7 @@ use it should be. - + @@ -3516,9 +3504,9 @@ use it should be. glib:type-name="RegressTestFloating" glib:get-type="regress_test_floating_get_type" glib:type-struct="TestFloatingClass"> - + - + - + @@ -3551,9 +3539,9 @@ use it should be. glib:unref-func="regress_test_fundamental_object_unref" glib:set-value-func="regress_test_value_set_fundamental_object" glib:get-value-func="regress_test_value_get_fundamental_object"> - + - + @@ -3566,7 +3554,7 @@ use it should be. - + @@ -3578,7 +3566,7 @@ use it should be. - + - + @@ -3621,7 +3609,7 @@ use it should be. - + @@ -3636,7 +3624,7 @@ use it should be. - + @@ -3650,7 +3638,7 @@ use it should be. - + @@ -3673,10 +3661,10 @@ use it should be. Just like a #RegressTestFundamentalObject but without gvalue setter and getter - + - + @@ -3689,14 +3677,14 @@ use it should be. - + - + @@ -3718,7 +3706,7 @@ use it should be. - + @@ -3732,10 +3720,10 @@ use it should be. glib:get-type="regress_test_fundamental_sub_object_get_type" glib:type-struct="TestFundamentalSubObjectClass" glib:fundamental="1"> - + - + @@ -3757,7 +3745,7 @@ use it should be. - + @@ -3771,10 +3759,10 @@ use it should be. glib:get-type="regress_test_fundamental_sub_object_no_get_set_func_get_type" glib:type-struct="TestFundamentalSubObjectNoGetSetFuncClass" glib:fundamental="1"> - + - + @@ -3793,7 +3781,7 @@ use it should be. - + @@ -3917,10 +3905,10 @@ use it should be. glib:type-name="RegressTestInterface" glib:get-type="regress_test_interface_get_type" glib:type-struct="TestInterfaceIface"> - + - + @@ -3958,13 +3946,13 @@ use it should be. - + - + @@ -3976,15 +3964,15 @@ use it should be. glib:type-name="RegressTestObj" glib:get-type="regress_test_obj_get_type" glib:type-struct="TestObjClass"> - + - + - + @@ -3999,7 +3987,7 @@ use it should be. - + @@ -4026,7 +4014,7 @@ use it should be. - + @@ -4037,7 +4025,7 @@ use it should be. - + @@ -4057,7 +4045,7 @@ use it should be. - + @@ -4069,7 +4057,7 @@ use it should be. - + @@ -4084,7 +4072,7 @@ use it should be. - + @@ -4098,13 +4086,13 @@ use it should be. allow-none="1"> Another object + line="815">Another object - + @@ -4123,7 +4111,7 @@ use it should be. line="3221">This method is virtual. Notably its name differs from the virtual slot name, which makes it useful for testing bindings handle this case. - + @@ -4148,7 +4136,7 @@ case. line="3221">This method is virtual. Notably its name differs from the virtual slot name, which makes it useful for testing bindings handle this case. - + @@ -4169,7 +4157,7 @@ case. - + @@ -4181,7 +4169,7 @@ case. - + @@ -4196,7 +4184,7 @@ case. - + @@ -4211,7 +4199,7 @@ case. The signal handler must increment the inout parameter by 1. - + @@ -4226,7 +4214,7 @@ case. - + @@ -4238,7 +4226,7 @@ case. - + @@ -4253,7 +4241,7 @@ case. - + @@ -4265,7 +4253,7 @@ case. - + @@ -4276,7 +4264,7 @@ case. - + @@ -4292,7 +4280,7 @@ case. - + @@ -4304,7 +4292,7 @@ case. - + @@ -4316,7 +4304,7 @@ case. - + @@ -4335,7 +4323,7 @@ case. - + @@ -4347,7 +4335,7 @@ case. - + @@ -4362,7 +4350,7 @@ case. - + @@ -4391,7 +4379,7 @@ case. - + @@ -4413,7 +4401,7 @@ case. - + @@ -4432,7 +4420,7 @@ case. - + @@ -4451,7 +4439,7 @@ case. Check that the out value is skipped - + Check that the out value is skipped - + Check that a parameter is skipped - + Check that the return value is skipped - + filename="regress.c" line="3089">Check that the return value is skipped. Succeed if a is nonzero, otherwise raise an error. - + - + @@ -4816,7 +4804,7 @@ raise an error. This function throws an error if m is odd. - + @@ -4996,7 +4984,7 @@ raise an error. - + @@ -5253,13 +5241,13 @@ the introspection client langage. - + - + @@ -5281,7 +5269,7 @@ the introspection client langage. - + @@ -5295,7 +5283,7 @@ the introspection client langage. allow-none="1"> Another object + line="815">Another object @@ -5313,7 +5301,7 @@ the introspection client langage. - + @@ -5321,7 +5309,7 @@ the introspection client langage. - + @@ -5359,7 +5347,7 @@ the introspection client langage. - + @@ -5370,7 +5358,7 @@ the introspection client langage. - + @@ -5382,7 +5370,7 @@ the introspection client langage. - + @@ -5411,8 +5399,8 @@ the introspection client langage. glib:type-name="RegressTestSimpleBoxedA" glib:get-type="regress_test_simple_boxed_a_get_gtype" c:symbol-prefix="test_simple_boxed_a"> - ... - + ... + @@ -5426,7 +5414,7 @@ the introspection client langage. - + @@ -5437,7 +5425,7 @@ the introspection client langage. - + @@ -5452,7 +5440,7 @@ the introspection client langage. - + @@ -5464,7 +5452,7 @@ the introspection client langage. glib:type-name="RegressTestSimpleBoxedB" glib:get-type="regress_test_simple_boxed_b_get_type" c:symbol-prefix="test_simple_boxed_b"> - + @@ -5472,7 +5460,7 @@ the introspection client langage. - + @@ -5484,13 +5472,13 @@ the introspection client langage. - + - + @@ -5507,7 +5495,7 @@ the introspection client langage. Make a copy of a RegressTestStructA - + @@ -5530,7 +5518,7 @@ the introspection client langage. - + @@ -5554,7 +5542,7 @@ the introspection client langage. - + @@ -5565,7 +5553,7 @@ the introspection client langage. Make a copy of a RegressTestStructB - + @@ -5589,7 +5577,7 @@ the introspection client langage. - + @@ -5598,7 +5586,7 @@ the introspection client langage. - + @@ -5624,7 +5612,7 @@ the introspection client langage. - + @@ -5664,7 +5652,7 @@ the introspection client langage. - + @@ -5691,7 +5679,7 @@ the introspection client langage. - + @@ -5701,7 +5689,7 @@ the introspection client langage. - + @@ -5720,17 +5708,17 @@ the introspection client langage. glib:type-name="RegressTestSubObj" glib:get-type="regress_test_sub_obj_get_type" glib:type-struct="TestSubObjClass"> - + - + - + @@ -5741,7 +5729,7 @@ the introspection client langage. - + @@ -5771,7 +5759,7 @@ the introspection client langage. - + @@ -5783,16 +5771,16 @@ the introspection client langage. glib:type-name="RegressTestWi8021x" glib:get-type="regress_test_wi_802_1x_get_type" glib:type-struct="TestWi8021xClass"> - + - + - + @@ -5805,7 +5793,7 @@ the introspection client langage. - + @@ -5818,7 +5806,7 @@ the introspection client langage. - + @@ -5849,7 +5837,7 @@ the introspection client langage. - + @@ -5857,12 +5845,12 @@ the introspection client langage. - + - + @@ -6519,7 +6507,7 @@ exposed to language bindings. - + @@ -6537,7 +6525,7 @@ exposed to language bindings. - + @@ -6554,7 +6542,7 @@ exposed to language bindings. - + filename="regress.c" line="4701">This test case mirrors GnomeKeyringPasswordSchema from libgnome-keyring. - + @@ -6609,7 +6597,7 @@ libgnome-keyring. - + @@ -6622,7 +6610,7 @@ libgnome-keyring. - + @@ -6635,7 +6623,7 @@ libgnome-keyring. - + @@ -6678,7 +6666,7 @@ in particular, but it should be serialized in the gir nevertheless. - + @@ -6690,7 +6678,7 @@ in particular, but it should be serialized in the gir nevertheless. - + @@ -6865,7 +6853,7 @@ in particular, but it should be serialized in the gir nevertheless. - + @@ -7053,7 +7041,7 @@ in particular, but it should be serialized in the gir nevertheless. - + @@ -7077,7 +7065,7 @@ in particular, but it should be serialized in the gir nevertheless. Similar to: - gsf_property_settings_free() with structs but they contain pointers - g_byte_array_new_take() with guint8s - + @@ -7105,7 +7093,7 @@ Similar to: line="4853">Test flat array input with transfer none. Similar to g_main_context_check() or gtk_target_list_new(). - + @@ -7131,7 +7119,7 @@ Similar to g_main_context_check() or gtk_target_list_new(). This is similar to gdk_keymap_get_entries_for_keyval(). - + @@ -7159,7 +7147,7 @@ Similar to g_main_context_check() or gtk_target_list_new(). line="4812">Test flat caller-allocated array output. Similar to g_main_context_query(). - + @@ -7193,7 +7181,7 @@ Similar to g_main_context_query(). line="4774">Test flat array output with transfer container. Similar to pango_layout_get_log_attrs(). - + @@ -7225,7 +7213,7 @@ Similar to pango_layout_get_log_attrs(). Test flat fixed-size array output with transfer full. - + @@ -7255,7 +7243,7 @@ Similar to: - mm_modem_peek_ports() with structs - gdk_query_visual_types() with enums - gdk_event_get_axes() with doubles - + @@ -7284,7 +7272,7 @@ Similar to: - + @@ -7335,7 +7323,7 @@ Similar to: - + @@ -7347,7 +7335,7 @@ Similar to: - + @@ -7413,7 +7401,7 @@ Similar to: - + @@ -7429,7 +7417,7 @@ Similar to: - + @@ -7455,7 +7443,7 @@ Similar to: filename="regress.c" line="4055">Notified - callback persists until a DestroyNotify delegate is invoked. - + @@ -7485,7 +7473,7 @@ is invoked. filename="regress.c" line="4082">Adds a scope notified callback with no user data. This can invoke an error condition in bindings which needs to be tested. - + @@ -7504,7 +7492,7 @@ condition in bindings which needs to be tested. - + @@ -7517,7 +7505,7 @@ condition in bindings which needs to be tested. - + @@ -7529,7 +7517,7 @@ condition in bindings which needs to be tested. line="4096">Invokes all callbacks installed by #test_callback_destroy_notify(), adding up their return values, and removes them, invoking the corresponding destroy notfications. - + filename="regress.c" line="4024">Call - callback parameter persists for the duration of the method call and can be released on return. - + @@ -7615,7 +7603,7 @@ call and can be released on return. - + @@ -7623,7 +7611,7 @@ call and can be released on return. - + @@ -7708,7 +7696,7 @@ call and can be released on return. - + @@ -8171,7 +8159,7 @@ element-type annotation. - + @@ -8289,7 +8277,7 @@ element-type annotation. - + @@ -8338,7 +8326,7 @@ It has multiple lines in the documentation. The sky is blue. You will give me your credit card number. - + @@ -8375,7 +8363,7 @@ rgb(20%, 30%, 0%)</literallayout></entry> </informaltable> What we're testing here is that the scanner ignores the @a nested inside XML. - + @@ -8390,7 +8378,7 @@ What we're testing here is that the scanner ignores the @a nested inside XML. - + @@ -8406,7 +8394,7 @@ What we're testing here is that the scanner ignores the @a nested inside XML. - + @@ -8418,14 +8406,14 @@ What we're testing here is that the scanner ignores the @a nested inside XML. - + - + @@ -8464,14 +8452,14 @@ What we're testing here is that the scanner ignores the @a nested inside XML. - + - + @@ -8503,7 +8491,7 @@ What we're testing here is that the scanner ignores the @a nested inside XML.Should not emit a warning: https://bugzilla.gnome.org/show_bug.cgi?id=685399 - + @@ -8530,7 +8518,7 @@ https://bugzilla.gnome.org/show_bug.cgi?id=685399 - + @@ -8567,7 +8555,7 @@ https://bugzilla.gnome.org/show_bug.cgi?id=685399 - + @@ -8626,7 +8614,7 @@ https://bugzilla.gnome.org/show_bug.cgi?id=685399 - + @@ -8666,7 +8654,7 @@ https://bugzilla.gnome.org/show_bug.cgi?id=685399 This function throws an error if m is odd. - + @@ -8702,7 +8690,7 @@ https://bugzilla.gnome.org/show_bug.cgi?id=685399 - + @@ -9003,7 +8991,7 @@ https://bugzilla.gnome.org/show_bug.cgi?id=685399 - + @@ -9035,7 +9023,7 @@ https://bugzilla.gnome.org/show_bug.cgi?id=685399 - + diff --git a/tests/scanner/regress.h b/tests/scanner/regress.h index 962708b..edecc60 100644 --- a/tests/scanner/regress.h +++ b/tests/scanner/regress.h @@ -524,8 +524,6 @@ GQuark regress_atest_error_quark (void); #define REGRESS_BOOL_CONSTANT TRUE #define REGRESS_G_GINT64_CONSTANT (G_GINT64_CONSTANT (1000)) #define REGRESS_GUINT64_CONSTANT ((guint64) -1) -#define REGRESS_GOOD_EXPR_CONSTANT (1 + 2 * (3 + 2) << 3 - 4 >> REGRESS_ATEST_ERROR_CODE2) -#define REGRESS_BAD_EXPR_CONSTANT (1 + SOMETHING_UNDEFINED) typedef guint64 RegressTestTypeGUInt64; #define REGRESS_GUINT64_CONSTANTA ((RegressTestTypeGUInt64) -1)