From 993faac2759316fde53a61109fc62fd271f315c2 Mon Sep 17 00:00:00 2001 From: Kalev Lember Date: Wed, 25 Oct 2017 12:43:02 +0200 Subject: [PATCH] Don't error out for over 500 results We can legitimately get more than 500 when updating a large number of packages and then showing the offline update results. This commit drops the failure path for >500 results; for cases where performance is critical (search), the results are already truncated in gs_plugin_loader_job_sorted_truncation_again() and for other cases we can just keep on going. https://bugzilla.redhat.com/show_bug.cgi?id=1496489 --- lib/gs-plugin-loader.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/lib/gs-plugin-loader.c b/lib/gs-plugin-loader.c index bf36d627..ff12113b 100644 --- a/lib/gs-plugin-loader.c +++ b/lib/gs-plugin-loader.c @@ -3290,15 +3290,6 @@ gs_plugin_loader_process_thread_cb (GTask *task, } } - /* too many */ - if (gs_app_list_length (list) > 500) { - g_task_return_new_error (task, - GS_PLUGIN_ERROR, - GS_PLUGIN_ERROR_NOT_SUPPORTED, - "too many results returned"); - return; - } - /* filter duplicates with priority, taking into account the source name * & version, so we combine available updates with the installed app */ gs_app_list_filter (list, gs_plugin_loader_app_set_prio, plugin_loader); -- 2.14.2