diff --git a/0001-appDisplay-Avoid-a-warning.patch b/0001-appDisplay-Avoid-a-warning.patch new file mode 100644 index 0000000..9cb50ae --- /dev/null +++ b/0001-appDisplay-Avoid-a-warning.patch @@ -0,0 +1,37 @@ +From 40ea93396d99726bf8fbb31ef4bf83585592e80b Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Florian=20M=C3=BCllner?= +Date: Fri, 6 Aug 2021 18:15:40 +0200 +Subject: [PATCH] appDisplay: Avoid a warning + +At least the last stable release of gjs has an issue with async +handlers for custom (i.e. defined in JS) GObject signals. + +The handler still works, but evoking it prints the following warning: + + JS ERROR: Error: Could not guess unspecified GValue type + +We can avoid the warning by using the addAction() convenience +method, which makes for a small nice cleanup anyway. + +https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4531 +--- + js/ui/appDisplay.js | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js +index f86a7bb67..012e88bd0 100644 +--- a/js/ui/appDisplay.js ++++ b/js/ui/appDisplay.js +@@ -3531,8 +3531,7 @@ var AppIconMenu = class AppIconMenu extends PopupMenu.PopupMenu { + + if (Shell.AppSystem.get_default().lookup_app('org.gnome.Software.desktop')) { + this._appendSeparator(); +- let item = this._appendMenuItem(_("Show Details")); +- item.connect('activate', async () => { ++ this.addAction(_('Show Details'), async () => { + let id = this._source.app.get_id(); + let args = GLib.Variant.new('(ss)', [id, '']); + const bus = await Gio.DBus.get(Gio.BusType.SESSION, null); +-- +2.31.1 + diff --git a/gnome-shell.spec b/gnome-shell.spec index b01f1ca..f2f3771 100644 --- a/gnome-shell.spec +++ b/gnome-shell.spec @@ -2,7 +2,7 @@ Name: gnome-shell Version: 40.3 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Window management and application launching for GNOME License: GPLv2+ @@ -31,6 +31,7 @@ Patch34: 0001-extensionDownloader-Refuse-to-override-system-extens.patch Patch35: fix-some-js-warnings.patch Patch36: 0001-st-texture-cache-purge-on-resume.patch Patch37: 0001-Update-generated-stylesheets.patch +Patch38: 0001-appDisplay-Avoid-a-warning.patch %define eds_version 3.33.1 %define gnome_desktop_version 3.35.91 @@ -249,6 +250,10 @@ desktop-file-validate %{buildroot}%{_datadir}/applications/evolution-calendar.de %{_mandir}/man1/gnome-shell.1* %changelog +* Mon Aug 09 2021 Florian Müllner - 40.3-2 +- Avoid a gjs warning + Resolves: #1990821 + * Mon Jul 12 2021 Florian Müllner - 40.3-1 - Update to 40.3 Resolves: #1979143