From 3fa008650dee847d982c11d813e22d16b470191c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Tue, 19 Nov 2024 13:31:26 +0100 Subject: [PATCH] Fixed leaked signal connection Related: https://issues.redhat.com/browse/RHEL-22692 --- 0001-dnd-Don-t-leak-a-signal-connection.patch | 28 +++++++++++++++++++ gnome-shell.spec | 7 ++++- 2 files changed, 34 insertions(+), 1 deletion(-) create mode 100644 0001-dnd-Don-t-leak-a-signal-connection.patch diff --git a/0001-dnd-Don-t-leak-a-signal-connection.patch b/0001-dnd-Don-t-leak-a-signal-connection.patch new file mode 100644 index 0000000..e976448 --- /dev/null +++ b/0001-dnd-Don-t-leak-a-signal-connection.patch @@ -0,0 +1,28 @@ +From 97c77c6f222d9a7ca24bb32295f8debf65b303a1 Mon Sep 17 00:00:00 2001 +From: Zacharie DUBRULLE +Date: Thu, 18 May 2023 11:40:32 +0000 +Subject: [PATCH] dnd: Don't leak a signal connection + +The handler is currently leaked when a drag monitor stops a +motion event. + +Part-of: +--- + js/ui/dnd.js | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/js/ui/dnd.js b/js/ui/dnd.js +index cefde6f603..5027ed4325 100644 +--- a/js/ui/dnd.js ++++ b/js/ui/dnd.js +@@ -562,6 +562,7 @@ var _Draggable = class _Draggable { + let result = motionFunc(dragEvent); + if (result != DragMotionResult.CONTINUE) { + global.display.set_cursor(DRAG_CURSOR_MAP[result]); ++ dragEvent.targetActor.disconnect(targetActorDestroyHandlerId); + return GLib.SOURCE_REMOVE; + } + } +-- +2.47.0 + diff --git a/gnome-shell.spec b/gnome-shell.spec index 417a557..6558727 100644 --- a/gnome-shell.spec +++ b/gnome-shell.spec @@ -8,7 +8,7 @@ Name: gnome-shell Version: 40.10 -Release: 22%{?dist} +Release: 23%{?dist} Summary: Window management and application launching for GNOME License: GPLv2+ @@ -70,6 +70,7 @@ Patch60: 0001-windowPreview-Override-with-window-icon-if-available.patch Patch61: screencast-bus-name.patch Patch62: fix-inhibit-shortcut-permission.patch Patch63: 0001-shell-window-tracker-Help-mutter-finding-app-info-s-.patch +Patch64: 0001-dnd-Don-t-leak-a-signal-connection.patch %define eds_version 3.33.1 %define gnome_desktop_version 3.35.91 @@ -299,6 +300,10 @@ desktop-file-validate %{buildroot}%{_datadir}/applications/evolution-calendar.de %endif %changelog +* Tue Nov 19 2024 Florian Müllner - 40.10-23 +- Fix leaked signal connection + Related: RHEL-22692 + * Fri Oct 18 2024 Jonas Ådahl - 40.10-22 - Help mutter finding app info for windows Resolves: RHEL-63000