rpms/gnome-shell-extensions
7
0
Fork 0
Code Issues Pull Requests Releases Activity

Fix tooltip animation times

Browse Source 
Backporting the change from upstream involved translating between
Clutter's implicit animations API (which expresses duration in
milliseconds) and the old Tweener API (which uses seconds).

Unfortunately there was a mixed up between division and multiplication,
with the result that tooltips animate over
40 hours rather than 150 milliseconds. Fix that.

Resolves: RHEL-33681
This commit is contained in:
Florian Müllner 2024-04-23 13:24:05 +02:00
parent 618bbaa0a6
commit c1a623ff21
No known key found for this signature in database
2 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
add-workspace-tooltips.patch
View File

@ -1,4 +1,4 @@
From 1f9f4af38f991b462ee5f872a697d88a9e115499 Mon Sep 17 00:00:00 2001 From b87a0085342b9828e7e57e8db892b79e345bfbc3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org> From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>
Date: Wed, 20 Jan 2021 20:18:39 +0100 Date: Wed, 20 Jan 2021 20:18:39 +0100
Subject: [PATCH 1/2] workspace-indicator: Add tooltips to workspace thumbnails Subject: [PATCH 1/2] workspace-indicator: Add tooltips to workspace thumbnails
@ -11,7 +11,7 @@ those, so expose them as tooltip on hover.
1 file changed, 40 insertions(+) 1 file changed, 40 insertions(+)
diff --git a/extensions/workspace-indicator/extension.js b/extensions/workspace-indicator/extension.js diff --git a/extensions/workspace-indicator/extension.js b/extensions/workspace-indicator/extension.js
index 69eef88c..b10e37ff 100644 index 69eef88c..d377f288 100644
--- a/extensions/workspace-indicator/extension.js --- a/extensions/workspace-indicator/extension.js
+++ b/extensions/workspace-indicator/extension.js +++ b/extensions/workspace-indicator/extension.js
@@ -8,6 +8,7 @@ const ExtensionUtils = imports.misc.extensionUtils; @@ -8,6 +8,7 @@ const ExtensionUtils = imports.misc.extensionUtils;
@ -72,7 +72,7 @@ index 69eef88c..b10e37ff 100644
+ +
+ Tweener.addTween(this._tooltip, { + Tweener.addTween(this._tooltip, {
+ opacity: this.hover ? 255 : 0, + opacity: this.hover ? 255 : 0,
+ time: TOOLTIP_ANIMATION_TIME * 1000, + time: TOOLTIP_ANIMATION_TIME / 1000,
+ transition: 'easeOutQuad', + transition: 'easeOutQuad',
+ onComplete: () => (this._tooltip.visible = this.hover), + onComplete: () => (this._tooltip.visible = this.hover),
+ }); + });
@ -85,10 +85,10 @@ index 69eef88c..b10e37ff 100644
this._workspace.disconnect(this._windowRemovedId); this._workspace.disconnect(this._windowRemovedId);
global.display.disconnect(this._restackedId); global.display.disconnect(this._restackedId);
-- --
2.31.1 2.44.0
From 19e19e11214b6b9deae110cd6a4c9232d77c18cb Mon Sep 17 00:00:00 2001 From 36f2762c8c6cda512f164ea22b62d10d03a369b6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org> From: =?UTF-8?q?Florian=20M=C3=BCllner?= <fmuellner@gnome.org>
Date: Wed, 20 Jan 2021 20:29:01 +0100 Date: Wed, 20 Jan 2021 20:29:01 +0100
Subject: [PATCH 2/2] window-list: Add tooltips to workspace thumbnails Subject: [PATCH 2/2] window-list: Add tooltips to workspace thumbnails
@ -101,7 +101,7 @@ expose them as tooltip on hover.
1 file changed, 40 insertions(+) 1 file changed, 40 insertions(+)
diff --git a/extensions/window-list/workspaceIndicator.js b/extensions/window-list/workspaceIndicator.js diff --git a/extensions/window-list/workspaceIndicator.js b/extensions/window-list/workspaceIndicator.js
index ca476111..33ec9b0e 100644 index ca476111..8ae9b288 100644
--- a/extensions/window-list/workspaceIndicator.js --- a/extensions/window-list/workspaceIndicator.js
+++ b/extensions/window-list/workspaceIndicator.js +++ b/extensions/window-list/workspaceIndicator.js
@@ -5,10 +5,14 @@ const DND = imports.ui.dnd; @@ -5,10 +5,14 @@ const DND = imports.ui.dnd;
@ -159,7 +159,7 @@ index ca476111..33ec9b0e 100644
+ +
+ Tweener.addTween(this._tooltip, { + Tweener.addTween(this._tooltip, {
+ opacity: this.hover ? 255 : 0, + opacity: this.hover ? 255 : 0,
+ time: TOOLTIP_ANIMATION_TIME * 1000, + time: TOOLTIP_ANIMATION_TIME / 1000,
+ transition: 'easeOutQuad', + transition: 'easeOutQuad',
+ onComplete: () => (this._tooltip.visible = this.hover), + onComplete: () => (this._tooltip.visible = this.hover),
+ }); + });
@ -172,5 +172,5 @@ index ca476111..33ec9b0e 100644
this._workspace.disconnect(this._windowRemovedId); this._workspace.disconnect(this._windowRemovedId);
global.display.disconnect(this._restackedId); global.display.disconnect(this._restackedId);
-- --
2.31.1 2.44.0

6
gnome-shell-extensions.spec
View File

@ -6,7 +6,7 @@
Name: gnome-shell-extensions Name: gnome-shell-extensions
Version: 3.32.1 Version: 3.32.1
Release: 38%{?dist} Release: 39%{?dist}
Summary: Modify and extend GNOME Shell functionality and behavior Summary: Modify and extend GNOME Shell functionality and behavior
Group: User Interface/Desktops Group: User Interface/Desktops
@ -573,6 +573,10 @@ cp $RPM_SOURCE_DIR/gnome-classic.desktop $RPM_BUILD_ROOT%{_datadir}/xsessions
%changelog %changelog
* Tue Apr 23 2024 Florian Müllner <fmuellner@redhat.com> - 3.32.1-39
- Fix tooltip animation times
Resolves: RHEL-33681
* Wed Feb 07 2024 Florian Müllner <fmuellner@redhat.com> - 3.32.1-38 * Wed Feb 07 2024 Florian Müllner <fmuellner@redhat.com> - 3.32.1-38
- Hide classification banners from picks - Hide classification banners from picks
Resolves: RHEL-24438 Resolves: RHEL-24438