plug memory leaks

This commit is contained in:
Matthias Clasen 2008-09-15 01:50:49 +00:00
parent a4a076c5df
commit be6c204b17
2 changed files with 26 additions and 1 deletions

19
empty-string-leak.patch Normal file
View File

@ -0,0 +1,19 @@
diff -up gnome-session-2.23.92/gnome-session/gsm-manager.c.empty-string-leak gnome-session-2.23.92/gnome-session/gsm-manager.c
--- gnome-session-2.23.92/gnome-session/gsm-manager.c.empty-string-leak 2008-09-14 21:44:18.000000000 -0400
+++ gnome-session-2.23.92/gnome-session/gsm-manager.c 2008-09-14 21:48:06.000000000 -0400
@@ -913,6 +913,7 @@ _on_query_end_session_timeout (GsmManage
app_id = g_strdup (gsm_client_peek_app_id (l->data));
if (IS_STRING_EMPTY (app_id)) {
/* XSMP clients don't give us an app id unless we start them */
+ g_free (app_id);
app_id = gsm_client_get_app_name (l->data);
}
@@ -1529,6 +1530,7 @@ on_client_end_session_response (GsmClien
app_id = g_strdup (gsm_client_peek_app_id (client));
if (IS_STRING_EMPTY (app_id)) {
/* XSMP clients don't give us an app id unless we start them */
+ g_free (app_id);
app_id = gsm_client_get_app_name (client);
}

View File

@ -12,7 +12,7 @@
Summary: GNOME session manager Summary: GNOME session manager
Name: gnome-session Name: gnome-session
Version: 2.23.92 Version: 2.23.92
Release: 2%{?dist} Release: 3%{?dist}
URL: http://www.gnome.org URL: http://www.gnome.org
Source0: http://download.gnome.org/sources/gnome-session/2.23/%{name}-%{version}.tar.bz2 Source0: http://download.gnome.org/sources/gnome-session/2.23/%{name}-%{version}.tar.bz2
Source1: redhat-default-session Source1: redhat-default-session
@ -69,6 +69,8 @@ Patch0: ListenObjs-leak.patch
Patch1: previous_id-leak.patch Patch1: previous_id-leak.patch
# http://bugzilla.gnome.org/show_bug.cgi?id=552294 # http://bugzilla.gnome.org/show_bug.cgi?id=552294
Patch2: inhibitor-leak.patch Patch2: inhibitor-leak.patch
# http://bugzilla.gnome.org/show_bug.cgi?id=552302
Patch3: empty-string-leak.patch
%description %description
@ -80,6 +82,7 @@ GNOME components and handles logout and saving the session.
%patch0 -p1 -b .ListenObjs-leak %patch0 -p1 -b .ListenObjs-leak
%patch1 -p1 -b .previous_id-leak %patch1 -p1 -b .previous_id-leak
%patch2 -p1 -b .inhibitor-leak %patch2 -p1 -b .inhibitor-leak
%patch3 -p1 -b .empty-string-leak
%build %build
@ -178,6 +181,9 @@ fi
%changelog %changelog
* Sun Sep 14 2008 Matthias Clasen <mclasen@redhat.com> - 2.23.92-3
- Plug memory leaks
* Sun Sep 14 2008 Matthias Clasen <mclasen@redhat.com> - 2.23.92-2 * Sun Sep 14 2008 Matthias Clasen <mclasen@redhat.com> - 2.23.92-2
- Plug memory leaks - Plug memory leaks