Fix headless mode (#2078976)

Resolves: #2078976
This commit is contained in:
David King 2022-07-13 13:42:41 +01:00
parent 466811f57e
commit 8a0b909659
2 changed files with 50 additions and 0 deletions

View File

@ -0,0 +1,45 @@
From 97316afbd1e9b0c25de5f87b52d47448ee667bdb Mon Sep 17 00:00:00 2001
From: Sebastian Keller <skeller@gnome.org>
Date: Fri, 12 Nov 2021 22:21:27 +0100
Subject: [PATCH] application: Drop support for non-unique mode in headless
instance
gnome-shell started allowing only applications that own certain names
on the session bus to interact with the screenshot interface. While the
name used by gnome-screenshot is on the allowed list, non-unique
instances that are used for the headless mode do not own that name. Fix
this by also making the headless instance unique so it will own the
name. This however also means that there can only ever be a single
instance of gnome-screenshot, regardless of headless or interactive.
Fixes: https://gitlab.gnome.org/GNOME/gnome-screenshot/-/issues/179
---
src/screenshot-application.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/src/screenshot-application.c b/src/screenshot-application.c
index cc663d4..7acdc0e 100644
--- a/src/screenshot-application.c
+++ b/src/screenshot-application.c
@@ -630,18 +630,6 @@ screenshot_application_handle_local_options (GApplication *app,
exit (EXIT_SUCCESS);
}
- /* Start headless instances in non-unique mode */
- if (!g_variant_dict_contains (options, "interactive"))
- {
- GApplicationFlags old_flags;
-
- old_flags = g_application_get_flags (app);
- if ((old_flags & G_APPLICATION_IS_SERVICE) == 0)
- {
- g_application_set_flags (app, old_flags | G_APPLICATION_NON_UNIQUE);
- }
- }
-
return -1;
}
--
GitLab

View File

@ -8,6 +8,8 @@ Summary: A screenshot utility for GNOME
License: GPLv2+ License: GPLv2+
URL: https://gitlab.gnome.org/GNOME/gnome-screenshot URL: https://gitlab.gnome.org/GNOME/gnome-screenshot
Source0: https://download.gnome.org/sources/gnome-screenshot/40/gnome-screenshot-%{tarball_version}.tar.xz Source0: https://download.gnome.org/sources/gnome-screenshot/40/gnome-screenshot-%{tarball_version}.tar.xz
# https://bugzilla.redhat.com/show_bug.cgi?id=2078976
Patch0: gnome-screenshot-40.0-headless-fix.patch
BuildRequires: gcc BuildRequires: gcc
BuildRequires: gettext BuildRequires: gettext
@ -57,6 +59,9 @@ desktop-file-validate %{buildroot}%{_datadir}/applications/org.gnome.Screenshot.
%changelog %changelog
* Wed Jul 13 2022 David King <amigadave@amigadave.com> - 40.0-3
- Fix headless mode (#2078976)
* Mon Aug 09 2021 Mohan Boddu <mboddu@redhat.com> - 40.0-3 * Mon Aug 09 2021 Mohan Boddu <mboddu@redhat.com> - 40.0-3
- Rebuilt for IMA sigs, glibc 2.34, aarch64 flags - Rebuilt for IMA sigs, glibc 2.34, aarch64 flags
Related: rhbz#1991688 Related: rhbz#1991688