48 lines
2.0 KiB
Diff
48 lines
2.0 KiB
Diff
From 822fc6bc11b9dc0c84779d88aa950003210f029b Mon Sep 17 00:00:00 2001
|
||
From: Olivier Fourdan <ofourdan@redhat.com>
|
||
Date: Thu, 29 Jan 2026 16:38:29 +0100
|
||
Subject: [PATCH 1/2] input-source-manager: Fix uninitialized variable
|
||
MIME-Version: 1.0
|
||
Content-Type: text/plain; charset=UTF-8
|
||
Content-Transfer-Encoding: 8bit
|
||
|
||
Recent changes introduced a use of an uninitialized variable:
|
||
|
||
| compositor/kiosk-input-sources-manager.c: In function
|
||
| ‘kiosk_input_sources_manager_set_input_sources_from_locales’:
|
||
| compositor/kiosk-input-sources-manager.c:1092:12: error:
|
||
| ‘input_source_group_active’ may be used uninitialized
|
||
| [-Werror=maybe-uninitialized]
|
||
| 1092 | if (!input_source_group_active) {
|
||
| | ^
|
||
| compositor/kiosk-input-sources-manager.c:1036:18: note:
|
||
| ‘input_source_group_active’ was declared here
|
||
| 1036 | gboolean input_source_group_active;
|
||
| | ^~~~~~~~~~~~~~~~~~~~~~~~~
|
||
|
||
Fixes: (6489a45a5) - input-source-manager: Don't change active input
|
||
source if locked
|
||
|
||
Part-of: <https://gitlab.gnome.org/GNOME/gnome-kiosk/-/merge_requests/117>
|
||
(cherry picked from commit d9d1207fdf25d34eead73d29682f5b9cc3ff77df)
|
||
---
|
||
compositor/kiosk-input-sources-manager.c | 2 +-
|
||
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
||
diff --git a/compositor/kiosk-input-sources-manager.c b/compositor/kiosk-input-sources-manager.c
|
||
index 6713ef9..725b17f 100644
|
||
--- a/compositor/kiosk-input-sources-manager.c
|
||
+++ b/compositor/kiosk-input-sources-manager.c
|
||
@@ -1036,7 +1036,7 @@ kiosk_input_sources_manager_set_input_sources_from_locales (KioskInputSourcesMan
|
||
g_autofree char *old_selected_layout = NULL;
|
||
g_autofree char *old_input_engine = NULL;
|
||
g_autofree char *locales_string = NULL;
|
||
- gboolean input_source_group_active;
|
||
+ gboolean input_source_group_active = TRUE;
|
||
|
||
g_return_val_if_fail (KIOSK_IS_INPUT_SOURCES_MANAGER (self), FALSE);
|
||
g_return_val_if_fail (locales != NULL, FALSE);
|
||
--
|
||
2.55.0
|
||
|