From 4dfc8594f13461416ccff8ec2aa1871860ba1034 Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Wed, 16 Oct 2013 00:52:13 +0100 Subject: [PATCH 1/4] Update to 3.10.1.1 --- .gitignore | 1 + gnome-initial-setup.spec | 5 ++++- sources | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 7b18bdb..42193a3 100644 --- a/.gitignore +++ b/.gitignore @@ -10,3 +10,4 @@ /gnome-initial-setup-0.12.tar.xz /gnome-initial-setup-3.10.0.tar.xz /gnome-initial-setup-3.10.0.1.tar.xz +/gnome-initial-setup-3.10.1.1.tar.xz diff --git a/gnome-initial-setup.spec b/gnome-initial-setup.spec index 69bab43..f1886e9 100644 --- a/gnome-initial-setup.spec +++ b/gnome-initial-setup.spec @@ -1,5 +1,5 @@ Name: gnome-initial-setup -Version: 3.10.0.1 +Version: 3.10.1.1 Release: 1%{?dist} Summary: Bootstrapping your OS @@ -107,6 +107,9 @@ useradd -rM -d /run/gnome-initial-setup/ -s /sbin/nologin %{name} &>/dev/null || %{_datadir}/polkit-1/rules.d/20-gnome-initial-setup.rules %changelog +* Tue Oct 15 2013 Richard Hughes - 3.10.1.1-1 +- Update to 3.10.1.1 + * Thu Sep 26 2013 Kalev Lember - 3.10.0.1-1 - Update to 3.10.0.1 diff --git a/sources b/sources index 9756d2b..459b846 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -0bf19329a63499a556e5d2d5b04b8dfb gnome-initial-setup-3.10.0.1.tar.xz +a66a23a85d0b8f2cbff70cc68572e84c gnome-initial-setup-3.10.1.1.tar.xz From dd0465b14a2106ed7f70f2740afc5c85b66fd934 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Fri, 1 Nov 2013 20:05:15 -0400 Subject: [PATCH 2/4] Fix goa add dialog to not be empty --- gnome-initial-setup.spec | 9 ++++++++- goa-add.patch | 11 +++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 goa-add.patch diff --git a/gnome-initial-setup.spec b/gnome-initial-setup.spec index f1886e9..7f17b3c 100644 --- a/gnome-initial-setup.spec +++ b/gnome-initial-setup.spec @@ -1,6 +1,6 @@ Name: gnome-initial-setup Version: 3.10.1.1 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Bootstrapping your OS License: GPLv2+ @@ -11,6 +11,9 @@ Source0: http://download.gnome.org/sources/%{name}/3.10/%{name}-%{version # https://bugzilla.gnome.org/show_bug.cgi?id=687957 Patch0: yelp-fixes.patch +# upstream fix +Patch1: goa-add.patch + %global nm_version 0.9.6.4 %global glib_required_version 2.36.0 %global gtk_required_version 3.7.11 @@ -66,6 +69,7 @@ you through configuring it. It is integrated with gdm. %prep %setup -q %patch0 -p1 -b .yelp-fixes +%patch1 -p1 -b .goa autoreconf -i -f @@ -107,6 +111,9 @@ useradd -rM -d /run/gnome-initial-setup/ -s /sbin/nologin %{name} &>/dev/null || %{_datadir}/polkit-1/rules.d/20-gnome-initial-setup.rules %changelog +* Fri Nov 1 2013 Matthias Clasen - 3.10.1.1-2 +- Fix goa add dialog to not be empty + * Tue Oct 15 2013 Richard Hughes - 3.10.1.1-1 - Update to 3.10.1.1 diff --git a/goa-add.patch b/goa-add.patch new file mode 100644 index 0000000..46ee69a --- /dev/null +++ b/goa-add.patch @@ -0,0 +1,11 @@ +diff -up gnome-initial-setup-3.10.1.1/gnome-initial-setup/pages/goa/gis-goa-page.c.goa gnome-initial-setup-3.10.1.1/gnome-initial-setup/pages/goa/gis-goa-page.c +--- gnome-initial-setup-3.10.1.1/gnome-initial-setup/pages/goa/gis-goa-page.c.goa 2013-11-01 20:03:47.453759134 -0400 ++++ gnome-initial-setup-3.10.1.1/gnome-initial-setup/pages/goa/gis-goa-page.c 2013-11-01 20:03:59.450736921 -0400 +@@ -81,6 +81,7 @@ on_have_providers (GObject *source + goa_panel_add_account_dialog_add_provider (GOA_PANEL_ADD_ACCOUNT_DIALOG (dialog), provider); + } + ++ gtk_widget_show_all (dialog); + goa_panel_add_account_dialog_run (GOA_PANEL_ADD_ACCOUNT_DIALOG (dialog)); + goa_panel_add_account_dialog_get_account (GOA_PANEL_ADD_ACCOUNT_DIALOG (dialog), &error); + gtk_widget_destroy (dialog); From 82dff6b79d92c10fceb5e502927edc5a1526b3d2 Mon Sep 17 00:00:00 2001 From: Rui Matos Date: Thu, 28 Nov 2013 16:23:40 +0100 Subject: [PATCH 3/4] Resolves: rhbz#1027507 - [abrt] gnome-initial-setup-3.10.1.1-2.fc20: magazine_chain_pop_head --- 0001-goa-Prevent-a-use-after-free.patch | 27 +++++++++++++++++++++++++ gnome-initial-setup.spec | 7 ++++++- 2 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 0001-goa-Prevent-a-use-after-free.patch diff --git a/0001-goa-Prevent-a-use-after-free.patch b/0001-goa-Prevent-a-use-after-free.patch new file mode 100644 index 0000000..0a015a4 --- /dev/null +++ b/0001-goa-Prevent-a-use-after-free.patch @@ -0,0 +1,27 @@ +From 48302b7796e7016dc563f3d6366982f073b27ebe Mon Sep 17 00:00:00 2001 +From: "Jasper St. Pierre" +Date: Sat, 9 Nov 2013 11:43:48 -0500 +Subject: [PATCH] goa: Prevent a use-after-free + +If the user dismisses the dialog, we'll get an error and free it, +but forget to set it to NULL, and segfault. +--- + gnome-initial-setup/pages/goa/gis-goa-page.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/gnome-initial-setup/pages/goa/gis-goa-page.c b/gnome-initial-setup/pages/goa/gis-goa-page.c +index 85b8ff5..3228159 100644 +--- a/gnome-initial-setup/pages/goa/gis-goa-page.c ++++ b/gnome-initial-setup/pages/goa/gis-goa-page.c +@@ -106,7 +106,7 @@ on_have_providers (GObject *source, + gtk_dialog_run (GTK_DIALOG (dialog)); + gtk_widget_destroy (dialog); + } +- g_error_free (error); ++ g_clear_error (&error); + } + + g_list_free_full (providers, g_object_unref); +-- +1.8.3.1 + diff --git a/gnome-initial-setup.spec b/gnome-initial-setup.spec index 7f17b3c..bfc178c 100644 --- a/gnome-initial-setup.spec +++ b/gnome-initial-setup.spec @@ -1,6 +1,6 @@ Name: gnome-initial-setup Version: 3.10.1.1 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Bootstrapping your OS License: GPLv2+ @@ -13,6 +13,7 @@ Patch0: yelp-fixes.patch # upstream fix Patch1: goa-add.patch +Patch2: 0001-goa-Prevent-a-use-after-free.patch %global nm_version 0.9.6.4 %global glib_required_version 2.36.0 @@ -70,6 +71,7 @@ you through configuring it. It is integrated with gdm. %setup -q %patch0 -p1 -b .yelp-fixes %patch1 -p1 -b .goa +%patch2 -p1 autoreconf -i -f @@ -111,6 +113,9 @@ useradd -rM -d /run/gnome-initial-setup/ -s /sbin/nologin %{name} &>/dev/null || %{_datadir}/polkit-1/rules.d/20-gnome-initial-setup.rules %changelog +* Thu Nov 28 2013 Rui Matos - 3.10.1.1-3 +- Resolves: rhbz#1027507 - [abrt] gnome-initial-setup-3.10.1.1-2.fc20: magazine_chain_pop_head + * Fri Nov 1 2013 Matthias Clasen - 3.10.1.1-2 - Fix goa add dialog to not be empty From 8a885589edca8232360a92eb2dca040c1fa34a7f Mon Sep 17 00:00:00 2001 From: Rui Matos Date: Fri, 29 Nov 2013 17:19:03 +0100 Subject: [PATCH 4/4] Resolves: rhbz#1035548 - Disables the GOA page in new user mode --- 0001-Disable-GOA-page-in-new-user-mode.patch | 25 ++++++++++++++++++++ gnome-initial-setup.spec | 7 +++++- 2 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 0001-Disable-GOA-page-in-new-user-mode.patch diff --git a/0001-Disable-GOA-page-in-new-user-mode.patch b/0001-Disable-GOA-page-in-new-user-mode.patch new file mode 100644 index 0000000..5ef84d2 --- /dev/null +++ b/0001-Disable-GOA-page-in-new-user-mode.patch @@ -0,0 +1,25 @@ +From 93340174b7e13ec85ce82f299ffcd577a33902fa Mon Sep 17 00:00:00 2001 +From: Rui Matos +Date: Fri, 29 Nov 2013 18:15:34 +0100 +Subject: [PATCH] Disable GOA page in new user mode + +--- + gnome-initial-setup/gnome-initial-setup.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/gnome-initial-setup/gnome-initial-setup.c b/gnome-initial-setup/gnome-initial-setup.c +index 0cb370a..145d3be 100644 +--- a/gnome-initial-setup/gnome-initial-setup.c ++++ b/gnome-initial-setup/gnome-initial-setup.c +@@ -105,6 +105,8 @@ should_skip_page (GisDriver *driver, + } + break; + case GIS_DRIVER_MODE_NEW_USER: ++ if (g_strcmp0 ("goa", page_id) == 0) ++ return TRUE; + default: + break; + } +-- +1.8.3.1 + diff --git a/gnome-initial-setup.spec b/gnome-initial-setup.spec index bfc178c..a1bc288 100644 --- a/gnome-initial-setup.spec +++ b/gnome-initial-setup.spec @@ -1,6 +1,6 @@ Name: gnome-initial-setup Version: 3.10.1.1 -Release: 3%{?dist} +Release: 4%{?dist} Summary: Bootstrapping your OS License: GPLv2+ @@ -14,6 +14,7 @@ Patch0: yelp-fixes.patch # upstream fix Patch1: goa-add.patch Patch2: 0001-goa-Prevent-a-use-after-free.patch +Patch3: 0001-Disable-GOA-page-in-new-user-mode.patch %global nm_version 0.9.6.4 %global glib_required_version 2.36.0 @@ -72,6 +73,7 @@ you through configuring it. It is integrated with gdm. %patch0 -p1 -b .yelp-fixes %patch1 -p1 -b .goa %patch2 -p1 +%patch3 -p1 autoreconf -i -f @@ -113,6 +115,9 @@ useradd -rM -d /run/gnome-initial-setup/ -s /sbin/nologin %{name} &>/dev/null || %{_datadir}/polkit-1/rules.d/20-gnome-initial-setup.rules %changelog +* Fri Nov 29 2013 Rui Matos - 3.10.1.1-4 +- Resolves: rhbz#1035548 - Disables the GOA page in new user mode + * Thu Nov 28 2013 Rui Matos - 3.10.1.1-3 - Resolves: rhbz#1027507 - [abrt] gnome-initial-setup-3.10.1.1-2.fc20: magazine_chain_pop_head