cf62f1947f
Resolves: bz#1264911 bz#1277924 bz#1286820 bz#1360331 bz#1401969 Resolves: bz#1410719 bz#1419438 bz#1426042 bz#1444820 bz#1459101 Resolves: bz#1464150 bz#1464350 bz#1466122 bz#1466129 bz#1467903 Resolves: bz#1468972 bz#1476876 bz#1484446 bz#1492591 bz#1498391 Resolves: bz#1498730 bz#1499865 bz#1500704 bz#1501345 bz#1505570 Resolves: bz#1507361 bz#1507394 bz#1509102 bz#1509191 bz#1509810 Resolves: bz#1509833 bz#1511766 bz#1512470 bz#1512496 bz#1512963 Resolves: bz#1515051 bz#1519076 bz#1519740 bz#1534253 bz#1534530 Signed-off-by: Milind Changire <mchangir@redhat.com>
58 lines
2.2 KiB
Diff
58 lines
2.2 KiB
Diff
From de1ee9800f8e20d0c0a8adb1994f208d2dc8ae09 Mon Sep 17 00:00:00 2001
|
|
From: Raghavendra G <rgowdapp@redhat.com>
|
|
Date: Tue, 10 Oct 2017 11:29:04 +0530
|
|
Subject: [PATCH 110/128] Revert "mount/fuse: report ESTALE as ENOENT"
|
|
|
|
This reverts commit 26d16b90ec7f8acbe07e56e8fe1baf9c9fa1519e.
|
|
|
|
Consider rename (index.new, store.idx) and open (store.idx) being
|
|
executed in parallel. When we break down operations following sequence
|
|
is possible.
|
|
|
|
* lookup (store.idx) - as part of open(store.idx) returns gfid1 as the
|
|
result.
|
|
* rename (index.new, store.idx) changes gfid of store.idx to
|
|
gfid2. Note that gfid2 was the nodeid of index.new. Since rename is
|
|
successful, gfid2 is associated with store.idx.
|
|
* open (store.idx) resumes and issues open fop to glusterfs with
|
|
gfid1. open in glusterfs fails as gfid1 doesn't exist and the error
|
|
returned by glusterfs to kernel-fuse is ENOENT.
|
|
* kernel passes back the same error to application as a result to
|
|
open.
|
|
|
|
This error could've been prevented if kernel retries open with
|
|
gfid2. Interestingly kernel do retry open when it receives ESTALE
|
|
error. Even though failure to find gfid resulted in ESTALE error,
|
|
commit 26d16b90ec7f8acb converted that error to ENOENT while sending
|
|
an error reply to kernel. This prevented kernel from retrying open
|
|
resulting in error.
|
|
|
|
Change-Id: I2e752ca60dd8af1b989dd1d29c7b002ee58440b4
|
|
BUG: 1492591
|
|
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
|
|
upstream patch: https://review.gluster.org/#/c/18463/
|
|
Reviewed-on: https://code.engineering.redhat.com/gerrit/126509
|
|
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
|
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
|
---
|
|
xlators/mount/fuse/src/fuse-bridge.c | 3 ---
|
|
1 file changed, 3 deletions(-)
|
|
|
|
diff --git a/xlators/mount/fuse/src/fuse-bridge.c b/xlators/mount/fuse/src/fuse-bridge.c
|
|
index a6dfd66..03d26eb 100644
|
|
--- a/xlators/mount/fuse/src/fuse-bridge.c
|
|
+++ b/xlators/mount/fuse/src/fuse-bridge.c
|
|
@@ -421,9 +421,6 @@ send_fuse_err (xlator_t *this, fuse_in_header_t *finh, int error)
|
|
struct iovec iov_out;
|
|
inode_t *inode = NULL;
|
|
|
|
- if (error == ESTALE)
|
|
- error = ENOENT;
|
|
-
|
|
fouh.error = -error;
|
|
iov_out.iov_base = &fouh;
|
|
|
|
--
|
|
1.8.3.1
|
|
|