52 lines
1.9 KiB
Diff
52 lines
1.9 KiB
Diff
|
From 64cfb0126d88bd6b841777fefb63e413b587a7b1 Mon Sep 17 00:00:00 2001
|
||
|
|
From: N Balachandran <nbalacha@redhat.com>
|
||
|
|
Date: Tue, 18 Dec 2018 14:08:04 +0530
|
||
|
|
Subject: [PATCH 486/493] performance/rda: Fixed dict_t memory leak
|
||
|
|
|
||
|
|
Removed all references to dict_t xdata_from_req which is
|
||
|
|
allocated but not used anywhere. It is also not cleaned up
|
||
|
|
and hence causes a memory leak.
|
||
|
|
|
||
|
|
upstream patch: https://review.gluster.org/#/c/glusterfs/+/21859/
|
||
|
|
|
||
|
|
> Change-Id: I2edb857696191e872ad12a12efc36999626bacc7
|
||
|
|
> fixes: bz#1659432
|
||
|
|
> Signed-off-by: N Balachandran <nbalacha@redhat.com>
|
||
|
|
|
||
|
|
Change-Id: Ic07ecbefef3140aeb24a2afaf97c80ee65768e7e
|
||
|
|
BUG: 1659439
|
||
|
|
Signed-off-by: N Balachandran <nbalacha@redhat.com>
|
||
|
|
Reviewed-on: https://code.engineering.redhat.com/gerrit/158915
|
||
|
|
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
||
|
|
Reviewed-by: Raghavendra Gowdappa <rgowdapp@redhat.com>
|
||
|
|
---
|
||
|
|
xlators/performance/readdir-ahead/src/readdir-ahead.c | 8 --------
|
||
|
|
1 file changed, 8 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/xlators/performance/readdir-ahead/src/readdir-ahead.c b/xlators/performance/readdir-ahead/src/readdir-ahead.c
|
||
|
|
index 6501a6b..3e0951c 100644
|
||
|
|
--- a/xlators/performance/readdir-ahead/src/readdir-ahead.c
|
||
|
|
+++ b/xlators/performance/readdir-ahead/src/readdir-ahead.c
|
||
|
|
@@ -505,18 +505,10 @@ rda_opendir(call_frame_t *frame, xlator_t *this, loc_t *loc, fd_t *fd,
|
||
|
|
{
|
||
|
|
int op_errno = 0;
|
||
|
|
struct rda_local *local = NULL;
|
||
|
|
- dict_t *xdata_from_req = NULL;
|
||
|
|
|
||
|
|
if (xdata) {
|
||
|
|
- xdata_from_req = dict_new();
|
||
|
|
- if (!xdata_from_req) {
|
||
|
|
- op_errno = ENOMEM;
|
||
|
|
- goto unwind;
|
||
|
|
- }
|
||
|
|
-
|
||
|
|
local = mem_get0(this->local_pool);
|
||
|
|
if (!local) {
|
||
|
|
- dict_unref(xdata_from_req);
|
||
|
|
op_errno = ENOMEM;
|
||
|
|
goto unwind;
|
||
|
|
}
|
||
|
|
--
|
||
|
|
1.8.3.1
|
||
|
|
|