55 lines
2.4 KiB
Diff
55 lines
2.4 KiB
Diff
|
From e9cb714d66a7926a746b8cd5f9288d59aefee918 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Kinglong Mee <kinglongmee@gmail.com>
|
||
|
|
Date: Mon, 18 Mar 2019 20:47:54 +0800
|
||
|
|
Subject: [PATCH 391/392] cluster-syncop: avoid duplicate unlock of
|
||
|
|
inodelk/entrylk
|
||
|
|
|
||
|
|
When using ec, there are many messages at brick log as,
|
||
|
|
|
||
|
|
[inodelk.c:514:__inode_unlock_lock] 0-test-locks: Matching lock not found for unlock 0-9223372036854775807, lo=68e040a84b7f0000 on 0x7f208c006f78
|
||
|
|
[MSGID: 115053] [server-rpc-fops_v2.c:280:server4_inodelk_cbk] 0-test-server: 2557439: INODELK <gfid:df4e41be-723f-4289-b7af-b4272b3e880c> (df4e41be-723f-4289-b7af-b4272b3e880c), client: CTX_ID:67d4a7f3-605a-4965-89a5-31309d62d1fa-GRAPH_ID:0-PID:1659-HOST:openfs-node2-PC_NAME:test-client-1-RECON_NO:-28, error-xlator: test-locks [Invalid argument]
|
||
|
|
|
||
|
|
> Change-Id: Ib164d29ebb071f620a4ca9679c4345ef7c88512a
|
||
|
|
> Updates: bz#1689920
|
||
|
|
> Signed-off-by: Kinglong Mee <mijinlong@open-fs.com>
|
||
|
|
> Reviewed on upstream link https://review.gluster.org/#/c/glusterfs/+/22377/
|
||
|
|
|
||
|
|
BUG: 1848890
|
||
|
|
Change-Id: Ib164d29ebb071f620a4ca9679c4345ef7c88512a
|
||
|
|
Signed-off-by: Sheetal Pamecha <spamecha@redhat.com>
|
||
|
|
Reviewed-on: https://code.engineering.redhat.com/gerrit/203852
|
||
|
|
Tested-by: RHGS Build Bot <nigelb@redhat.com>
|
||
|
|
Reviewed-by: Sunil Kumar Heggodu Gopala Acharya <sheggodu@redhat.com>
|
||
|
|
---
|
||
|
|
libglusterfs/src/cluster-syncop.c | 6 ++++++
|
||
|
|
1 file changed, 6 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/libglusterfs/src/cluster-syncop.c b/libglusterfs/src/cluster-syncop.c
|
||
|
|
index 5a08f26..6ee89dd 100644
|
||
|
|
--- a/libglusterfs/src/cluster-syncop.c
|
||
|
|
+++ b/libglusterfs/src/cluster-syncop.c
|
||
|
|
@@ -1203,6 +1203,10 @@ cluster_tiebreaker_inodelk(xlator_t **subvols, unsigned char *on,
|
||
|
|
if (num_success) {
|
||
|
|
FOP_SEQ(subvols, on, numsubvols, replies, locked_on, frame,
|
||
|
|
inodelk, dom, &loc, F_SETLKW, &flock, NULL);
|
||
|
|
+ } else {
|
||
|
|
+ loc_wipe(&loc);
|
||
|
|
+ memset(locked_on, 0, numsubvols);
|
||
|
|
+ return 0;
|
||
|
|
}
|
||
|
|
break;
|
||
|
|
}
|
||
|
|
@@ -1244,7 +1248,9 @@ cluster_tiebreaker_entrylk(xlator_t **subvols, unsigned char *on,
|
||
|
|
entrylk, dom, &loc, name, ENTRYLK_LOCK, ENTRYLK_WRLCK,
|
||
|
|
NULL);
|
||
|
|
} else {
|
||
|
|
+ loc_wipe(&loc);
|
||
|
|
memset(locked_on, 0, numsubvols);
|
||
|
|
+ return 0;
|
||
|
|
}
|
||
|
|
break;
|
||
|
|
}
|
||
|
|
--
|
||
|
|
1.8.3.1
|
||
|
|
|