2a30b8f4b2
Upstream commit: dcaf51b41e259387602774829c45222d0507f90a - elf: Change ldconfig auxcache magic number (bug 32231) - Make tst-strtod-underflow type-generic - Add crt1-2.0.o for glibc 2.0 compatibility tests - Add tests of more strtod special cases - Add more tests of strtod end pointer - Make tst-strtod2 and tst-strtod5 type-generic - powerpc64le: Build new strtod tests with long double ABI flags (bug 32145) - Do not set errno for overflowing NaN payload in strtod/nan (bug 32045) - Improve NaN payload testing - Make __strtod_internal tests type-generic - Fix strtod subnormal rounding (bug 30220) - More thoroughly test underflow / errno in tst-strtod-round - Test errno setting on strtod overflow in tst-strtod-round - Add tests of fread - stdio-common: Add new test for fdopen - libio: Attempt wide backup free only for non-legacy code - debug: Fix read error handling in pcprofiledump - elf: Fix tst-dlopen-tlsreinit1.out test dependency - elf: Avoid re-initializing already allocated TLS in dlopen (bug 31717) - elf: Clarify and invert second argument of _dl_allocate_tls_init - elf: Support recursive use of dynamic TLS in interposed malloc - nptl: Use <support/check.h> facilities in tst-setuid3 - posix: Use <support/check.h> facilities in tst-truncate and tst-truncate64 - ungetc: Fix backup buffer leak on program exit [BZ #27821] - ungetc: Fix uninitialized read when putting into unused streams [BZ #27821] - Make tst-ungetc use libsupport - stdio-common: Add test for vfscanf with matches longer than INT_MAX [BZ #27650] - support: Add FAIL test failure helper - string: strerror, strsignal cannot use buffer after dlmopen (bug 32026) - Define __libc_initial for the static libc - x86: Fix bug in strchrnul-evex512 [BZ #32078] - Adjust check-local-headers test for libaudit 4.0 - x32/cet: Support shadow stack during startup for Linux 6.10 - x86-64: Remove sysdeps/x86_64/x32/dl-machine.h - support: Add options list terminator to the test driver - manual/stdio: Further clarify putc, putwc, getc, and getwc - Fix name space violation in fortify wrappers (bug 32052) - resolv: Fix tst-resolv-short-response for older GCC (bug 32042) - Add mremap tests - mremap: Update manual entry - linux: Update the mremap C implementation [BZ #31968] - Enhanced test coverage for strncmp, wcsncmp - Enhance test coverage for strnlen, wcsnlen Resolves: RHEL-57776 Resolves: RHEL-57777 Resolves: RHEL-61392
94 lines
3.7 KiB
Diff
94 lines
3.7 KiB
Diff
commit e3d5d2d3508faeb8545f871a419f4ac46fa16df2
|
|
Author: Florian Weimer <fweimer@redhat.com>
|
|
Date: Thu Aug 1 23:31:23 2024 +0200
|
|
|
|
elf: Clarify and invert second argument of _dl_allocate_tls_init
|
|
|
|
Also remove an outdated comment: _dl_allocate_tls_init is
|
|
called as part of pthread_create.
|
|
|
|
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
|
|
(cherry picked from commit fe06fb313bddf7e4530056897d4a706606e49377)
|
|
|
|
diff --git a/elf/dl-tls.c b/elf/dl-tls.c
|
|
index 3d221273f1915f19..ecb966d282213131 100644
|
|
--- a/elf/dl-tls.c
|
|
+++ b/elf/dl-tls.c
|
|
@@ -552,9 +552,14 @@ _dl_resize_dtv (dtv_t *dtv, size_t max_modid)
|
|
/* Allocate initial TLS. RESULT should be a non-NULL pointer to storage
|
|
for the TLS space. The DTV may be resized, and so this function may
|
|
call malloc to allocate that space. The loader's GL(dl_load_tls_lock)
|
|
- is taken when manipulating global TLS-related data in the loader. */
|
|
+ is taken when manipulating global TLS-related data in the loader.
|
|
+
|
|
+ If MAIN_THREAD, this is the first call during process
|
|
+ initialization. In this case, TLS initialization for secondary
|
|
+ (audit) namespaces is skipped because that has already been handled
|
|
+ by dlopen. */
|
|
void *
|
|
-_dl_allocate_tls_init (void *result, bool init_tls)
|
|
+_dl_allocate_tls_init (void *result, bool main_thread)
|
|
{
|
|
if (result == NULL)
|
|
/* The memory allocation failed. */
|
|
@@ -633,7 +638,7 @@ _dl_allocate_tls_init (void *result, bool init_tls)
|
|
because it would already be set by the audit setup. However,
|
|
subsequent thread creation would need to follow the default
|
|
behaviour. */
|
|
- if (map->l_ns != LM_ID_BASE && !init_tls)
|
|
+ if (map->l_ns != LM_ID_BASE && main_thread)
|
|
continue;
|
|
memset (__mempcpy (dest, map->l_tls_initimage,
|
|
map->l_tls_initimage_size), '\0',
|
|
@@ -661,7 +666,7 @@ _dl_allocate_tls (void *mem)
|
|
{
|
|
return _dl_allocate_tls_init (mem == NULL
|
|
? _dl_allocate_tls_storage ()
|
|
- : allocate_dtv (mem), true);
|
|
+ : allocate_dtv (mem), false);
|
|
}
|
|
rtld_hidden_def (_dl_allocate_tls)
|
|
|
|
diff --git a/elf/rtld.c b/elf/rtld.c
|
|
index 4b01e9352acd327b..3ca9a11009a74626 100644
|
|
--- a/elf/rtld.c
|
|
+++ b/elf/rtld.c
|
|
@@ -2337,7 +2337,7 @@ dl_main (const ElfW(Phdr) *phdr,
|
|
into the main thread's TLS area, which we allocated above.
|
|
Note: thread-local variables must only be accessed after completing
|
|
the next step. */
|
|
- _dl_allocate_tls_init (tcbp, false);
|
|
+ _dl_allocate_tls_init (tcbp, true);
|
|
|
|
/* And finally install it for the main thread. */
|
|
if (! __rtld_tls_init_tp_called)
|
|
diff --git a/nptl/allocatestack.c b/nptl/allocatestack.c
|
|
index 9ed886573fdc3b7d..d9adb5856cefa533 100644
|
|
--- a/nptl/allocatestack.c
|
|
+++ b/nptl/allocatestack.c
|
|
@@ -141,7 +141,7 @@ get_cached_stack (size_t *sizep, void **memp)
|
|
memset (dtv, '\0', (dtv[-1].counter + 1) * sizeof (dtv_t));
|
|
|
|
/* Re-initialize the TLS. */
|
|
- _dl_allocate_tls_init (TLS_TPADJ (result), true);
|
|
+ _dl_allocate_tls_init (TLS_TPADJ (result), false);
|
|
|
|
return result;
|
|
}
|
|
diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h
|
|
index 656e8a3fa005021d..154efb0e1985e907 100644
|
|
--- a/sysdeps/generic/ldsodefs.h
|
|
+++ b/sysdeps/generic/ldsodefs.h
|
|
@@ -1200,10 +1200,8 @@ extern void _dl_get_tls_static_info (size_t *sizep, size_t *alignp);
|
|
|
|
extern void _dl_allocate_static_tls (struct link_map *map) attribute_hidden;
|
|
|
|
-/* These are internal entry points to the two halves of _dl_allocate_tls,
|
|
- only used within rtld.c itself at startup time. */
|
|
extern void *_dl_allocate_tls_storage (void) attribute_hidden;
|
|
-extern void *_dl_allocate_tls_init (void *, bool);
|
|
+extern void *_dl_allocate_tls_init (void *result, bool main_thread);
|
|
rtld_hidden_proto (_dl_allocate_tls_init)
|
|
|
|
/* True if the TCB has been set up. */
|