From dbc894098e8b6d367e26cc2d112cde2c71d30cc3 Mon Sep 17 00:00:00 2001 From: Carlos O'Donell Date: Thu, 29 Oct 2020 16:18:16 -0400 Subject: [PATCH] Add comments about %post and rpm-ostree. Suggested-by: Colin Walters --- glibc.spec | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/glibc.spec b/glibc.spec index 1b19473..2c84519 100644 --- a/glibc.spec +++ b/glibc.spec @@ -1999,7 +1999,13 @@ end %post -p -- We use lua's posix.exec because there may be no shell that we can --- run during glibc upgrade. +-- run during glibc upgrade. We used to implement much of %%post as a +-- C program, but from an overall maintenance perspective the lua in +-- the spec file was simpler and safer given the operations required. +-- All lua code will be ignored by rpm-ostree; see: +-- https://github.com/projectatomic/rpm-ostree/pull/1869 +-- If we add new lua actions to the %%post code we should coordinate +-- with rpm-ostree and ensure that their glibc install is functional. function post_exec (program, ...) local pid = posix.fork () if pid == 0 then