39 lines
1.5 KiB
Diff
39 lines
1.5 KiB
Diff
|
From 32ed752130bcbccc008819a7f1ea27651c601ee2 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Matthias Clasen <mclasen@redhat.com>
|
||
|
|
Date: Tue, 22 Jan 2019 13:26:31 -0500
|
||
|
|
Subject: [PATCH 9/9] keyfile settings: Use tighter permissions
|
||
|
|
|
||
|
|
When creating directories, create them with 700 permissions,
|
||
|
|
instead of 777.
|
||
|
|
|
||
|
|
Closes: #1658
|
||
|
|
---
|
||
|
|
gio/gkeyfilesettingsbackend.c | 5 +++--
|
||
|
|
1 file changed, 3 insertions(+), 2 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/gio/gkeyfilesettingsbackend.c b/gio/gkeyfilesettingsbackend.c
|
||
|
|
index f5358818e..3d793f5a8 100644
|
||
|
|
--- a/gio/gkeyfilesettingsbackend.c
|
||
|
|
+++ b/gio/gkeyfilesettingsbackend.c
|
||
|
|
@@ -113,7 +113,8 @@ g_keyfile_settings_backend_keyfile_write (GKeyfileSettingsBackend *kfsb)
|
||
|
|
|
||
|
|
contents = g_key_file_to_data (kfsb->keyfile, &length, NULL);
|
||
|
|
g_file_replace_contents (kfsb->file, contents, length, NULL, FALSE,
|
||
|
|
- G_FILE_CREATE_REPLACE_DESTINATION,
|
||
|
|
+ G_FILE_CREATE_REPLACE_DESTINATION |
|
||
|
|
+ G_FILE_CREATE_PRIVATE,
|
||
|
|
NULL, NULL, NULL);
|
||
|
|
|
||
|
|
compute_checksum (kfsb->digest, contents, length);
|
||
|
|
@@ -708,7 +709,7 @@ g_keyfile_settings_backend_constructed (GObject *object)
|
||
|
|
kfsb->permission = g_simple_permission_new (TRUE);
|
||
|
|
|
||
|
|
kfsb->dir = g_file_get_parent (kfsb->file);
|
||
|
|
- g_file_make_directory_with_parents (kfsb->dir, NULL, NULL);
|
||
|
|
+ g_mkdir_with_parents (g_file_peek_path (kfsb->dir), 0700);
|
||
|
|
|
||
|
|
kfsb->file_monitor = g_file_monitor (kfsb->file, G_FILE_MONITOR_NONE, NULL, NULL);
|
||
|
|
kfsb->dir_monitor = g_file_monitor (kfsb->dir, G_FILE_MONITOR_NONE, NULL, NULL);
|
||
|
|
--
|
||
|
|
2.28.0
|