rpms/git
6
0
Fork 0
Code Issues Pull Requests Releases Activity

Disable jgit tests on s390x, they're unreliable

Browse Source 
Specifically, t5512-ls-remote.sh has a test which starts a jgit daemon.
This has failed to exit on a number of occasions, only on s390x.  We
could disable just that test with "GIT_SKIP_TESTS=t5512.28", but the
test number can and does change as more ls-remote tests are added.

Dropping the jgit BuildRequires is cleaner and only causes 3 tests to be
skipped, the offending t5512 test and two others in t5310-pack-bitmaps.

Access to s390x might help better debug this, but it does not occur
consistently and may be limited to koji.  The issue could be a problem
in jgit as well.  While looking at a hung build, Kevin Fenzi found a few
errors in t5512-ls-remote.out:

    /usr/bin/build-classpath: Could not find xz-java Java extension for this JVM
    /usr/bin/build-classpath: error: Some specified jars were not found
This commit is contained in:
Todd Zullinger 2018-05-30 14:22:59 -04:00
parent f179dc950e
commit fd929804e7
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
git.spec
View File

@ -189,7 +189,7 @@ BuildRequires: gnupg
BuildRequires: highlight
%endif
BuildRequires: httpd
%if 0%{?fedora}
%if 0%{?fedora} && %{_arch} != s390x
BuildRequires: jgit
%endif
BuildRequires: mod_dav_svn
@ -899,6 +899,7 @@ make test || ./print-failed-test-output
%changelog
* Wed May 30 2018 Todd Zullinger <tmz@pobox.com> - 2.17.1-3
- Use %%apply_patch for aarch64 zlib patch, return to %%autosetup
- Disable jgit tests on s390x, they're unreliable
* Tue May 29 2018 Todd Zullinger <tmz@pobox.com> - 2.17.1-2
- packfile: Correct zlib buffer handling (#1582555)