rpms/git
6
0
Fork 0
Code Issues Pull Requests Releases Activity

Drop flaky & out-of-place netrc credential helper tests

Browse Source 
The default target in contrib/credential/netrc/Makefile is, and has
always been, test.  Running 'make -C contrib/credential/netrc/' in
%build is not needed.

Additionally, the tests recently were changed and require perl-Git to be
installed before running.  The tests also exit cleanly regardless of any
failures encountered, which makes them unreliable.  A fix for these
issues will be submitted upstream, but rather than apply it here, simply
drop the unneeded 'make' call.

Ideally, the tests will be run in %check once fixed.  This does present
a small wrinkle due to the deletion of contrib/credential in %install.
Cross that bridge when we get there. :)
This commit is contained in:
Todd Zullinger 2018-06-04 23:43:49 -04:00
parent ce668b9d1e
commit 95447ce86a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
git.spec
View File

@ -499,7 +499,6 @@ grep -rlZ '^use Git::LoadCPAN::' | xargs -r0 sed -i 's/Git::LoadCPAN:://g'
%if %{libsecret}
%make_build -C contrib/credential/libsecret/
%endif
make -C contrib/credential/netrc/
%make_build -C contrib/diff-highlight/
@ -873,6 +872,7 @@ make test || ./print-failed-test-output
%changelog
* Mon Jun 04 2018 Todd Zullinger <tmz@pobox.com> - 2.18.0-0.1.rc1
- Update to 2.18.0-rc1
- Drop flaky & out-of-place netrc credential helper tests
* Fri Jun 01 2018 Todd Zullinger <tmz@pobox.com> - 2.18.0-0.0.rc0.1
- add -p: fix counting empty context lines in edited patches