From 6f880575854be2fa9476830688ead4f23f15ceef Mon Sep 17 00:00:00 2001 From: Todd Zullinger Date: Tue, 27 Mar 2018 12:28:18 -0400 Subject: [PATCH] Add missing perl(Mail::Address) requirement (#1561086) When setting NO_PERL_CPAN_FALLBACKS to avoid bundled perl modules, we must take care to ensure the dependencies are required. The code which handles modules via Git::LoadCPAN prevents the normal perl dependency generator from identifying them. Thankfully, there should not be many modules loaded this way. Prior to 2.17.0 and NO_PERL_CPAN_FALLBACKS we were falling back to not using Mail::Address, which is partly why the lack of the dependency wasn't spotted with rpmdiff with and without NO_PERL_CPAN_FALLBACKS. --- git.spec | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/git.spec b/git.spec index 4b1d88b..dcfcd69 100644 --- a/git.spec +++ b/git.spec @@ -60,7 +60,7 @@ Name: git Version: 2.17.0 -Release: 0.1%{?rcrev}%{?dist}.1 +Release: 0.1%{?rcrev}%{?dist}.2 Summary: Fast Version Control System License: GPLv2 URL: https://git-scm.com/ @@ -271,6 +271,7 @@ Summary: Git tools for sending patches via email BuildArch: noarch Requires: git = %{version}-%{release}, perl-Git = %{version}-%{release} Requires: perl(Authen::SASL) +Requires: perl(Mail::Address) Requires: perl(Net::SMTP::SSL) Requires: perl(Git) %description email @@ -811,6 +812,9 @@ make test || ./print-failed-test-output %{?with_docs:%{_pkgdocdir}/*svn*.html} %changelog +* Tue Mar 27 2018 Todd Zullinger - 2.17.0-0.1.rc1.2 +- Add missing perl(Mail::Address) requirement (#1561086) + * Thu Mar 22 2018 Todd Zullinger - 2.17.0-0.1.rc1.1 - Drop .py extension from contrib/hooks/multimail/git_multimail.py - Remove unnecessary "chmod +x contrib/hooks/*"