771 lines
27 KiB
Diff
771 lines
27 KiB
Diff
|
From 13b0a36f8181db66a91bcc8cea139998b53a8996 Mon Sep 17 00:00:00 2001
|
||
|
From: Chris Liddell <chris.liddell@artifex.com>
|
||
|
Date: Wed, 5 Dec 2018 12:22:13 +0000
|
||
|
Subject: [PATCH 1/4] Sanitize op stack for error conditions
|
||
|
|
||
|
We save the stacks to an array and store the array for the error handler to
|
||
|
access.
|
||
|
|
||
|
For SAFER, we traverse the array, and deep copy any op arrays (procedures). As
|
||
|
we make these copies, we check for operators that do *not* exist in systemdict,
|
||
|
when we find one, we replace the operator with a name object (of the form
|
||
|
"/--opname--").
|
||
|
---
|
||
|
psi/int.mak | 3 +-
|
||
|
psi/interp.c | 8 ++++++
|
||
|
psi/istack.c | 78 ++++++++++++++++++++++++++++++++++++++++++++++++++++
|
||
|
psi/istack.h | 3 ++
|
||
|
4 files changed, 91 insertions(+), 1 deletion(-)
|
||
|
|
||
|
diff --git a/psi/int.mak b/psi/int.mak
|
||
|
index 6ab5bf0..6b349cb 100644
|
||
|
--- a/psi/int.mak
|
||
|
+++ b/psi/int.mak
|
||
|
@@ -204,7 +204,8 @@ $(PSOBJ)iparam.$(OBJ) : $(PSSRC)iparam.c $(GH)\
|
||
|
$(PSOBJ)istack.$(OBJ) : $(PSSRC)istack.c $(GH) $(memory__h)\
|
||
|
$(ierrors_h) $(gsstruct_h) $(gsutil_h)\
|
||
|
$(ialloc_h) $(istack_h) $(istkparm_h) $(istruct_h) $(iutil_h) $(ivmspace_h)\
|
||
|
- $(store_h) $(INT_MAK) $(MAKEDIRS)
|
||
|
+ $(store_h) $(icstate_h) $(iname_h) $(dstack_h) $(idict_h) \
|
||
|
+ $(INT_MAK) $(MAKEDIRS)
|
||
|
$(PSCC) $(PSO_)istack.$(OBJ) $(C_) $(PSSRC)istack.c
|
||
|
|
||
|
$(PSOBJ)iutil.$(OBJ) : $(PSSRC)iutil.c $(GH) $(math__h) $(memory__h) $(string__h)\
|
||
|
diff --git a/psi/interp.c b/psi/interp.c
|
||
|
index 6dc0dda..aa5779c 100644
|
||
|
--- a/psi/interp.c
|
||
|
+++ b/psi/interp.c
|
||
|
@@ -761,6 +761,7 @@ copy_stack(i_ctx_t *i_ctx_p, const ref_stack_t * pstack, int skip, ref * arr)
|
||
|
uint size = ref_stack_count(pstack) - skip;
|
||
|
uint save_space = ialloc_space(idmemory);
|
||
|
int code, i;
|
||
|
+ ref *safety, *safe;
|
||
|
|
||
|
if (size > 65535)
|
||
|
size = 65535;
|
||
|
@@ -778,6 +779,13 @@ copy_stack(i_ctx_t *i_ctx_p, const ref_stack_t * pstack, int skip, ref * arr)
|
||
|
make_null(&arr->value.refs[i]);
|
||
|
}
|
||
|
}
|
||
|
+ if (pstack == &o_stack && dict_find_string(systemdict, "SAFETY", &safety) > 0 &&
|
||
|
+ dict_find_string(safety, "safe", &safe) > 0 && r_has_type(safe, t_boolean) &&
|
||
|
+ safe->value.boolval == true) {
|
||
|
+ code = ref_stack_array_sanitize(i_ctx_p, arr, arr);
|
||
|
+ if (code < 0)
|
||
|
+ return code;
|
||
|
+ }
|
||
|
ialloc_set_space(idmemory, save_space);
|
||
|
return code;
|
||
|
}
|
||
|
diff --git a/psi/istack.c b/psi/istack.c
|
||
|
index 8fe151f..f1a3e51 100644
|
||
|
--- a/psi/istack.c
|
||
|
+++ b/psi/istack.c
|
||
|
@@ -27,6 +27,10 @@
|
||
|
#include "iutil.h"
|
||
|
#include "ivmspace.h" /* for local/global test */
|
||
|
#include "store.h"
|
||
|
+#include "icstate.h"
|
||
|
+#include "iname.h"
|
||
|
+#include "dstack.h"
|
||
|
+#include "idict.h"
|
||
|
|
||
|
/* Forward references */
|
||
|
static void init_block(ref_stack_t *pstack, const ref *pblock_array,
|
||
|
@@ -294,6 +298,80 @@ ref_stack_store_check(const ref_stack_t *pstack, ref *parray, uint count,
|
||
|
return 0;
|
||
|
}
|
||
|
|
||
|
+int
|
||
|
+ref_stack_array_sanitize(i_ctx_t *i_ctx_p, ref *sarr, ref *darr)
|
||
|
+{
|
||
|
+ int i, code;
|
||
|
+ ref obj, arr2;
|
||
|
+ ref *pobj2;
|
||
|
+ gs_memory_t *mem = (gs_memory_t *)idmemory->current;
|
||
|
+
|
||
|
+ if (!r_is_array(sarr) || !r_has_type(darr, t_array))
|
||
|
+ return_error(gs_error_typecheck);
|
||
|
+
|
||
|
+ for (i = 0; i < r_size(sarr); i++) {
|
||
|
+ code = array_get(mem, sarr, i, &obj);
|
||
|
+ if (code < 0)
|
||
|
+ make_null(&obj);
|
||
|
+ switch(r_type(&obj)) {
|
||
|
+ case t_operator:
|
||
|
+ {
|
||
|
+ int index = op_index(&obj);
|
||
|
+
|
||
|
+ if (index > 0 && index < op_def_count) {
|
||
|
+ const byte *data = (const byte *)(op_index_def(index)->oname + 1);
|
||
|
+ if (dict_find_string(systemdict, (const char *)data, &pobj2) <= 0) {
|
||
|
+ byte *s = gs_alloc_bytes(mem, strlen((char *)data) + 5, "ref_stack_array_sanitize");
|
||
|
+ if (s) {
|
||
|
+ s[0] = '\0';
|
||
|
+ strcpy((char *)s, "--");
|
||
|
+ strcpy((char *)s + 2, (char *)data);
|
||
|
+ strcpy((char *)s + strlen((char *)data) + 2, "--");
|
||
|
+ }
|
||
|
+ else {
|
||
|
+ s = (byte *)data;
|
||
|
+ }
|
||
|
+ code = name_ref(imemory, s, strlen((char *)s), &obj, 1);
|
||
|
+ if (code < 0) make_null(&obj);
|
||
|
+ if (s != data)
|
||
|
+ gs_free_object(mem, s, "ref_stack_array_sanitize");
|
||
|
+ }
|
||
|
+ }
|
||
|
+ else {
|
||
|
+ make_null(&obj);
|
||
|
+ }
|
||
|
+ ref_assign(darr->value.refs + i, &obj);
|
||
|
+ break;
|
||
|
+ }
|
||
|
+ case t_array:
|
||
|
+ case t_shortarray:
|
||
|
+ case t_mixedarray:
|
||
|
+ {
|
||
|
+ int attrs = r_type_attrs(&obj) & (a_write | a_read | a_execute | a_executable);
|
||
|
+ /* We only want to copy executable arrays */
|
||
|
+ if (attrs & (a_execute | a_executable)) {
|
||
|
+ code = ialloc_ref_array(&arr2, attrs, r_size(&obj), "ref_stack_array_sanitize");
|
||
|
+ if (code < 0) {
|
||
|
+ make_null(&arr2);
|
||
|
+ }
|
||
|
+ else {
|
||
|
+ code = ref_stack_array_sanitize(i_ctx_p, &obj, &arr2);
|
||
|
+ }
|
||
|
+ ref_assign(darr->value.refs + i, &arr2);
|
||
|
+ }
|
||
|
+ else {
|
||
|
+ ref_assign(darr->value.refs + i, &obj);
|
||
|
+ }
|
||
|
+ break;
|
||
|
+ }
|
||
|
+ default:
|
||
|
+ ref_assign(darr->value.refs + i, &obj);
|
||
|
+ }
|
||
|
+ }
|
||
|
+ return 0;
|
||
|
+}
|
||
|
+
|
||
|
+
|
||
|
/*
|
||
|
* Store the top 'count' elements of a stack, starting 'skip' elements below
|
||
|
* the top, into an array, with or without store/undo checking. age=-1 for
|
||
|
diff --git a/psi/istack.h b/psi/istack.h
|
||
|
index 051dcbe..54be405 100644
|
||
|
--- a/psi/istack.h
|
||
|
+++ b/psi/istack.h
|
||
|
@@ -129,6 +129,9 @@ int ref_stack_store(const ref_stack_t *pstack, ref *parray, uint count,
|
||
|
uint skip, int age, bool check,
|
||
|
gs_dual_memory_t *idmem, client_name_t cname);
|
||
|
|
||
|
+int
|
||
|
+ref_stack_array_sanitize(i_ctx_t *i_ctx_p, ref *sarr, ref *darr);
|
||
|
+
|
||
|
/*
|
||
|
* Pop the top N elements off a stack.
|
||
|
* The number must not exceed the number of elements in use.
|
||
|
--
|
||
|
2.20.1
|
||
|
|
||
|
|
||
|
From 2db98f9c66135601efb103d8db7d020a672308db Mon Sep 17 00:00:00 2001
|
||
|
From: Chris Liddell <chris.liddell@artifex.com>
|
||
|
Date: Thu, 13 Dec 2018 15:28:34 +0000
|
||
|
Subject: [PATCH 2/4] Any transient procedures that call .force* operators
|
||
|
|
||
|
(i.e. for conditionals or loops) make them executeonly.
|
||
|
---
|
||
|
Resource/Init/gs_diskn.ps | 2 +-
|
||
|
Resource/Init/gs_dps1.ps | 4 ++--
|
||
|
Resource/Init/gs_fntem.ps | 4 ++--
|
||
|
Resource/Init/gs_fonts.ps | 12 ++++++------
|
||
|
Resource/Init/gs_init.ps | 4 ++--
|
||
|
Resource/Init/gs_lev2.ps | 11 ++++++-----
|
||
|
Resource/Init/gs_pdfwr.ps | 2 +-
|
||
|
Resource/Init/gs_res.ps | 4 ++--
|
||
|
Resource/Init/gs_setpd.ps | 2 +-
|
||
|
Resource/Init/pdf_base.ps | 13 ++++++++-----
|
||
|
Resource/Init/pdf_draw.ps | 16 +++++++++-------
|
||
|
Resource/Init/pdf_font.ps | 6 +++---
|
||
|
Resource/Init/pdf_main.ps | 4 ++--
|
||
|
Resource/Init/pdf_ops.ps | 7 ++++---
|
||
|
14 files changed, 49 insertions(+), 42 deletions(-)
|
||
|
|
||
|
diff --git a/Resource/Init/gs_diskn.ps b/Resource/Init/gs_diskn.ps
|
||
|
index fd694bc..8bf2054 100644
|
||
|
--- a/Resource/Init/gs_diskn.ps
|
||
|
+++ b/Resource/Init/gs_diskn.ps
|
||
|
@@ -51,7 +51,7 @@ systemdict begin
|
||
|
mark 5 1 roll ] mark exch { { } forall } forall ]
|
||
|
//systemdict /.searchabledevs 2 index .forceput
|
||
|
exch .setglobal
|
||
|
- }
|
||
|
+ } executeonly
|
||
|
if
|
||
|
} .bind executeonly odef % must be bound and hidden for .forceput
|
||
|
|
||
|
diff --git a/Resource/Init/gs_dps1.ps b/Resource/Init/gs_dps1.ps
|
||
|
index ec5db61..4fae283 100644
|
||
|
--- a/Resource/Init/gs_dps1.ps
|
||
|
+++ b/Resource/Init/gs_dps1.ps
|
||
|
@@ -78,7 +78,7 @@ level2dict begin
|
||
|
.currentglobal
|
||
|
{ % Current mode is global; delete from local directory too.
|
||
|
//systemdict /LocalFontDirectory .knownget
|
||
|
- { 1 index .forceundef } % LocalFontDirectory is readonly
|
||
|
+ { 1 index .forceundef } executeonly % LocalFontDirectory is readonly
|
||
|
if
|
||
|
}
|
||
|
{ % Current mode is local; if there was a shadowed global
|
||
|
@@ -126,7 +126,7 @@ level2dict begin
|
||
|
}
|
||
|
ifelse
|
||
|
} forall
|
||
|
- pop counttomark 2 idiv { .forceundef } repeat pop % readonly
|
||
|
+ pop counttomark 2 idiv { .forceundef } executeonly repeat pop % readonly
|
||
|
}
|
||
|
if
|
||
|
//SharedFontDirectory exch .forcecopynew pop
|
||
|
diff --git a/Resource/Init/gs_fntem.ps b/Resource/Init/gs_fntem.ps
|
||
|
index c1f7651..6eb672a 100644
|
||
|
--- a/Resource/Init/gs_fntem.ps
|
||
|
+++ b/Resource/Init/gs_fntem.ps
|
||
|
@@ -401,12 +401,12 @@ currentdict end def
|
||
|
.forceput % FontInfo can be read-only.
|
||
|
pop % bool <font>
|
||
|
exit
|
||
|
- } if
|
||
|
+ } executeonly if
|
||
|
dup /FontInfo get % bool <font> <FI>
|
||
|
/GlyphNames2Unicode /Unicode /Decoding findresource
|
||
|
.forceput % FontInfo can be read-only.
|
||
|
exit
|
||
|
- } loop
|
||
|
+ } executeonly loop
|
||
|
exch setglobal
|
||
|
} .bind executeonly odef % must be bound and hidden for .forceput
|
||
|
|
||
|
diff --git a/Resource/Init/gs_fonts.ps b/Resource/Init/gs_fonts.ps
|
||
|
index 803faca..290da0c 100644
|
||
|
--- a/Resource/Init/gs_fonts.ps
|
||
|
+++ b/Resource/Init/gs_fonts.ps
|
||
|
@@ -374,7 +374,7 @@ FONTPATH length 0 eq { (%END FONTPATH) .skipeof } if
|
||
|
/.setnativefontmapbuilt { % set whether we've been run
|
||
|
dup type /booleantype eq {
|
||
|
systemdict exch /.nativefontmapbuilt exch .forceput
|
||
|
- }
|
||
|
+ } executeonly
|
||
|
{pop}
|
||
|
ifelse
|
||
|
} .bind executeonly odef
|
||
|
@@ -1007,11 +1007,11 @@ $error /SubstituteFont { } put
|
||
|
{ 2 index gcheck currentglobal
|
||
|
2 copy eq {
|
||
|
pop pop .forceput
|
||
|
- } {
|
||
|
+ } executeonly {
|
||
|
5 1 roll setglobal
|
||
|
dup length string copy
|
||
|
.forceput setglobal
|
||
|
- } ifelse
|
||
|
+ } executeonly ifelse
|
||
|
} .bind executeonly odef % must be bound and hidden for .forceput
|
||
|
|
||
|
% Attempt to load a font from a file.
|
||
|
@@ -1084,7 +1084,7 @@ $error /SubstituteFont { } put
|
||
|
.FontDirectory 3 index .forceundef % readonly
|
||
|
1 index (r) file .loadfont .FontDirectory exch
|
||
|
/.setglobal .systemvar exec
|
||
|
- }
|
||
|
+ } executeonly
|
||
|
{ .loadfont .FontDirectory
|
||
|
}
|
||
|
ifelse
|
||
|
@@ -1105,7 +1105,7 @@ $error /SubstituteFont { } put
|
||
|
dup 3 index .fontknownget
|
||
|
{ dup /PathLoad 4 index .putgstringcopy
|
||
|
4 1 roll pop pop pop //true exit
|
||
|
- } if
|
||
|
+ } executeonly if
|
||
|
|
||
|
% Maybe the file had a different FontName.
|
||
|
% See if we can get a FontName from the file, and if so,
|
||
|
@@ -1134,7 +1134,7 @@ $error /SubstituteFont { } put
|
||
|
ifelse % Stack: origfontname fontdict
|
||
|
exch pop //true exit
|
||
|
% Stack: fontdict
|
||
|
- }
|
||
|
+ } executeonly
|
||
|
if pop % Stack: origfontname fontdirectory path
|
||
|
}
|
||
|
if pop pop % Stack: origfontname
|
||
|
diff --git a/Resource/Init/gs_init.ps b/Resource/Init/gs_init.ps
|
||
|
index d733124..56c0bd2 100644
|
||
|
--- a/Resource/Init/gs_init.ps
|
||
|
+++ b/Resource/Init/gs_init.ps
|
||
|
@@ -2357,7 +2357,7 @@ SAFER { .setsafeglobal } if
|
||
|
% Update the copy of the user parameters.
|
||
|
mark .currentuserparams counttomark 2 idiv {
|
||
|
userparams 3 1 roll .forceput % userparams is read-only
|
||
|
- } repeat pop
|
||
|
+ } executeonly repeat pop
|
||
|
% Turn on idiom recognition, if available.
|
||
|
currentuserparams /IdiomRecognition known {
|
||
|
/IdiomRecognition //true .definepsuserparam
|
||
|
@@ -2376,7 +2376,7 @@ SAFER { .setsafeglobal } if
|
||
|
% Remove real system params from pssystemparams.
|
||
|
mark .currentsystemparams counttomark 2 idiv {
|
||
|
pop pssystemparams exch .forceundef
|
||
|
- } repeat pop
|
||
|
+ } executeonly repeat pop
|
||
|
} if
|
||
|
|
||
|
% Set up AlignToPixels :
|
||
|
diff --git a/Resource/Init/gs_lev2.ps b/Resource/Init/gs_lev2.ps
|
||
|
index 44fe619..0f0d573 100644
|
||
|
--- a/Resource/Init/gs_lev2.ps
|
||
|
+++ b/Resource/Init/gs_lev2.ps
|
||
|
@@ -154,7 +154,8 @@ end
|
||
|
% protect top level of parameters that we copied
|
||
|
dup type dup /arraytype eq exch /stringtype eq or { readonly } if
|
||
|
/userparams .systemvar 3 1 roll .forceput % userparams is read-only
|
||
|
- } {
|
||
|
+ } executeonly
|
||
|
+ {
|
||
|
pop pop
|
||
|
} ifelse
|
||
|
} forall
|
||
|
@@ -224,7 +225,7 @@ end
|
||
|
% protect top level parameters that we copied
|
||
|
dup type dup /arraytype eq exch /stringtype eq or { readonly } if
|
||
|
//pssystemparams 3 1 roll .forceput % pssystemparams is read-only
|
||
|
- }
|
||
|
+ } executeonly
|
||
|
{ pop pop
|
||
|
}
|
||
|
ifelse
|
||
|
@@ -934,7 +935,7 @@ mark
|
||
|
dup /PaintProc get
|
||
|
1 index /Implementation known not {
|
||
|
1 index dup /Implementation //null .forceput readonly pop
|
||
|
- } if
|
||
|
+ } executeonly if
|
||
|
exec
|
||
|
}.bind odef
|
||
|
|
||
|
@@ -958,7 +959,7 @@ mark
|
||
|
dup /PaintProc get
|
||
|
1 index /Implementation known not {
|
||
|
1 index dup /Implementation //null .forceput readonly pop
|
||
|
- } if
|
||
|
+ } executeonly if
|
||
|
/UNROLLFORMS where {/UNROLLFORMS get}{false}ifelse not
|
||
|
%% [CTM] <<Form>> PaintProc .beginform -
|
||
|
{
|
||
|
@@ -1005,7 +1006,7 @@ mark
|
||
|
%% Form dictioanry using the /Implementation key).
|
||
|
1 dict dup /FormID 4 -1 roll put
|
||
|
1 index exch /Implementation exch .forceput readonly pop
|
||
|
- }
|
||
|
+ } executeonly
|
||
|
ifelse
|
||
|
}
|
||
|
{
|
||
|
diff --git a/Resource/Init/gs_pdfwr.ps b/Resource/Init/gs_pdfwr.ps
|
||
|
index 58e75d3..b425103 100644
|
||
|
--- a/Resource/Init/gs_pdfwr.ps
|
||
|
+++ b/Resource/Init/gs_pdfwr.ps
|
||
|
@@ -650,7 +650,7 @@ currentdict /.pdfmarkparams .undef
|
||
|
} ifelse
|
||
|
} bind .makeoperator .forceput
|
||
|
systemdict /.pdf_hooked_DSC_Creator //true .forceput
|
||
|
- } if
|
||
|
+ } executeonly if
|
||
|
pop
|
||
|
} if
|
||
|
} {
|
||
|
diff --git a/Resource/Init/gs_res.ps b/Resource/Init/gs_res.ps
|
||
|
index 8eb8bb0..d9b3459 100644
|
||
|
--- a/Resource/Init/gs_res.ps
|
||
|
+++ b/Resource/Init/gs_res.ps
|
||
|
@@ -152,7 +152,7 @@ setglobal
|
||
|
% use .forceput / .forcedef later to replace the dummy,
|
||
|
% empty .Instances dictionary with the real one later.
|
||
|
readonly
|
||
|
- } {
|
||
|
+ }{
|
||
|
/defineresource cvx /typecheck signaloperror
|
||
|
} ifelse
|
||
|
} bind executeonly odef
|
||
|
@@ -424,7 +424,7 @@ status {
|
||
|
% As noted above, Category dictionaries are read-only,
|
||
|
% so we have to use .forcedef here.
|
||
|
/.Instances 1 index .forcedef % Category dict is read-only
|
||
|
- } if
|
||
|
+ } executeonly if
|
||
|
}
|
||
|
{ .LocalInstances dup //.emptydict eq
|
||
|
{ pop 3 dict localinstancedict Category 2 index put
|
||
|
diff --git a/Resource/Init/gs_setpd.ps b/Resource/Init/gs_setpd.ps
|
||
|
index e22597e..7875d1f 100644
|
||
|
--- a/Resource/Init/gs_setpd.ps
|
||
|
+++ b/Resource/Init/gs_setpd.ps
|
||
|
@@ -634,7 +634,7 @@ NOMEDIAATTRS {
|
||
|
SETPDDEBUG { (Rolling back.) = pstack flush } if
|
||
|
3 index 2 index 3 -1 roll .forceput
|
||
|
4 index 1 index .knownget
|
||
|
- { 4 index 3 1 roll .forceput }
|
||
|
+ { 4 index 3 1 roll .forceput } executeonly
|
||
|
{ 3 index exch .undef }
|
||
|
ifelse
|
||
|
} bind executeonly odef
|
||
|
diff --git a/Resource/Init/pdf_base.ps b/Resource/Init/pdf_base.ps
|
||
|
index b45e980..7312729 100644
|
||
|
--- a/Resource/Init/pdf_base.ps
|
||
|
+++ b/Resource/Init/pdf_base.ps
|
||
|
@@ -130,26 +130,29 @@ currentdict /num-chars-dict .undef
|
||
|
|
||
|
/.pdfexectoken { % <count> <opdict> <exectoken> .pdfexectoken ?
|
||
|
PDFDEBUG {
|
||
|
- pdfdict /PDFSTEPcount known not { pdfdict /PDFSTEPcount 1 .forceput } if
|
||
|
+ pdfdict /PDFSTEPcount known not { pdfdict /PDFSTEPcount 1 .forceput } executeonly if
|
||
|
PDFSTEP {
|
||
|
pdfdict /PDFtokencount 2 copy .knownget { 1 add } { 1 } ifelse .forceput
|
||
|
PDFSTEPcount 1 gt {
|
||
|
pdfdict /PDFSTEPcount PDFSTEPcount 1 sub .forceput
|
||
|
- } {
|
||
|
+ } executeonly
|
||
|
+ {
|
||
|
dup ==only
|
||
|
( step # ) print PDFtokencount =only
|
||
|
( ? ) print flush 1 //false .outputpage
|
||
|
(%stdin) (r) file 255 string readline {
|
||
|
token {
|
||
|
exch pop pdfdict /PDFSTEPcount 3 -1 roll .forceput
|
||
|
- } {
|
||
|
+ } executeonly
|
||
|
+ {
|
||
|
pdfdict /PDFSTEPcount 1 .forceput
|
||
|
- } ifelse % token
|
||
|
+ } executeonly ifelse % token
|
||
|
} {
|
||
|
pop /PDFSTEP //false def % EOF on stdin
|
||
|
} ifelse % readline
|
||
|
} ifelse % PDFSTEPcount > 1
|
||
|
- } {
|
||
|
+ } executeonly
|
||
|
+ {
|
||
|
dup ==only () = flush
|
||
|
} ifelse % PDFSTEP
|
||
|
} if % PDFDEBUG
|
||
|
diff --git a/Resource/Init/pdf_draw.ps b/Resource/Init/pdf_draw.ps
|
||
|
index 6b0ba93..40c6ac8 100644
|
||
|
--- a/Resource/Init/pdf_draw.ps
|
||
|
+++ b/Resource/Init/pdf_draw.ps
|
||
|
@@ -1118,14 +1118,14 @@ currentdict end readonly def
|
||
|
pdfdict /.Qqwarning_issued //true .forceput
|
||
|
.setglobal
|
||
|
pdfformaterror
|
||
|
- } ifelse
|
||
|
+ } executeonly ifelse
|
||
|
}
|
||
|
{
|
||
|
currentglobal pdfdict gcheck .setglobal
|
||
|
pdfdict /.Qqwarning_issued //true .forceput
|
||
|
.setglobal
|
||
|
pdfformaterror
|
||
|
- } ifelse
|
||
|
+ } executeonly ifelse
|
||
|
end
|
||
|
} ifelse
|
||
|
} loop
|
||
|
@@ -1141,14 +1141,14 @@ currentdict end readonly def
|
||
|
pdfdict /.Qqwarning_issued //true .forceput
|
||
|
.setglobal
|
||
|
pdfformaterror
|
||
|
- } ifelse
|
||
|
+ } executeonly ifelse
|
||
|
}
|
||
|
{
|
||
|
currentglobal pdfdict gcheck .setglobal
|
||
|
pdfdict /.Qqwarning_issued //true .forceput
|
||
|
.setglobal
|
||
|
pdfformaterror
|
||
|
- } ifelse
|
||
|
+ } executeonly ifelse
|
||
|
} if
|
||
|
pop
|
||
|
|
||
|
@@ -2350,9 +2350,10 @@ currentdict /last-ditch-bpc-csp undef
|
||
|
/IncrementAppearanceNumber {
|
||
|
pdfdict /AppearanceNumber .knownget {
|
||
|
1 add pdfdict /AppearanceNumber 3 -1 roll .forceput
|
||
|
- }{
|
||
|
+ } executeonly
|
||
|
+ {
|
||
|
pdfdict /AppearanceNumber 0 .forceput
|
||
|
- } ifelse
|
||
|
+ } executeonly ifelse
|
||
|
}bind executeonly odef
|
||
|
|
||
|
/MakeAppearanceName {
|
||
|
@@ -2510,7 +2511,8 @@ currentdict /last-ditch-bpc-csp undef
|
||
|
%% want to preserve it.
|
||
|
pdfdict /.PreservePDFForm false .forceput
|
||
|
/q cvx /execform cvx 5 -2 roll
|
||
|
- }{
|
||
|
+ } executeonly
|
||
|
+ {
|
||
|
/q cvx /PDFexecform cvx 5 -2 roll
|
||
|
} ifelse
|
||
|
|
||
|
diff --git a/Resource/Init/pdf_font.ps b/Resource/Init/pdf_font.ps
|
||
|
index bea9ea9..4cd62b9 100644
|
||
|
--- a/Resource/Init/pdf_font.ps
|
||
|
+++ b/Resource/Init/pdf_font.ps
|
||
|
@@ -714,7 +714,7 @@ currentdict end readonly def
|
||
|
pop pop pop
|
||
|
currentdict /.stackdepth .forceundef
|
||
|
currentdict /.dstackdepth .forceundef
|
||
|
- }
|
||
|
+ } executeonly
|
||
|
{pop pop pop}
|
||
|
ifelse
|
||
|
|
||
|
@@ -1232,7 +1232,7 @@ currentdict /eexec_pdf_param_dict .undef
|
||
|
(\n **** Warning: Type 3 glyph has unbalanced q/Q operators \(too many q's\)\n Output may be incorrect.\n)
|
||
|
pdfformatwarning
|
||
|
pdfdict /.Qqwarning_issued //true .forceput
|
||
|
- } if
|
||
|
+ } executeonly if
|
||
|
Q
|
||
|
} repeat
|
||
|
Q
|
||
|
@@ -2016,7 +2016,7 @@ currentdict /CMap_read_dict undef
|
||
|
/CIDFallBack /CIDFont findresource
|
||
|
} if
|
||
|
exit
|
||
|
- } if
|
||
|
+ } executeonly if
|
||
|
} if
|
||
|
} if
|
||
|
|
||
|
diff --git a/Resource/Init/pdf_main.ps b/Resource/Init/pdf_main.ps
|
||
|
index 00da47a..37e69b3 100644
|
||
|
--- a/Resource/Init/pdf_main.ps
|
||
|
+++ b/Resource/Init/pdf_main.ps
|
||
|
@@ -2701,14 +2701,14 @@ currentdict /PDF2PS_matrix_key undef
|
||
|
pdfdict /.Qqwarning_issued //true .forceput
|
||
|
.setglobal
|
||
|
pdfformaterror
|
||
|
- } ifelse
|
||
|
+ } executeonly ifelse
|
||
|
}
|
||
|
{
|
||
|
currentglobal pdfdict gcheck .setglobal
|
||
|
pdfdict /.Qqwarning_issued //true .forceput
|
||
|
.setglobal
|
||
|
pdfformaterror
|
||
|
- } ifelse
|
||
|
+ } executeonly ifelse
|
||
|
} if
|
||
|
} if
|
||
|
pop
|
||
|
diff --git a/Resource/Init/pdf_ops.ps b/Resource/Init/pdf_ops.ps
|
||
|
index 8672d61..aa09641 100644
|
||
|
--- a/Resource/Init/pdf_ops.ps
|
||
|
+++ b/Resource/Init/pdf_ops.ps
|
||
|
@@ -184,14 +184,14 @@ currentdict /gput_always_allow .undef
|
||
|
pdfdict /.Qqwarning_issued //true .forceput
|
||
|
.setglobal
|
||
|
pdfformaterror
|
||
|
- } ifelse
|
||
|
+ } executeonly ifelse
|
||
|
}
|
||
|
{
|
||
|
currentglobal pdfdict gcheck .setglobal
|
||
|
pdfdict /.Qqwarning_issued //true .forceput
|
||
|
.setglobal
|
||
|
pdfformaterror
|
||
|
- } ifelse
|
||
|
+ } executeonly ifelse
|
||
|
} if
|
||
|
} bind executeonly odef
|
||
|
|
||
|
@@ -439,7 +439,8 @@ currentdict /gput_always_allow .undef
|
||
|
dup type /booleantype eq {
|
||
|
.currentSMask type /dicttype eq {
|
||
|
.currentSMask /Processed 2 index .forceput
|
||
|
- } {
|
||
|
+ } executeonly
|
||
|
+ {
|
||
|
.setSMask
|
||
|
}ifelse
|
||
|
}{
|
||
|
--
|
||
|
2.20.1
|
||
|
|
||
|
|
||
|
From 99f13091a3f309bdc95d275ea9fec10bb9f42d9a Mon Sep 17 00:00:00 2001
|
||
|
From: Chris Liddell <chris.liddell@artifex.com>
|
||
|
Date: Sat, 15 Dec 2018 09:08:32 +0000
|
||
|
Subject: [PATCH 3/4] Bug700317: Fix logic for an older change
|
||
|
|
||
|
Unlike almost every other function in gs, dict_find_string() returns 1 on
|
||
|
success 0 or <0 on failure. The logic for this case was wrong.
|
||
|
---
|
||
|
psi/interp.c | 2 +-
|
||
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
||
|
diff --git a/psi/interp.c b/psi/interp.c
|
||
|
index aa5779c..f6c45bb 100644
|
||
|
--- a/psi/interp.c
|
||
|
+++ b/psi/interp.c
|
||
|
@@ -703,7 +703,7 @@ again:
|
||
|
* i.e. it's an internal operator we have hidden
|
||
|
*/
|
||
|
code = dict_find_string(systemdict, (const char *)bufptr, &tobj);
|
||
|
- if (code < 0) {
|
||
|
+ if (code <= 0) {
|
||
|
buf[0] = buf[1] = buf[rlen + 2] = buf[rlen + 3] = '-';
|
||
|
rlen += 4;
|
||
|
bufptr = buf;
|
||
|
--
|
||
|
2.20.1
|
||
|
|
||
|
|
||
|
From 59d8f4deef90c1598ff50616519d5576756b4495 Mon Sep 17 00:00:00 2001
|
||
|
From: Chris Liddell <chris.liddell@artifex.com>
|
||
|
Date: Tue, 18 Dec 2018 10:42:10 +0000
|
||
|
Subject: [PATCH 4/4] Harden some uses of .force* operators
|
||
|
|
||
|
by adding a few immediate evalutions
|
||
|
---
|
||
|
Resource/Init/gs_dps1.ps | 4 ++--
|
||
|
Resource/Init/gs_fonts.ps | 20 ++++++++++----------
|
||
|
Resource/Init/gs_init.ps | 6 +++---
|
||
|
3 files changed, 15 insertions(+), 15 deletions(-)
|
||
|
|
||
|
diff --git a/Resource/Init/gs_dps1.ps b/Resource/Init/gs_dps1.ps
|
||
|
index 4fae283..b75ea14 100644
|
||
|
--- a/Resource/Init/gs_dps1.ps
|
||
|
+++ b/Resource/Init/gs_dps1.ps
|
||
|
@@ -74,7 +74,7 @@ level2dict begin
|
||
|
} odef
|
||
|
% undefinefont has to take local/global VM into account.
|
||
|
/undefinefont % <fontname> undefinefont -
|
||
|
- { .FontDirectory 1 .argindex .forceundef % FontDirectory is readonly
|
||
|
+ { //.FontDirectory 1 .argindex .forceundef % FontDirectory is readonly
|
||
|
.currentglobal
|
||
|
{ % Current mode is global; delete from local directory too.
|
||
|
//systemdict /LocalFontDirectory .knownget
|
||
|
@@ -85,7 +85,7 @@ level2dict begin
|
||
|
% definition, copy it into the local directory.
|
||
|
//systemdict /SharedFontDirectory .knownget
|
||
|
{ 1 index .knownget
|
||
|
- { .FontDirectory 2 index 3 -1 roll { put } systemdict /superexec known {//superexec}{1183615869 internaldict /superexec get exec} ifelse } % readonly
|
||
|
+ { //.FontDirectory 2 index 3 -1 roll { put } systemdict /superexec known {//superexec}{1183615869 internaldict /superexec get exec} ifelse } % readonly
|
||
|
if
|
||
|
}
|
||
|
if
|
||
|
diff --git a/Resource/Init/gs_fonts.ps b/Resource/Init/gs_fonts.ps
|
||
|
index 290da0c..c13a2fc 100644
|
||
|
--- a/Resource/Init/gs_fonts.ps
|
||
|
+++ b/Resource/Init/gs_fonts.ps
|
||
|
@@ -516,7 +516,7 @@ buildfontdict 3 /.buildfont3 cvx put
|
||
|
if
|
||
|
}
|
||
|
if
|
||
|
- dup .FontDirectory 4 -2 roll { .growput } systemdict /superexec known {//superexec}{1183615869 internaldict /superexec get exec} ifelse % readonly
|
||
|
+ dup //.FontDirectory 4 -2 roll { .growput } systemdict /superexec known {//superexec}{1183615869 internaldict /superexec get exec} ifelse % readonly
|
||
|
% If the font originated as a resource, register it.
|
||
|
currentfile .currentresourcefile eq { dup .registerfont } if
|
||
|
readonly
|
||
|
@@ -943,7 +943,7 @@ $error /SubstituteFont { } put
|
||
|
% Try to find a font using only the present contents of Fontmap.
|
||
|
/.tryfindfont { % <fontname> .tryfindfont <font> true
|
||
|
% <fontname> .tryfindfont false
|
||
|
- .FontDirectory 1 index .fontknownget
|
||
|
+ //.FontDirectory 1 index .fontknownget
|
||
|
{ % Already loaded
|
||
|
exch pop //true
|
||
|
}
|
||
|
@@ -975,7 +975,7 @@ $error /SubstituteFont { } put
|
||
|
{ % Font with a procedural definition
|
||
|
exec % The procedure will load the font.
|
||
|
% Check to make sure this really happened.
|
||
|
- .FontDirectory 1 index .knownget
|
||
|
+ //.FontDirectory 1 index .knownget
|
||
|
{ exch pop //true exit }
|
||
|
if
|
||
|
}
|
||
|
@@ -1081,11 +1081,11 @@ $error /SubstituteFont { } put
|
||
|
% because it's different depending on language level.
|
||
|
.currentglobal exch /.setglobal .systemvar exec
|
||
|
% Remove the fake definition, if any.
|
||
|
- .FontDirectory 3 index .forceundef % readonly
|
||
|
- 1 index (r) file .loadfont .FontDirectory exch
|
||
|
+ //.FontDirectory 3 index .forceundef % readonly
|
||
|
+ 1 index (r) file .loadfont //.FontDirectory exch
|
||
|
/.setglobal .systemvar exec
|
||
|
} executeonly
|
||
|
- { .loadfont .FontDirectory
|
||
|
+ { .loadfont //.FontDirectory
|
||
|
}
|
||
|
ifelse
|
||
|
% Stack: fontname fontfilename fontdirectory
|
||
|
@@ -1119,8 +1119,8 @@ $error /SubstituteFont { } put
|
||
|
% Stack: origfontname fontdirectory filefontname fontdict
|
||
|
3 -1 roll pop
|
||
|
% Stack: origfontname filefontname fontdict
|
||
|
- dup /FontName get dup FontDirectory exch .forceundef
|
||
|
- GlobalFontDirectory exch .forceundef
|
||
|
+ dup /FontName get dup //.FontDirectory exch .forceundef
|
||
|
+ /GlobalFontDirectory .systemvar exch .forceundef
|
||
|
dup length dict .copydict dup 3 index /FontName exch put
|
||
|
2 index exch definefont
|
||
|
exch
|
||
|
@@ -1176,10 +1176,10 @@ currentdict /.putgstringcopy .undef
|
||
|
{
|
||
|
{
|
||
|
pop dup type /stringtype eq { cvn } if
|
||
|
- .FontDirectory 1 index known not {
|
||
|
+ //.FontDirectory 1 index known not {
|
||
|
2 dict dup /FontName 3 index put
|
||
|
dup /FontType 1 put
|
||
|
- .FontDirectory 3 1 roll { put } systemdict /superexec known {//superexec}{1183615869 internaldict /superexec get exec} ifelse % readonly
|
||
|
+ //.FontDirectory 3 1 roll { put } systemdict /superexec known {//superexec}{1183615869 internaldict /superexec get exec} ifelse % readonly
|
||
|
} {
|
||
|
pop
|
||
|
} ifelse
|
||
|
diff --git a/Resource/Init/gs_init.ps b/Resource/Init/gs_init.ps
|
||
|
index 56c0bd2..d9a0829 100644
|
||
|
--- a/Resource/Init/gs_init.ps
|
||
|
+++ b/Resource/Init/gs_init.ps
|
||
|
@@ -1168,8 +1168,8 @@ errordict /unknownerror .undef
|
||
|
}ifelse
|
||
|
}forall
|
||
|
noaccess pop
|
||
|
- systemdict /.setsafeerrors .forceundef
|
||
|
- systemdict /.SAFERERRORLIST .forceundef
|
||
|
+ //systemdict /.setsafeerrors .forceundef
|
||
|
+ //systemdict /.SAFERERRORLIST .forceundef
|
||
|
} bind executeonly odef
|
||
|
|
||
|
SAFERERRORS {.setsafererrors} if
|
||
|
@@ -2114,7 +2114,7 @@ currentdict /tempfilepaths undef
|
||
|
|
||
|
/.locksafe {
|
||
|
.locksafe_userparams
|
||
|
- systemdict /getenv {pop //false} .forceput
|
||
|
+ //systemdict /getenv {pop //false} .forceput
|
||
|
% setpagedevice has the side effect of clearing the page, but
|
||
|
% we will just document that. Using setpagedevice keeps the device
|
||
|
% properties and pagedevice .LockSafetyParams in agreement even
|
||
|
--
|
||
|
2.20.1
|
||
|
|