70 lines
2.3 KiB
Diff
70 lines
2.3 KiB
Diff
|
http://sourceware.org/ml/gdb-patches/2015-10/msg00510.html
|
||
|
|
Subject: [patch] Fix access_to_packed_array.exp typos/errors [Re: [PATCH] [Ada] Fix the evaluation of access to packed array subscript]
|
||
|
|
|
||
|
|
|
||
|
|
--r5Pyd7+fXNt84Ff3
|
||
|
|
Content-Type: text/plain; charset=us-ascii
|
||
|
|
Content-Disposition: inline
|
||
|
|
|
||
|
|
On Mon, 14 Sep 2015 16:18:00 +0200, Joel Brobecker wrote:
|
||
|
|
> > * gdb.ada/access_to_packed_array.exp: New testcase.
|
||
|
|
>
|
||
|
|
> Looks good to me. Please go ahead and push.
|
||
|
|
|
||
|
|
Running ./gdb.ada/access_to_packed_array.exp ...
|
||
|
|
ERROR: tcl error sourcing ./gdb.ada/access_to_packed_array.exp.
|
||
|
|
ERROR: extra characters after close-quote
|
||
|
|
while executing
|
||
|
|
"gdb_test "print pack.a" "\\(0 => 1, 2, 3, 4, 5, 6, 7, 8, 9, 10\\)")"
|
||
|
|
(file "./gdb.ada/access_to_packed_array.exp" line 29)
|
||
|
|
invoked from within
|
||
|
|
"source ./gdb.ada/access_to_packed_array.exp"
|
||
|
|
("uplevel" body line 1)
|
||
|
|
invoked from within
|
||
|
|
"uplevel #0 source ./gdb.ada/access_to_packed_array.exp"
|
||
|
|
invoked from within
|
||
|
|
"catch "uplevel #0 source $test_file_name""
|
||
|
|
|
||
|
|
Attaching a fix of the typos.
|
||
|
|
|
||
|
|
Unrelated to the typos I have changed the print expectations s/"x"/" = x"/
|
||
|
|
as for example expectation "3" should not match " = 43".
|
||
|
|
|
||
|
|
On Fedora 21 x86_64 it then:
|
||
|
|
# of expected passes 5
|
||
|
|
|
||
|
|
OK for check-in?
|
||
|
|
|
||
|
|
|
||
|
|
Jan
|
||
|
|
|
||
|
|
--r5Pyd7+fXNt84Ff3
|
||
|
|
Content-Type: text/plain; charset=us-ascii
|
||
|
|
Content-Disposition: inline; filename=1
|
||
|
|
|
||
|
|
gdb/testsuite/ChangeLog
|
||
|
|
2015-10-25 Jan Kratochvil <jan.kratochvil@redhat.com>
|
||
|
|
|
||
|
|
* gdb.ada/access_to_packed_array.exp: Fix typos erroring the testfile.
|
||
|
|
|
||
|
|
diff --git a/gdb/testsuite/gdb.ada/access_to_packed_array.exp b/gdb/testsuite/gdb.ada/access_to_packed_array.exp
|
||
|
|
index 0dca780..1bf3e22 100644
|
||
|
|
--- a/gdb/testsuite/gdb.ada/access_to_packed_array.exp
|
||
|
|
+++ b/gdb/testsuite/gdb.ada/access_to_packed_array.exp
|
||
|
|
@@ -26,8 +26,8 @@ clean_restart ${testfile}
|
||
|
|
set bp_location [gdb_get_line_number "BREAK" ${testdir}/foo.adb]
|
||
|
|
runto "foo.adb:$bp_location"
|
||
|
|
|
||
|
|
-gdb_test "print pack.a" "\\(0 => 1, 2, 3, 4, 5, 6, 7, 8, 9, 10\\)")
|
||
|
|
-gdb_test "pack.aa" "\\(access pack\\.array_type\\) 0x.* <pack\\.a>")
|
||
|
|
+gdb_test "print pack.a" " = \\(0 => 1, 2, 3, 4, 5, 6, 7, 8, 9, 10\\)"
|
||
|
|
+gdb_test "print pack.aa" " = \\(access pack\\.array_type\\) 0x.* <pack\\.a>"
|
||
|
|
|
||
|
|
-gdb_test "pack.a(2)" "3"
|
||
|
|
-gdb_test "pack.aa(2)" "3"
|
||
|
|
+gdb_test "print pack.a(2)" " = 3"
|
||
|
|
+gdb_test "print pack.aa(2)" " = 3"
|
||
|
|
|
||
|
|
--r5Pyd7+fXNt84Ff3--
|
||
|
|
|