27 lines
867 B
Diff
27 lines
867 B
Diff
From 60b5598032b3c36660984e7d49a5ff929ecd6e26 Mon Sep 17 00:00:00 2001
|
|
From: Richard Hughes <richard@hughsie.com>
|
|
Date: Mon, 8 Feb 2021 18:41:45 +0000
|
|
Subject: [PATCH 11/11] wacom-usb: Fix a buffer-overread spotted by
|
|
AddressSanitizer
|
|
|
|
---
|
|
plugins/wacom-usb/fu-wac-firmware.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git plugins/wacom-usb/fu-wac-firmware.c plugins/wacom-usb/fu-wac-firmware.c
|
|
index d3a41682..ae1e7cac 100644
|
|
--- plugins/wacom-usb/fu-wac-firmware.c
|
|
+++ plugins/wacom-usb/fu-wac-firmware.c
|
|
@@ -65,7 +65,7 @@ fu_wac_firmware_parse (FuFirmware *firmware,
|
|
guint cmdlen = strlen (lines[i]);
|
|
|
|
/* header info record */
|
|
- if (memcmp (lines[i] + 2, "COM", 3) == 0) {
|
|
+ if (cmdlen > 3 && memcmp (lines[i] + 2, "COM", 3) == 0) {
|
|
guint8 header_image_cnt = 0;
|
|
if (cmdlen != 40) {
|
|
g_set_error (error,
|
|
--
|
|
2.29.2
|
|
|